From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 10:53:24 +0000 Message-ID: References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <87y2klf1u7.fsf@gmail.com> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17995"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Ergus , Eli Zaretskii , Yuan Fu , emacs-devel , Juri Linkov To: =?ISO-8859-15?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 12:54:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPO8n-0004aL-Hb for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 12:54:49 +0200 Original-Received: from localhost ([::1]:59144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPO8m-00038Q-JF for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 06:54:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPO7g-0001qC-2n for emacs-devel@gnu.org; Mon, 05 Oct 2020 06:53:40 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:61295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPO7d-0001h6-2Y; Mon, 05 Oct 2020 06:53:39 -0400 Original-Received: from sdf.org (IDENT:ghe@otaku.sdf.org [205.166.94.8]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 095ArRjR025641 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 5 Oct 2020 10:53:27 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 095ArQs7013597; Mon, 5 Oct 2020 10:53:26 GMT In-Reply-To: <87y2klf1u7.fsf@gmail.com> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 06:53:34 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257102 Archived-At: >> Part 1 of the solution (which solves the "root" problem, and is not >> specific to icomplete-vertical): > > Right. I appreciate this separation: solve a bug _then_ implement a > feature. > Thank you :-) > > Now, as far as I understand Eli and remaining maintainers are not OK > with your bugfix. > No, Eli is "not against using this as a workaround [...] until the better solution arrives". It's not yet clear what that "better solution" will be, and when it will be implemented. And for code that needs to work on older Emacsen, this will remain a good solution. >> (setq icomplete-separator "\n") >> (add-hook 'icomplete-minibuffer-setup-hook (lambda () (setq start-display-at-beginning-of-minibuffer t))) >> (defun icomplete-vertical-reformat-completions (completions) >> (save-match-data >> (if (string-match "^\\((.*)\\|\\[.+\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" completions) >> (format "%s \n%s" (or (match-string 1 completions) "") (match-string 2 completions)) >> completions))) >> (advice-add 'icomplete-completions :filter-return #'icomplete-vertical-reformat-completions) > > For example, in my verticality thing I would even remove one extra > feature of your implementation that I don't find useful: the indentation > of the candidates. > Indeed, I forgot to remove this from my code when I first sent my proposed solution two weeks ago. This extra feature is not anymore present in the above code.