From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Dealing with obsoletion warnings in non-core code Date: Tue, 29 Sep 2020 09:33:20 +0000 Message-ID: References: <20200928143540.GB1002@odonien.localdomain> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2689"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: emacs-devel@gnu.org To: Vasilij Schneidermann Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 29 11:34:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNC1b-0000Wl-3b for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Sep 2020 11:34:19 +0200 Original-Received: from localhost ([::1]:41156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNC1a-0002Es-71 for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Sep 2020 05:34:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNC0o-0001pH-6H for emacs-devel@gnu.org; Tue, 29 Sep 2020 05:33:30 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:53642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNC0m-0005Ss-6A for emacs-devel@gnu.org; Tue, 29 Sep 2020 05:33:29 -0400 Original-Received: from sdf.org (IDENT:ghe@otaku.sdf.org [205.166.94.8]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08T9XNMG007149 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 29 Sep 2020 09:33:23 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08T9XeYA019142; Tue, 29 Sep 2020 09:33:40 GMT In-Reply-To: Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 04:21:17 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256682 Archived-At: >>> The same trick however cannot be used for functions/variables declared >>> obsoleted, the only construct I've found to work in this case is the >>> following: >>> >>> (with-suppressed-warnings ((obsolete old-but-useful-function)) >>> (if (fboundp 'recommended-function) >>> (recommended-function) >>> (old-but-useful-function))) >>> >>> Ideally I'd like to be able to write the following instead to avoid >>> the needless repetition: >>> >>> (if (fboundp 'recommended-function) >>> (recommended-function) >>> (old-but-useful-function)) >> >> Here's a proposed solution: >> >> (defmacro call (fun &rest args) `(funcall (intern (symbol-name ,fun)) ,@args)) >> >> (defun select-text (text) >> (if (> emacs-major-version 25) >> (call 'gui-select-text text) >> (call 'x-select-text text))) >> >> It avoids the needless repetition, and does not give warnings on older >> Emacsen that do not know about gui-select-text, or on newer Emacsen >> that have x-select-text marked as obsolete. >> > > P.S.: > > Obviously > > (defun select-text (text) > (if (fboundp 'gui-select-text) > (call 'gui-select-text text) > (call 'x-select-text text))) > > also works. > P.P.S.: And for variables, the equivalent would of course be: (defmacro assign (var val) `(set (intern (symbol-name ,var)) ,val)) (if (boundp 'switch-to-prev-buffer-skip) (assign 'switch-to-prev-buffer-skip t) (assign 'switch-to-visible-buffer t))