unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Gregory Heytings via "Emacs development discussions." <emacs-devel@gnu.org>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: emacs-devel@gnu.org
Subject: Re: Dealing with obsoletion warnings in non-core code
Date: Tue, 29 Sep 2020 08:21:10 +0000	[thread overview]
Message-ID: <alpine.NEB.2.22.394.2009291011570453.9719@sdf.lonestar.org> (raw)
In-Reply-To: <20200928143540.GB1002@odonien.localdomain>


> The same trick however cannot be used for functions/variables declared 
> obsoleted, the only construct I've found to work in this case is the 
> following:
>
>    (with-suppressed-warnings ((obsolete old-but-useful-function))
>      (if (fboundp 'recommended-function)
>          (recommended-function)
>        (old-but-useful-function)))
>
> Ideally I'd like to be able to write the following instead to avoid the 
> needless repetition:
>
>    (if (fboundp 'recommended-function)
>        (recommended-function)
>      (old-but-useful-function))

Here's a proposed solution:

(defmacro call (fun &rest args) `(funcall (intern (symbol-name ,fun)) ,@args))

(defun select-text (text)
   (if (> emacs-major-version 25)
       (call 'gui-select-text text)
     (call 'x-select-text text)))

It avoids the needless repetition, and does not give warnings on older 
Emacsen that do not know about gui-select-text, or on newer Emacsen that 
have x-select-text marked as obsolete.



  parent reply	other threads:[~2020-09-29  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 14:35 Dealing with obsoletion warnings in non-core code Vasilij Schneidermann
2020-09-28 17:32 ` Stefan Monnier
2020-09-28 18:16   ` Eli Zaretskii
2020-09-28 18:34     ` Vasilij Schneidermann
2020-09-28 19:00       ` Eli Zaretskii
2020-09-28 19:24     ` Stefan Monnier
2020-09-29 14:07       ` Eli Zaretskii
2020-09-29  8:21 ` Gregory Heytings via Emacs development discussions. [this message]
2020-09-29  8:28   ` Gregory Heytings via Emacs development discussions.
2020-09-29  9:33     ` Gregory Heytings via Emacs development discussions.
2020-09-29 13:11   ` Stefan Monnier
2020-09-29 14:11     ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:46       ` Stefan Monnier
2020-09-29 15:36         ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:55     ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.NEB.2.22.394.2009291011570453.9719@sdf.lonestar.org \
    --to=emacs-devel@gnu.org \
    --cc=ghe@sdf.org \
    --cc=mail@vasilij.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).