From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sun, 20 Sep 2020 14:07:45 +0000 Message-ID: References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Ergus , casouri@gmail.com, joaotavora@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 20 16:08:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kK01B-00055q-Jn for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Sep 2020 16:08:41 +0200 Original-Received: from localhost ([::1]:60194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK01A-0000oR-H5 for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Sep 2020 10:08:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK00W-0000Mh-QP for emacs-devel@gnu.org; Sun, 20 Sep 2020 10:08:02 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:59054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK00T-0007lZ-Rt; Sun, 20 Sep 2020 10:08:00 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08KE7l21009542 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 20 Sep 2020 14:07:48 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08KE81tw008407; Sun, 20 Sep 2020 14:08:01 GMT In-Reply-To: <83sgbczj0i.fsf@gnu.org> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/20 10:07:54 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256252 Archived-At: >> Initially I separated icomplete--prospects only, but then all the >> height calculation complexity came and that's why I ended with the >> complex approach. I didn't know that the prompt issue disappeared with >> >> (setq resize-mini-windows nil) >> >> What I wonder about this is the potential conflicts when another >> package or function relies on resize-mini-windows. And that the ... is >> not shown to indicate that there are more candidates. > > resize-mini-windows is a user option, so resetting it globally is almost > certainly a non-starter. > The three lines I sent: (setq icomplete-separator "\n") (setq icomplete-prospects-height 10) (add-hook 'icomplete-minibuffer-setup-hook (function (lambda () (setq resize-mini-windows nil) (enlarge-window icomplete-prospects-height)))) had no other purpose except demonstrating that (setq resize-mini-windows nil) solves the problem of disappearing prompts. Of course I do not consider that these lines should be blindly used, in fact I wrote "It needs some tweaking, but it works." Indeed one should do something with user preferences, and use a setq-local. The point is that doing this is much simpler than trying to calculate the height of the completion candidate list, which amount (as Stefan wrote) to redoing what redisplay does.