From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sat, 19 Sep 2020 08:35:24 +0000 Message-ID: References: <20200919015957.prffuac2jke3hp6a@Ergus> <20200919061531.oyjlbdvkbeif5fsg@Ergus> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10639"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Eli Zaretskii , casouri@gmail.com, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 19 10:36:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJYML-0002h8-Cy for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 10:36:41 +0200 Original-Received: from localhost ([::1]:32866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJYMK-00051u-Df for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 04:36:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJYLJ-0004XW-Q3 for emacs-devel@gnu.org; Sat, 19 Sep 2020 04:35:41 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:55405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJYLF-0006YX-Rm; Sat, 19 Sep 2020 04:35:37 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08J8ZQvV000173 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 19 Sep 2020 08:35:26 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08J8ZcBK005608; Sat, 19 Sep 2020 08:35:38 GMT In-Reply-To: <20200919061531.oyjlbdvkbeif5fsg@Ergus> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 04:31:01 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256152 Archived-At: > > There is another corner case that is when > > (frame-parameter nil 'minibuffer) is 'only. This was also a problem > reported some days ago needed when using frames and not the minibuffer. > Hmmm... in that case (a corner case, indeed, which does not seem to be covered by the current icomplete implementation), it means that the minibuffer is not resized att all? TBH, it seems to me that using icomplete with a minibuffer-only frame does not have much sense. That being said, it is always possible to imagine more corner cases, for example a completion candidate that would fill more than one line, or a completion candidate list with different fonts (I'm not sure that this is actually feasible), or completion candidates with embedded newlines, or... > > The other problem with the patch is that due to rounding and floor when > using different fonts there is too much extra space missing and > sometimes missed a candidate at the end. This was also reported some > days ago. > I don't think so, but I could be wrong. I tested my code with many different parameters, and did not see the "extra space" you mention, in all cases the completions fit perfectly in the minibuffer, and the prompt is never hidden. > > Look at the attached patch as it is partially simplified in my local > branch. > Thanks, I'll have a look. Gregory