From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Fri, 18 Sep 2020 21:39:58 +0000 Message-ID: References: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="-212064758-1950310125-1600464491=:20367" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23223"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Eli Zaretskii , casouri@gmail.com, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 23:41:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJO8S-0005wr-Iu for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 23:41:40 +0200 Original-Received: from localhost ([::1]:55996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJO8R-0001NW-FS for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 17:41:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO77-0000ey-Nz for emacs-devel@gnu.org; Fri, 18 Sep 2020 17:40:18 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:49304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO74-0003vi-A4; Fri, 18 Sep 2020 17:40:17 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08ILe1vY014349 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 18 Sep 2020 21:40:01 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08ILeD9w011312; Fri, 18 Sep 2020 21:40:13 GMT In-Reply-To: Content-ID: Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 17:40:08 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256138 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---212064758-1950310125-1600464491=:20367 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-ID: Hi Ergus, I don't understand why you change so many things in icomplete.el for icomplete-vertical. I attach a patch which implements icomplete-vertical by adding only 20 lines to that file. It seems to work correctly. Use it with: (icomplete-mode 1) (setq icomplete-vertical t) and set `icomplete-prospects-height' to the maximal number of completion candidates you want to display, for example: (setq icomplete-prospects-height 10) Gregory ---212064758-1950310125-1600464491=:20367 Content-Type: text/x-diff; name=icomplete.patch; charset=us-ascii Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=icomplete.patch LS0tIGEvaWNvbXBsZXRlLmVsCTIwMjAtMDktMDEgMTA6MTQ6MjIuMDAwMDAw MDAwICswMDAwDQorKysgYi9pY29tcGxldGUuZWwJMjAyMC0wOS0xOCAyMTox NDoxNS4wMDAwMDAwMDAgKzAwMDANCkBAIC02Miw2ICs2MiwxMCBAQA0KICAg OnR5cGUgJ3N0cmluZw0KICAgOnZlcnNpb24gIjI0LjQiKQ0KIA0KKyhkZWZj dXN0b20gaWNvbXBsZXRlLXZlcnRpY2FsIG5pbCAiLi4uIikNCisNCisoZGVm dmFyIGljb21wbGV0ZS0tcHJvc3BlY3RzLWNvdW50IDAgIi4uLiIpDQorDQog KGRlZmN1c3RvbSBpY29tcGxldGUtaGlkZS1jb21tb24tcHJlZml4IHQNCiAg ICJXaGVuIG5vbi1uaWwsIGhpZGUgY29tbW9uIHByZWZpeCBmcm9tIGNvbXBs ZXRpb24gY2FuZGlkYXRlcy4NCiBXaGVuIG5pbCwgc2hvdyBjYW5kaWRhdGVz IGluIGZ1bGwuIg0KQEAgLTU3Myw3ICs1NzcsMTAgQEANCiAgICAgICAgICAg ICAgIDs7IG1hcmtlcidzIHN0aWNraW5lc3MgdG8gZmlndXJlIG91dCB3aGV0 aGVyIHRvIHBsYWNlIHRoZSBjdXJzb3INCiAgICAgICAgICAgICAgIDs7IGJl Zm9yZSBvciBhZnRlciB0aGUgc3RyaW5nLCBzbyBsZXQncyBzcG9vbi1mZWVk IGl0IHRoZSBwb3MuDQogICAgICAgICAgICAgICAocHV0LXRleHQtcHJvcGVy dHkgMCAxICdjdXJzb3IgdCB0ZXh0KQ0KLSAgICAgICAgICAgICAgKG92ZXJs YXktcHV0IGljb21wbGV0ZS1vdmVybGF5ICdhZnRlci1zdHJpbmcgdGV4dCkp KSkpKSkpDQorICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgaWNvbXBsZXRl LW92ZXJsYXkgJ2FmdGVyLXN0cmluZyB0ZXh0KQ0KKwkgICAgICAoaWYgKGFu ZCAoPiAod2luZG93LWhlaWdodCkgaWNvbXBsZXRlLS1wcm9zcGVjdHMtY291 bnQpDQorCQkgICAgICAgKDwgaWNvbXBsZXRlLS1wcm9zcGVjdHMtY291bnQg aWNvbXBsZXRlLXByb3NwZWN0cy1oZWlnaHQpKQ0KKwkJICAoc2hyaW5rLXdp bmRvdyAoLSBpY29tcGxldGUtcHJvc3BlY3RzLWhlaWdodCBpY29tcGxldGUt LXByb3NwZWN0cy1jb3VudCkpKSkpKSkpKSkNCiANCiA7OztfID4gaWNvbXBs ZXRlLWNvbXBsZXRpb25zIChuYW1lIGNhbmRpZGF0ZXMgcHJlZGljYXRlIHJl cXVpcmUtbWF0Y2gpDQogKGRlZnVuIGljb21wbGV0ZS1jb21wbGV0aW9ucyAo bmFtZSBjYW5kaWRhdGVzIHByZWRpY2F0ZSByZXF1aXJlLW1hdGNoKQ0KQEAg LTY1MCwxOCArNjU3LDIyIEBADQogCQkJCSh0IChjb25jYXQgZWxsaXBzaXMg KHN1YnN0cmluZyBtb3N0IGNvbXBhcmUpKSkpDQogCQkJICAgICAgIGNsb3Nl LWJyYWNrZXQpKSkNCiAJICAgICA7OyItcHJvc3BlY3RzIiAtIG1vcmUgdGhh biBvbmUgY2FuZGlkYXRlDQotCSAgICAgKHByb3NwZWN0cy1sZW4gKCsgKHN0 cmluZy13aWR0aA0KLQkJCQkob3IgZGV0ZXJtIChjb25jYXQgb3Blbi1icmFj a2V0IGNsb3NlLWJyYWNrZXQpKSkNCi0JCQkgICAgICAgKHN0cmluZy13aWR0 aCBpY29tcGxldGUtc2VwYXJhdG9yKQ0KLQkJCSAgICAgICAoKyAyIChzdHJp bmctd2lkdGggZWxsaXBzaXMpKSA7OyB0YWtlIHvigKZ9IGludG8gYWNjb3Vu dA0KLQkJCSAgICAgICAoc3RyaW5nLXdpZHRoIChidWZmZXItc3RyaW5nKSkp KQ0KKwkgICAgIChwcm9zcGVjdHMtbGVuIChpZiBpY29tcGxldGUtdmVydGlj YWwNCisJCQkJMA0KKwkJCSAgICAgICgrIChzdHJpbmctd2lkdGgNCisJCQkJ ICAob3IgZGV0ZXJtIChjb25jYXQgb3Blbi1icmFja2V0IGNsb3NlLWJyYWNr ZXQpKSkNCisJCQkJIChzdHJpbmctd2lkdGggaWNvbXBsZXRlLXNlcGFyYXRv cikNCisJCQkJICgrIDIgKHN0cmluZy13aWR0aCBlbGxpcHNpcykpIDs7IHRh a2Uge+KApn0gaW50byBhY2NvdW50DQorCQkJCSAoc3RyaW5nLXdpZHRoIChi dWZmZXItc3RyaW5nKSkpKSkNCiAgICAgICAgICAgICAgKHByb3NwZWN0cy1t YXgNCi0gICAgICAgICAgICAgIDs7IE1heCB0b3RhbCBsZW5ndGggdG8gdXNl LCBpbmNsdWRpbmcgdGhlIG1pbmlidWZmZXIgY29udGVudC4NCi0gICAgICAg ICAgICAgICgqICgrIGljb21wbGV0ZS1wcm9zcGVjdHMtaGVpZ2h0DQotICAg ICAgICAgICAgICAgICAgICA7OyBJZiB0aGUgbWluaWJ1ZmZlciBjb250ZW50 IGFscmVhZHkgdXNlcyB1cCBtb3JlIHRoYW4NCi0gICAgICAgICAgICAgICAg ICAgIDs7IG9uZSBsaW5lLCBpbmNyZWFzZSB0aGUgYWxsb3dhYmxlIHNwYWNl IGFjY29yZGluZ2x5Lg0KLSAgICAgICAgICAgICAgICAgICAgKC8gcHJvc3Bl Y3RzLWxlbiAod2luZG93LXdpZHRoKSkpDQotICAgICAgICAgICAgICAgICAo d2luZG93LXdpZHRoKSkpDQorCSAgICAgIChpZiBpY29tcGxldGUtdmVydGlj YWwNCisJCSAgaWNvbXBsZXRlLXByb3NwZWN0cy1oZWlnaHQNCisJCTs7IE1h eCB0b3RhbCBsZW5ndGggdG8gdXNlLCBpbmNsdWRpbmcgdGhlIG1pbmlidWZm ZXIgY29udGVudC4NCisJCSgqICgrIGljb21wbGV0ZS1wcm9zcGVjdHMtaGVp Z2h0DQorICAgICAgICAgICAgICAgICAgICAgIDs7IElmIHRoZSBtaW5pYnVm ZmVyIGNvbnRlbnQgYWxyZWFkeSB1c2VzIHVwIG1vcmUgdGhhbg0KKyAgICAg ICAgICAgICAgICAgICAgICA7OyBvbmUgbGluZSwgaW5jcmVhc2UgdGhlIGFs bG93YWJsZSBzcGFjZSBhY2NvcmRpbmdseS4NCisgICAgICAgICAgICAgICAg ICAgICAgKC8gcHJvc3BlY3RzLWxlbiAod2luZG93LXdpZHRoKSkpDQorICAg ICAgICAgICAgICAgICAgICh3aW5kb3ctd2lkdGgpKSkpDQogICAgICAgICAg ICAgIDs7IEZpbmQgdGhlIGNvbW1vbiBwcmVmaXggYW1vbmcgYGNvbXBzJy4N CiAgICAgICAgICAgICAgOzsgV2UgY2FuJ3QgdXNlIHRoZSBvcHRpbWl6YXRp b24gYmVsb3cgYmVjYXVzZSBpdHMgYXNzdW1wdGlvbnMNCiAgICAgICAgICAg ICAgOzsgYXJlbid0IGFsd2F5cyB0cnVlLCBlLmcuIHdoZW4gY29tcGxldGlv bi1jeWNsaW5nIChidWcjMTA4NTApOg0KQEAgLTcwNSwxMyArNzE2LDIwIEBA DQogCSAgICAoc2V0cSBjb21wDQogCQkgIChpZiBwcmVmaXgtbGVuIChzdWJz dHJpbmcgKGNhciBjb21wcykgcHJlZml4LWxlbikgKGNhciBjb21wcykpDQog CQkgIGNvbXBzIChjZHIgY29tcHMpKQ0KLQkgICAgKHNldHEgcHJvc3BlY3Rz LWxlbg0KLSAgICAgICAgICAgICAgICAgICgrIChzdHJpbmctd2lkdGggY29t cCkNCi0JCSAgICAgKHN0cmluZy13aWR0aCBpY29tcGxldGUtc2VwYXJhdG9y KQ0KLQkJICAgICBwcm9zcGVjdHMtbGVuKSkNCisJICAgIChpZiBpY29tcGxl dGUtdmVydGljYWwNCisJCShpZiAoPiAobGVuZ3RoIGNvbXApIDApDQorCQkg ICAgKHNldHEgcHJvc3BlY3RzLWxlbiAoMSsgcHJvc3BlY3RzLWxlbikpKQ0K KwkgICAgICAoc2V0cSBwcm9zcGVjdHMtbGVuDQorICAgICAgICAgICAgICAg ICAgICAoKyAoc3RyaW5nLXdpZHRoIGNvbXApDQorCQkgICAgICAgKHN0cmlu Zy13aWR0aCBpY29tcGxldGUtc2VwYXJhdG9yKQ0KKwkJICAgICAgIHByb3Nw ZWN0cy1sZW4pKSkNCiAJICAgIChpZiAoPCBwcm9zcGVjdHMtbGVuIHByb3Nw ZWN0cy1tYXgpDQotCQkocHVzaCBjb21wIHByb3NwZWN0cykNCisJCShpZiBp Y29tcGxldGUtdmVydGljYWwNCisJCSAgICAoaWYgKD4gKGxlbmd0aCBjb21w KSAwKQ0KKwkJCShwdXNoIGNvbXAgcHJvc3BlY3RzKSkNCisJCSAgKHB1c2gg Y29tcCBwcm9zcGVjdHMpKQ0KIAkgICAgICAoc2V0cSBsaW1pdCB0KSkpKQ0K Kwkoc2V0cSBpY29tcGxldGUtLXByb3NwZWN0cy1jb3VudCBwcm9zcGVjdHMt bGVuKQ0KIAkoc2V0cSBwcm9zcGVjdHMgKG5yZXZlcnNlIHByb3NwZWN0cykp DQogICAgICAgICA7OyBSZXR1cm4gdGhlIGZpcnN0IG1hdGNoIGlmIHRoZSB1 c2VyIGhpdHMgZW50ZXIuDQogICAgICAgICAod2hlbiBpY29tcGxldGUtc2hv dy1tYXRjaGVzLW9uLW5vLWlucHV0DQpAQCAtNzI2LDExICs3NDQsMTYgQEAN CiAgICAgICAgIDs7IGlzIGNhY2hlZC4NCiAgICAgICAgIChpZiBsYXN0IChz ZXRjZHIgbGFzdCBiYXNlLXNpemUpKQ0KIAkoaWYgcHJvc3BlY3RzDQotCSAg ICAoY29uY2F0IGRldGVybQ0KLQkJICAgICJ7Ig0KLQkJICAgIChtYXBjb25j YXQgJ2lkZW50aXR5IHByb3NwZWN0cyBpY29tcGxldGUtc2VwYXJhdG9yKQ0K LQkJICAgIChhbmQgbGltaXQgKGNvbmNhdCBpY29tcGxldGUtc2VwYXJhdG9y IGVsbGlwc2lzKSkNCi0JCSAgICAifSIpDQorCSAgICAoaWYgaWNvbXBsZXRl LXZlcnRpY2FsDQorCQkoY29uY2F0IGRldGVybQ0KKwkJCSIgXG4iDQorCQkJ KG1hcGNvbmNhdCAnaWRlbnRpdHkgcHJvc3BlY3RzICJcbiIpDQorCQkJKGFu ZCBsaW1pdCAoY29uY2F0ICJcbiIgZWxsaXBzaXMpKSkNCisJICAgICAgKGNv bmNhdCBkZXRlcm0NCisJCSAgICAgICJ7Ig0KKwkJICAgICAgKG1hcGNvbmNh dCAnaWRlbnRpdHkgcHJvc3BlY3RzIGljb21wbGV0ZS1zZXBhcmF0b3IpDQor CQkgICAgICAoYW5kIGxpbWl0IChjb25jYXQgaWNvbXBsZXRlLXNlcGFyYXRv ciBlbGxpcHNpcykpDQorCQkgICAgICAifSIpKQ0KIAkgIChjb25jYXQgZGV0 ZXJtICIgW01hdGNoZWRdIikpKSkpKQ0KIA0KIDs7OyBJc3dpdGNoYiBjb21w YXRpYmlsaXR5DQo= ---212064758-1950310125-1600464491=:20367--