From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: feature/icomplete-vertical Date: Sat, 12 Sep 2020 13:10:57 +0000 Message-ID: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Eli Zaretskii , casouri@gmail.com, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 15:11:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH5Jo-00016A-GF for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 15:11:52 +0200 Original-Received: from localhost ([::1]:57026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH5Jn-0001qc-GK for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 09:11:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH5JC-0001RI-Rp for emacs-devel@gnu.org; Sat, 12 Sep 2020 09:11:14 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:55249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH5JA-000497-HK; Sat, 12 Sep 2020 09:11:14 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08CDB0Pf008377 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 12 Sep 2020 13:11:00 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08CDBBfJ025588; Sat, 12 Sep 2020 13:11:11 GMT Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 05:31:13 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255340 Archived-At: > >> If there was a built-in vertical mode it would be better / more >> intuitive. > > Could you try the branch feature/icomplete-vertical? I need some testers > before adding it to master. > Alas no, I have been using the following to have icomplete-vertical for quite some time, it works perfectly well, so I don't see why a more complex implementation would be necessary. (setq icomplete-prospects-height 6) (setq icomplete-separator "\n") (defun icomplete-vertical-minibuffer-setup () (setq truncate-lines t) (setq-local completion-ignore-case t) (setq-local read-file-name-completion-ignore-case t) (setq-local read-buffer-completion-ignore-case t) (setq icomplete-hide-common-prefix nil)) (add-hook 'icomplete-minibuffer-setup-hook #'icomplete-vertical-minibuffer-setup) (defun icomplete-vertical-reformat-completions (completions) (save-match-data (let ((cnp (substring-no-properties completions))) (if (string-match "^\\((.*)\\|\\[.+\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" cnp) (format "%s \n%s" (or (match-string 1 cnp) "") (replace-regexp-in-string "^" (make-string (current-column) ? ) (match-string 2 cnp))) cnp)))) (defun icomplete-vertical-adjust-minibuffer-height (completions) (let* ((comp (icomplete-vertical-reformat-completions completions)) (complen (length (split-string comp "\n")))) (if (> complen 1) (enlarge-window (- icomplete-prospects-height (1- (window-height))))) comp)) (advice-add 'icomplete-completions :filter-return #'icomplete-vertical-adjust-minibuffer-height)