From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: buffer-face-set changes the fringe, is it a bug? Date: Fri, 10 Jul 2020 10:24:32 +0000 Message-ID: References: <2E75863E-82E2-4D61-AD34-0282362C6E99@gnu.org> <835zb2t1t8.fsf@gnu.org> <83lfjwsiin.fsf@gnu.org> <83h7uksehi.fsf@gnu.org> <838sfvs755.fsf@gnu.org> <834kqjrx6v.fsf@gnu.org> <83zh8bqghl.fsf@gnu.org> <83wo3erbga.fsf@gnu.org> <83h7uiqdbj.fsf@gnu.org> <831rlkr4pz.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.21 (NEB 202 2017-01-01) Cc: emacs-devel@gnu.org To: Eli Zaretskii , rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 10 12:25:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtqE3-00027F-Di for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 12:25:51 +0200 Original-Received: from localhost ([::1]:44088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtqE2-0003NW-D0 for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 06:25:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtqD8-0002oO-G3 for emacs-devel@gnu.org; Fri, 10 Jul 2020 06:24:54 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtqD5-0002wH-7h; Fri, 10 Jul 2020 06:24:54 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 06AAOYXJ000615 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 10 Jul 2020 10:24:35 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 06AAOYJ0026695; Fri, 10 Jul 2020 10:24:34 GMT In-Reply-To: <831rlkr4pz.fsf@gnu.org> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/10 06:24:49 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252815 Archived-At: > >> Why not make that an error instead? > > Because it is not an error, it's an entirely valid usage. > That you do not want to change the code is xdisp.c is one thing, with which I'm ok. That you claim that it's a "entirely valid usage" or a "minor issue" is another, and it is plain wrong. I cannot imagine a single scenario where what someone positively wants is to have the colors of an element in the fringe change when, for example, the text is scaled up and down. If you have such a case in mind, please provide it. I filed a bug report against diff-mode.el, in which this happens. What is true is that the default colors of the fringe (black on light gray) and the default colors of the buffer (black on white) are close enough that many users do not see the difference when this happens. I happen to use a different color for the fringe, and I'd bet I'm not the only one to do this. Note the explanation in NEWS.22, when this display property was introduced: "Format is `display (left-fringe BITMAP [FACE])', where BITMAP is a symbol identifying a fringe bitmap, either built-in or defined with `define-fringe-bitmap', and FACE is an optional face name to be used for displaying the bitmap ***instead of the default `fringe' face***. When specified, FACE is automatically merged with the `fringe' face." I took the liberty to add one more message to this already too long thread, to answer RMS's question. Now I stop arguing again. Thank you for your attention. Gregory