From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: debbugs-gnu-bugs shows unanswered bugs as handled Date: Sat, 4 Jun 2016 13:10:22 +0900 (JST) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1465013287 28010 80.91.229.3 (4 Jun 2016 04:08:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2016 04:08:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: michael.albinus@gmx.org, larsi@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 04 06:08:06 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b92sJ-0005xn-89 for ged-emacs-devel@m.gmane.org; Sat, 04 Jun 2016 06:07:51 +0200 Original-Received: from localhost ([::1]:59287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b92sI-0005FW-6o for ged-emacs-devel@m.gmane.org; Sat, 04 Jun 2016 00:07:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b92rn-0005FA-CJ for emacs-devel@gnu.org; Sat, 04 Jun 2016 00:07:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b92rh-000399-9b for emacs-devel@gnu.org; Sat, 04 Jun 2016 00:07:18 -0400 Original-Received: from calancha-ilc.kek.jp ([130.87.234.234]:44531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b92rg-00038l-TP for emacs-devel@gnu.org; Sat, 04 Jun 2016 00:07:13 -0400 Original-Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id AD7D64652; Sat, 4 Jun 2016 13:10:22 +0900 (JST) Original-Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 4A300C85; Sat, 4 Jun 2016 13:10:22 +0900 (JST) X-X-Sender: calancha@calancha-ilc.kek.jp User-Agent: Alpine 2.20 (LRH 67 2015-01-07) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 130.87.234.234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204182 Archived-At: My version of debbugs is: 0.9.5 I) debbugs-gnu-bugs may show a bug with face debbugs-gnu-handled even though such bug has not being answered yet. Current implementation assumes a bug as new (not answered yet) whenever attributes 'date and 'log_modified satisfies predicate '=. But for some new bugs 'date and 'log_modified may differ in 1 second. For instance, the bugs: 23686,23685,23682,23679,23659,23651,23645,23639,23629,23619,23597,23590 *** The patch (see below) solve this issue relaxing the condition to 'log_modified - 'date < 3. II) Another issue with the predicate to assign face 'debbugs-gnu-new is that it may consider as answered a bug where only the OP sent info. For instance, let's suppose one user, FOO, send a bug report; some minutes later, FOO send another e-mail (to same bug) adding extra information. Current implementation shows that bug with face 'debbugs-gnu-handled. That may cause the Emacs maintainers to think that someone is already taking care on that issue. It would be better if such bugs would not get 'debbugs-gnu-handled face until some Emacs maintainer have already answered it. Examples of this are: 23638,23630,23621,23617,23602,23574,23593 *** I don't see easy way to solve this with current implementation. Could be added a new attribute 'ncommunicators' to the status of a bug? The value of this attribute could be defined as: (length (delete-dups (from-list))) where from-list is a list with the FROM field of all the e-mails on that bug. Then, `debbugs-get-status' would have such attribute set to 1 by default; once the bug receive an answer from a different e-mail than the OP then 'ncommunicators' would change to 2, and so on. Tino --- /tmp/ediff2583b8i 2016-06-04 12:39:37.169388859 +0900 +++ /home/calancha/.emacs.d/elpa/debbugs-0.9.5/debbugs-gnu.el 2016-06-03 19:40:12.644524320 +0900 @@ -668,8 +668,8 @@ 'debbugs-gnu-done) ((member "pending" (cdr (assq 'keywords status))) 'debbugs-gnu-pending) - ((< (abs (- (cdr (assq 'date status)) - (cdr (assq 'log_modified status)))) 3) + ((= (cdr (assq 'date status)) + (cdr (assq 'log_modified status))) 'debbugs-gnu-new) ((< (- (float-time) (cdr (assq 'log_modified status)))