From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chip Coldwell Newsgroups: gmane.emacs.devel Subject: [PATCH] font problem in 23.0.60 Date: Thu, 29 May 2008 11:55:49 -0400 (EDT) Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: ger.gmane.org 1212076584 3049 80.91.229.12 (29 May 2008 15:56:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 May 2008 15:56:24 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 29 17:57:05 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K1kUj-0002Vd-HB for ged-emacs-devel@m.gmane.org; Thu, 29 May 2008 17:56:49 +0200 Original-Received: from localhost ([127.0.0.1]:60488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K1kTy-0001NK-0g for ged-emacs-devel@m.gmane.org; Thu, 29 May 2008 11:56:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K1kTu-0001N5-77 for emacs-devel@gnu.org; Thu, 29 May 2008 11:55:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K1kTt-0001Mt-Os for emacs-devel@gnu.org; Thu, 29 May 2008 11:55:57 -0400 Original-Received: from [199.232.76.173] (port=35397 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K1kTt-0001Mq-Iz for emacs-devel@gnu.org; Thu, 29 May 2008 11:55:57 -0400 Original-Received: from mx1.redhat.com ([66.187.233.31]:48481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K1kTt-00068t-5s for emacs-devel@gnu.org; Thu, 29 May 2008 11:55:57 -0400 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m4TFtows015801 for ; Thu, 29 May 2008 11:55:51 -0400 Original-Received: from mail.boston.redhat.com (mail.boston.redhat.com [10.16.255.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m4TFtn36031512 for ; Thu, 29 May 2008 11:55:49 -0400 Original-Received: from dhcp-100-19-199.bos.redhat.com (dhcp-100-19-199.bos.redhat.com [10.16.19.199]) by mail.boston.redhat.com (8.13.1/8.13.1) with ESMTP id m4TFtnBj003039 for ; Thu, 29 May 2008 11:55:49 -0400 User-Agent: Alpine 1.10 (LFD 962 2008-03-14) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97981 Archived-At: A recent CVS snapshot (May 27) exhibits the following bug: $ xfd -fn -adobe-courier-medium-r-normal--*-120-75-75-m-70-iso10646-1 works as expected, shows the font exists on my system as -adobe-courier-medium-r-normal--12-120-75-75-m-70-iso10646-1. $ emacs -fn -adobe-courier-medium-r-normal--*-120-75-75-m-70-iso10646-1 Fatal error (11)Segmentation fault (core dumped) I did a little debugging, and found that the SIGSEGV is caused by taking the CDR of an integer. This patch fixes the SIGSEGV --- src/font.c~ 2008-05-25 07:00:52.000000000 -0400 +++ src/font.c 2008-05-29 11:44:24.000000000 -0400 @@ -266,7 +266,7 @@ font_pixel_size (f, spec) point_size = XFLOAT_DATA (size); val = AREF (spec, FONT_DPI_INDEX); if (INTEGERP (val)) - dpi = XINT (XCDR (val)); + dpi = XINT (val); else dpi = f->resy; pixel_size = POINT_TO_PIXEL (point_size, dpi); However, now I get src/emacs-23.0.60.3 -fn -adobe-courier-medium-r-normal--12-120-75-75-m-70-iso10646-1 Font `-adobe-courier-medium-r-normal--*-120-75-75-m-70-iso10646-1' is not defined even though it is defined. I will continue to debug that problem as time permits. Chip -- Charles M. "Chip" Coldwell Senior Software Engineer Red Hat, Inc 978-392-2426 GPG ID: 852E052F GPG FPR: 77E5 2B51 4907 F08A 7E92 DE80 AFA9 9A8F 852E 052F