From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master cfa7c4e: Add missing file gited-ci.el Date: Sun, 20 May 2018 12:10:59 +0900 (JST) Message-ID: References: <20180519034013.18440.57172@vcs0.savannah.gnu.org> <20180519034014.37DF720468@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1526785752 702 195.159.176.226 (20 May 2018 03:09:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 May 2018 03:09:12 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: emacs-devel@gnu.org, Tino Calancha To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 20 05:09:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKEiZ-00006K-ED for ged-emacs-devel@m.gmane.org; Sun, 20 May 2018 05:09:07 +0200 Original-Received: from localhost ([::1]:44966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKEkg-0007L7-I9 for ged-emacs-devel@m.gmane.org; Sat, 19 May 2018 23:11:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKEkV-0007Kr-LG for emacs-devel@gnu.org; Sat, 19 May 2018 23:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKEkS-00071t-G8 for emacs-devel@gnu.org; Sat, 19 May 2018 23:11:07 -0400 Original-Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:37422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKEkS-00071h-9P for emacs-devel@gnu.org; Sat, 19 May 2018 23:11:04 -0400 Original-Received: by mail-pf0-x22e.google.com with SMTP id e9-v6so5483154pfi.4 for ; Sat, 19 May 2018 20:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=XwtwDzMiB8TkX1fgpdl7UYTuNhq1m19rFLm3Yx3BTww=; b=HT3kGnaAHbfPW6IP3SjUkhgYCIwy8vSc8BF3LvXreMZ+flkLwtxITt5g6T54JLYU5O A9hR66hYL1bAd1Xqita/52MgVFvLs5P/v6AThbOtnFDtETgRBKBjuZyE3bqsmekimMj0 hWzVwYuMdkeouKSIRUwW5NFwzZCo8a1NNXuZyEaAKCt3mEUFR0T8sEhuGYKju22LkM+k 0b6J1EmqhLZvFdUyLS4yXisWusYLjaDfb47tcnHz+5iiyUd/RvEk0AqiS4cCmYS8zczP ezBSefSMCtMmVVPcUl4ZmQa91BT9rckvk2jjkjLuu5FkD4MjcwyCXLw/cqBrK6qr8hgm 8qyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=XwtwDzMiB8TkX1fgpdl7UYTuNhq1m19rFLm3Yx3BTww=; b=BF6Nho2dRQR3vBSJCKfDIYPJVqbmDPB3b+Y9sn8obTMIgNxJwdGUPVs4pmDODXADjj w1JsuM8gn5qHMUq2Z3BYbJ9uj7DayqTZJ9lpPvK9pyPAUB4/VuvR8nsXNoeXKoi/yvTS VJFehYp+RNKLwahvKlFcRe1LL3O0d8jEAcy4AofQGi02S3nP8bnj4c3qTIkwNLgTuuFH MXuXNihRm1ZsI586USXmamp1PwmIe2i3aHyQ4Pgzyt1d7xHoLmCUZNz+M3Ea/PjWoURm ymduBRgHyH6C7oLDrxCtf3IiF34XMb17Yi2dxRHgsBApetIbup1rDB2hEgr3Ty9o2yis AQoA== X-Gm-Message-State: ALKqPwcgWQWeo0xhktrhG+S6tl/YYyKWyahcvxtpeFzH52/AH/MO9Zrv n7qFvyj/Xd92eGzdUUR3xE0= X-Google-Smtp-Source: AB8JxZpY5R2615t3KDADdtNsJmwk7gU5m6zm2c+y8cj4yVEChBFDv4M2e5ikdhvy63nBMFCC7uidWw== X-Received: by 2002:a63:9517:: with SMTP id p23-v6mr9387869pgd.183.1526785863133; Sat, 19 May 2018 20:11:03 -0700 (PDT) Original-Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id w8-v6sm21142524pfk.112.2018.05.19.20.11.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 20:11:02 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225458 Archived-At: On Sat, 19 May 2018, Stefan Monnier wrote: >> +;;; gited-ci.el --- Obtain CI status of the trunk branch -*- lexical-binding:t -*- >> +;; > > This is missing the copyright and licence blurbs. Fixed in commit 'gited-ci.el: Fix copyright stuff' (228610373722e05776b2af8a03064c6a56f04e2c) > >> +(defcustom gited-show-trunk-ci-status nil >> + "Show CI status for the last commit in the trunk branch. >> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ). > > I usually prefer to say > > ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ... > > So you don't need to talk about the "_I" thingy. Excellent tip! I always suffer such enumerations. Much better now. > But other than this mostly irrelevant nitpick, I have a more serious > comment to make: why not rely on dir-locals variable for that? Never used dir-locals before. I need to study such stuff first :-)