From: Tino Calancha <tino.calancha@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
Date: Sun, 20 May 2018 12:10:59 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1805201203510.3949@calancha-pc> (raw)
In-Reply-To: <jwv7enz4gxl.fsf-monnier+emacsdiffs@gnu.org>
On Sat, 19 May 2018, Stefan Monnier wrote:
>> +;;; gited-ci.el --- Obtain CI status of the trunk branch -*- lexical-binding:t -*-
>> +;;
>
> This is missing the copyright and licence blurbs.
Fixed in commit 'gited-ci.el: Fix copyright stuff'
(228610373722e05776b2af8a03064c6a56f04e2c)
>
>> +(defcustom gited-show-trunk-ci-status nil
>> + "Show CI status for the last commit in the trunk branch.
>> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ).
>
> I usually prefer to say
>
> ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ...
>
> So you don't need to talk about the "_I" thingy.
Excellent tip! I always suffer such enumerations. Much better now.
> But other than this mostly irrelevant nitpick, I have a more serious
> comment to make: why not rely on dir-locals variable for that?
Never used dir-locals before. I need to study such stuff first :-)
next prev parent reply other threads:[~2018-05-20 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180519034013.18440.57172@vcs0.savannah.gnu.org>
[not found] ` <20180519034014.37DF720468@vcs0.savannah.gnu.org>
2018-05-19 18:57 ` [elpa] master cfa7c4e: Add missing file gited-ci.el Stefan Monnier
2018-05-20 3:10 ` Tino Calancha [this message]
2018-05-20 13:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1805201203510.3949@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).