* Re: master 51c8369: Run secrets suite test when Emacs has dbus support [not found] ` <20180406000308.94E77206AB@vcs0.savannah.gnu.org> @ 2018-04-06 7:25 ` Michael Albinus 2018-04-06 7:36 ` Tino Calancha 0 siblings, 1 reply; 9+ messages in thread From: Michael Albinus @ 2018-04-06 7:25 UTC (permalink / raw) To: emacs-devel; +Cc: Tino Calancha tino.calancha@gmail.com (Tino Calancha) writes: Hi Tino, > Run secrets suite test when Emacs has dbus support > > * test/lisp/net/secrets-tests.el (secrets-test00-availability) > (secrets-test01-sessions, secrets-test02-collections) > (secrets-test03-items, secrets-test04-search): Skip test > unless Emacs is compiled with dbus support. Why this? If there is no D-Bus support, secrets-enabled shall be nil, and the tests shall skip (except secrets-test00-availability, which shall fail). That's intended. > (ert-deftest secrets-test00-availability () > "Test availability of Secret Service API." > + (skip-unless (featurep 'dbusbind)) > :expected-result (if secrets-enabled :passed :failed) > (should secrets-enabled) > (should (dbus-ping :session secrets-service)) FTR, this would be wrong. :expected-result must always be the first clause in body. Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 7:25 ` master 51c8369: Run secrets suite test when Emacs has dbus support Michael Albinus @ 2018-04-06 7:36 ` Tino Calancha 2018-04-06 8:04 ` Michael Albinus 2018-04-06 9:20 ` Tino Calancha 0 siblings, 2 replies; 9+ messages in thread From: Tino Calancha @ 2018-04-06 7:36 UTC (permalink / raw) To: Michael Albinus; +Cc: Tino Calancha, Emacs developers On Fri, 6 Apr 2018, Michael Albinus wrote: > tino.calancha@gmail.com (Tino Calancha) writes: > > Hi Tino, > >> Run secrets suite test when Emacs has dbus support >> >> * test/lisp/net/secrets-tests.el (secrets-test00-availability) >> (secrets-test01-sessions, secrets-test02-collections) >> (secrets-test03-items, secrets-test04-search): Skip test >> unless Emacs is compiled with dbus support. > > Why this? If there is no D-Bus support, secrets-enabled shall be nil, > and the tests shall skip (except secrets-test00-availability, which > shall fail). That's intended. I don't know. I saw in our gitlab CI that your new test was failing: https://gitlab.com/emacs-ci/emacs/commits/master > >> (ert-deftest secrets-test00-availability () >> "Test availability of Secret Service API." >> + (skip-unless (featurep 'dbusbind)) >> :expected-result (if secrets-enabled :passed :failed) >> (should secrets-enabled) >> (should (dbus-ping :session secrets-service)) > > FTR, this would be wrong. :expected-result must always be the first > clause in body. I see. Could you please update this part? (Or anyother that you think might be wrong). Thanks. Tino ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 7:36 ` Tino Calancha @ 2018-04-06 8:04 ` Michael Albinus 2018-04-06 8:20 ` Tino Calancha 2018-04-06 9:20 ` Tino Calancha 1 sibling, 1 reply; 9+ messages in thread From: Michael Albinus @ 2018-04-06 8:04 UTC (permalink / raw) To: Tino Calancha; +Cc: Emacs developers Tino Calancha <tino.calancha@gmail.com> writes: Hi Tino, >> Why this? If there is no D-Bus support, secrets-enabled shall be nil, >> and the tests shall skip (except secrets-test00-availability, which >> shall fail). That's intended. > > I don't know. I saw in our gitlab CI that your new test was failing: > https://gitlab.com/emacs-ci/emacs/commits/master I see, thanks. I'll try to reproduce it locally, and fix it properly. For the future: if a test fails, pls report instead of suppressing. That's what tests are good for :-) >> FTR, this would be wrong. :expected-result must always be the first >> clause in body. > > I see. Could you please update this part? (Or anyother that you think > might be wrong). Will do. > Thanks. > Tino Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 8:04 ` Michael Albinus @ 2018-04-06 8:20 ` Tino Calancha 0 siblings, 0 replies; 9+ messages in thread From: Tino Calancha @ 2018-04-06 8:20 UTC (permalink / raw) To: Michael Albinus; +Cc: Emacs developers, Tino Calancha On Fri, 6 Apr 2018, Michael Albinus wrote: > Tino Calancha <tino.calancha@gmail.com> writes: > > Hi Tino, > >>> Why this? If there is no D-Bus support, secrets-enabled shall be nil, >>> and the tests shall skip (except secrets-test00-availability, which >>> shall fail). That's intended. >> >> I don't know. I saw in our gitlab CI that your new test was failing: >> https://gitlab.com/emacs-ci/emacs/commits/master > > I see, thanks. I'll try to reproduce it locally, and fix it > properly. For the future: if a test fails, pls report instead of > suppressing. That's what tests are good for :-) OK. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 7:36 ` Tino Calancha 2018-04-06 8:04 ` Michael Albinus @ 2018-04-06 9:20 ` Tino Calancha 2018-04-06 9:27 ` Michael Albinus 1 sibling, 1 reply; 9+ messages in thread From: Tino Calancha @ 2018-04-06 9:20 UTC (permalink / raw) To: Tino Calancha; +Cc: Michael Albinus, Emacs developers On Fri, 6 Apr 2018, Tino Calancha wrote: >> >>> Run secrets suite test when Emacs has dbus support >>> >>> * test/lisp/net/secrets-tests.el (secrets-test00-availability) >>> (secrets-test01-sessions, secrets-test02-collections) >>> (secrets-test03-items, secrets-test04-search): Skip test >>> unless Emacs is compiled with dbus support. >> >> Why this? If there is no D-Bus support, secrets-enabled shall be nil, >> and the tests shall skip (except secrets-test00-availability, which >> shall fail). That's intended. > I don't know. I saw in our gitlab CI that your new test was failing: > https://gitlab.com/emacs-ci/emacs/commits/master Just re-reading my answer looks unclear (even to me). The reason why I skipped these tests if the feature 'dbusbind is not present was: * After inspecting the gitlab log file I found this: ELC lisp/net/secrets-tests.elc peculiar error: "Emacs not compiled with dbus support" Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed make[3]: *** [lisp/net/secrets-tests.elc] Error 255 make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors. Best regards, Tino ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 9:20 ` Tino Calancha @ 2018-04-06 9:27 ` Michael Albinus 2018-04-06 9:38 ` Tino Calancha 0 siblings, 1 reply; 9+ messages in thread From: Michael Albinus @ 2018-04-06 9:27 UTC (permalink / raw) To: Tino Calancha; +Cc: Emacs developers Tino Calancha <tino.calancha@gmail.com> writes: Hi Tino, > * After inspecting the gitlab log file I found this: > > ELC lisp/net/secrets-tests.elc > peculiar error: "Emacs not compiled with dbus support" > Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed > make[3]: *** [lisp/net/secrets-tests.elc] Error 255 > make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors. Reproduced here (configuring Emacs --without-dbus). This needs to be fixed in dbus.el, which I'm working on. > Best regards, > Tino Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 9:27 ` Michael Albinus @ 2018-04-06 9:38 ` Tino Calancha 2018-04-06 9:52 ` Michael Albinus 0 siblings, 1 reply; 9+ messages in thread From: Tino Calancha @ 2018-04-06 9:38 UTC (permalink / raw) To: Michael Albinus; +Cc: Emacs developers, Tino Calancha On Fri, 6 Apr 2018, Michael Albinus wrote: > Tino Calancha <tino.calancha@gmail.com> writes: > > Hi Tino, > >> * After inspecting the gitlab log file I found this: >> >> ELC lisp/net/secrets-tests.elc >> peculiar error: "Emacs not compiled with dbus support" >> Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed >> make[3]: *** [lisp/net/secrets-tests.elc] Error 255 >> make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors. > > Reproduced here (configuring Emacs --without-dbus). This needs to be > fixed in dbus.el, which I'm working on. Excellent! Looking forward to see your progress! Have a good day, Tino ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 9:38 ` Tino Calancha @ 2018-04-06 9:52 ` Michael Albinus 2018-04-06 10:27 ` Tino Calancha 0 siblings, 1 reply; 9+ messages in thread From: Michael Albinus @ 2018-04-06 9:52 UTC (permalink / raw) To: Tino Calancha; +Cc: Emacs developers Tino Calancha <tino.calancha@gmail.com> writes: > Looking forward to see your progress! Fix committed to master, shall work for you now. > Have a good day, > Tino Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 51c8369: Run secrets suite test when Emacs has dbus support 2018-04-06 9:52 ` Michael Albinus @ 2018-04-06 10:27 ` Tino Calancha 0 siblings, 0 replies; 9+ messages in thread From: Tino Calancha @ 2018-04-06 10:27 UTC (permalink / raw) To: Michael Albinus; +Cc: Emacs developers, Tino Calancha On Fri, 6 Apr 2018, Michael Albinus wrote: > Tino Calancha <tino.calancha@gmail.com> writes: > >> Looking forward to see your progress! > > Fix committed to master, shall work for you now. Indeed, green as the delicious mint leaves around my apartment: https://gitlab.com/emacs-ci/emacs/-/jobs/61518197 Regards, Tino ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-04-06 10:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180406000306.5540.34428@vcs0.savannah.gnu.org>
[not found] ` <20180406000308.94E77206AB@vcs0.savannah.gnu.org>
2018-04-06 7:25 ` master 51c8369: Run secrets suite test when Emacs has dbus support Michael Albinus
2018-04-06 7:36 ` Tino Calancha
2018-04-06 8:04 ` Michael Albinus
2018-04-06 8:20 ` Tino Calancha
2018-04-06 9:20 ` Tino Calancha
2018-04-06 9:27 ` Michael Albinus
2018-04-06 9:38 ` Tino Calancha
2018-04-06 9:52 ` Michael Albinus
2018-04-06 10:27 ` Tino Calancha
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).