From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Sat, 5 Aug 2017 00:10:59 +0900 (JST) Message-ID: References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> <831sorxyol.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-409787786-1501859463=:11976" X-Trace: blaine.gmane.org 1501862805 3920 195.159.176.226 (4 Aug 2017 16:06:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 16:06:45 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: John Wiegley , Eli Zaretskii , Emacs developers , Tino Calancha To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 18:06:41 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddf7W-0000hY-Eg for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 18:06:38 +0200 Original-Received: from localhost ([::1]:50909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddf7c-0002vn-HP for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 12:06:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddeFp-00027V-3y for emacs-devel@gnu.org; Fri, 04 Aug 2017 11:11:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddeFo-0004cz-5o for emacs-devel@gnu.org; Fri, 04 Aug 2017 11:11:09 -0400 Original-Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:37217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddeFk-0004az-OI; Fri, 04 Aug 2017 11:11:04 -0400 Original-Received: by mail-pg0-x22e.google.com with SMTP id y129so9106155pgy.4; Fri, 04 Aug 2017 08:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=NpJdHbd0PSQwe4UBOK4xxS4qJSfgZYcnsieZd26bJbY=; b=ht3WVY69/wtp6m81Uj4MAaqiL9vyArL6lnwjqppkxKVsUZyDVe+E5k2QmxdswGrcab atGwnmehNWnYOShsdw+SM0W75xKMXvBF16ZKiDC2MZVlbqUccpXizNnBbOOLw5H2J1h0 nar8JwaunjgRBuDxHAsxvm7LnF3HzHaKBli7H4GjErHa55AGqkqLKdhoZeGgnbTh34kB XQvMtF6JayOGWi++n+YmGoDXMDcJ9m9+21Ad5DAPRnK8f8eaQTxo79e21tb7yc0nHxi2 9EMQ8pt7bdjLXkLPgayiR8gnRS4AlTnPYUaBZZnkBdAHHJzIsaAhxmTe3SRYYee0JG7v HBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=NpJdHbd0PSQwe4UBOK4xxS4qJSfgZYcnsieZd26bJbY=; b=ar4GYAi9Q8sfi4OxdB3amoij6Q2ofsgCznUiPXyH0962oI2uyrwBTgsXAOuYpoY+p1 C1woFYaHWgZP5CPT9Cq1azpMFyiihwVzjgkH7nx84BQEBXSAGsP3lBC0KrkezsYmEeN3 y9n9pV8u6miFSMY73Om4X22RjZVql3EvjlzcmtT8Oh2kwlDO4riyBD1pHyNkmM2EVHGY /9kSVmaumden20azVtaGMqNa6OAZOKhqTlO1jrJm73l+fNUdnfrdhV6x+0b7gNlnHdw6 xIxHtJSfG2KRFLp49O4xscucp0FbOK9SOUD4ZazFIwEpWmGwsM9/l8r3JZ6xbviST9Tr 5Ljw== X-Gm-Message-State: AIVw11399gf0kJ2xzlDBYmxTgbLlsRLhs6mR2KD6FpwyYG4LohizpnOm XS08LO9TjGg/Zg== X-Received: by 10.98.0.149 with SMTP id 143mr2798940pfa.180.1501859463881; Fri, 04 Aug 2017 08:11:03 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id t199sm2762385pgb.30.2017.08.04.08.11.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Aug 2017 08:11:03 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217302 Archived-At: --8323329-409787786-1501859463=:11976 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Fri, 4 Aug 2017, Fabrice Popineau wrote: > > > 2017-08-04 16:49 GMT+02:00 Tino Calancha : > > > On Fri, 4 Aug 2017, Fabrice Popineau wrote: > > > > 2017-08-04 16:23 GMT+02:00 Fabrice Popineau : > > > Actually, the problem seems to be in the `insert-directory-wildcard-in-dir-p' function > which wrongly splits "c:/tmp/dir*/*.txt" in ("c:/tmp/" . "dir*/*.txt") instead of > ("c:/tmp/dir*/" . "*.txt") > > Forget this (wrong) diagnostic. > > The culprit is actually  > > (let ((default-directory "c:/tmp/")) >   (eshell-extended-glob "dir*/*.txt")) > "dir*/*.txt"  > > which fails to expand the wildcards (when `file-expand-wildcards' succeeds). > > Thank you Fabrice, > that's interesing.  I am just wondering if `eshell-extended-glob' gets confused with the Windows path, i mean, the > disk name 'c:' in front. > > Could you check if the following works? > M-x eshell RET > cd "c:/tmp" > ls -l dir*/*.txt > > It says :  > > c:/tmp $ ls -l dir*/*.txt > dir*/*.txt: No such file or directory  I see. I think hat uses `eshell-extended-glob' as well, so it seems you find a bug in that function. Maybe is better to open a bug report with this eshell recipe above. > > > I am also curious if: > M-: (equal temporary-file-directory "c:/tmp/") RET > => t > > Nope, my temp dir in this case is the Windows temp dir. > ("c:/Users/Fabrice/AppData/Roaming/Local/Temp/")  > > And out of curiosity: what does em-glob that file-expand-wildcards doesn't?  > Because replacing the former by the latter would withdraw a depency on eshell parts in ls-lisp : I think you are right. We must use `file-expand-wildcards'. I think the reason i didn't use this func. is because i didn't know it existance :-) --8323329-409787786-1501859463=:11976--