From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Fri, 4 Aug 2017 22:39:05 +0900 (JST) Message-ID: References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> <831sorxyol.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1501859405 18012 195.159.176.226 (4 Aug 2017 15:10:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 15:10:05 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 17:09:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddeEg-0004GL-O0 for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 17:09:58 +0200 Original-Received: from localhost ([::1]:42853 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddeEm-00009T-Fz for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 11:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcrH-0002S9-2L for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:45:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddcps-00017w-Mx for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:41:43 -0400 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:38164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddcon-0008Dw-Ua; Fri, 04 Aug 2017 09:39:10 -0400 Original-Received: by mail-pg0-x243.google.com with SMTP id 123so1842843pga.5; Fri, 04 Aug 2017 06:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=Vb+4LVAsnL3OvrezOcO4Wu58eCthe7rA4tdGqbeMzZE=; b=XS/z6nABzhwbdQ6OdG+HLEeYpqLx/ZbTdltHVPdXJBNuMHPKwDeoF+aOUl//Bn4wVU uP29OCWEvunASzD8aSVxyoK+a+3z3gsW834lYLzHHhyG7GUHCeY6RD4GwzAxcH6cJZXd CZ5G14C2o/fc4hLfU5VfcLv12v9i7Crm2sIwQehE2H6c22qtSAE8WYcKeRNaHczhc7hl jA4yrbQZJ6rUlXwerC71qGnWEwCx2GqofmdBddybZ4Z5+x7/hv9Oc3M9nh0HJC7CePKS jlKEcwzC8ekPou3iFt1+kegLXVIr2B6m9DZvQU0iTNsj5TzUIb2iP+5WhiAJAtsLd7od dU3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=Vb+4LVAsnL3OvrezOcO4Wu58eCthe7rA4tdGqbeMzZE=; b=MIr1mv6Hifx6T1qCTSenr+obU/j4AvdE9YLqYh/65CM9POCc9JQ4QzEwqUhQ6m3XlD NjnUNdrMmogCKtPYgIC447YoXDPJblGrHNAyYHssXjOJjcsB4th2ReJuNnWiBHNl9bdb SjOWO9UnaZzRsxW6N8HzehTpy109NvBjboNj4emWSlw/eZb7PZ5HzmDBgApkHnwn4+0J lKNsB9DTzWyWRR/WqnVRHvxQ271yFTG9msAiqJRW8a1UHGWQIdPtA3BtH1q8UxSg9qNj y3MgCgVHC0+/+vL1RyyiZiciGV/GXJBJaqOR3tlt63u+e0Eois8HoPwi6sYukT45yts6 MhZg== X-Gm-Message-State: AIVw113XErQSaRGs5FSe7LWDGH1Toorzxq1WHF8JZQruGX8eF9h8u2Wr cCKhbxgEEM0hyyQa X-Received: by 10.84.234.2 with SMTP id m2mr2840679plk.268.1501853948396; Fri, 04 Aug 2017 06:39:08 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id z83sm3392920pfd.10.2017.08.04.06.39.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Aug 2017 06:39:07 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <831sorxyol.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217292 Archived-At: On Fri, 4 Aug 2017, Eli Zaretskii wrote: >> Does it work now in Windows? > > It didn't, but given the comments I've now succeeded to understand the > idea of dired-test-bug25609, and fixed it. Great! Thank you. > dired-test-bug27631 still fails, and it fails because of this: > > (setq buf (dired (expand-file-name "dir*/*.txt" dir))) > > ls-lisp signals an error here: > > wrong-type-argument listp "dir*/*.txt" > > Didn't you add a feature lately that should support this in ls-lisp? > I guess that feature needs to be turned on for this test to pass on > Windows. Yeah, that test must be skipped when Dired is using 'ls' emulation. We have tests for the same bug in ls-lisp-tests.el and em-ls-tests.el. I've just pushed a fix.