From: Tino Calancha <tino.calancha@gmail.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: Re: Question about test failure on Hydra
Date: Tue, 1 Aug 2017 19:17:57 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708011912110.13752@calancha-pc> (raw)
In-Reply-To: <87r2wv7gq5.fsf@rosalinde>
On Tue, 1 Aug 2017, Stephen Berman wrote:
> On Tue, 01 Aug 2017 13:39:50 +0900 Tino Calancha <tino.calancha@gmail.com> wrote:
>
>> Stephen Berman <stephen.berman@gmx.net> writes:
>>
>>> On Mon, 31 Jul 2017 06:26:55 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>> (dired test-dir) reverts an existing Dired buffer, because of setting
>>> dired-auto-revert-buffer to t. (When I step through the code, it is
>>> after reverting that point moves to the subdirectory line, which the
>>> should make "sanity check" true (and does, both when I step through the
>>> code and just run the test in any way). When I comment out the
>>> dired-auto-revert-buffer line, then point stays at point-min, which
>>> makes the sanity check fail (dired-file-name-at-point returns nil),
>> When i comment out i see the point in point-max, and the test fails
>> same as you but: (dired-file-name-at-point returns nil)
>
> I'm seeing point at point-max now, too, but I did see it at point-min
> yesterday and also when I first tried again after reading your mail,
> though, strangely, I can't reproduce that now. I was testing with two
> frames and switched back and forth between them, maybe that affects
> point.
I've made last 24 hours, two commits that might have impact on the
issue at hands:
6ebef3daf24c847d6f16621489ae587e98c11ec0
192342a3a93a2e467ab589ae2d1ffd5e7acf1398
>>> though not in the way Hydra reports (it shows point being on the ".."
>>> entry).)
>> If somehow, we have in such Dired buffer the point at ".." _before_
>> call `dired-revert', then _after_ revert the point is preserved:
>
> Yes, but the question is, how does point get there in Hydra?
That's 1 million dollard question (but i cannot pay such amount to whom
find the answer: just invite 1 icescream).
>
>> We can insert additional `should' calls in the failing tests and
>> wait until next hydra failoure.
>>
>> (Following just add more should forms into `dired-test-bug27243-01'; we
>> might do the same in `dired-test-bug27243-02' and `dired-test-bug27243-03').
>
> That's probably a good idea; can you add them?
I did, just on 'dired-test-bug27243-01' test.
next prev parent reply other threads:[~2017-08-01 10:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 15:50 Question about test failure on Hydra Stephen Berman
2017-07-30 15:59 ` Eli Zaretskii
2017-07-30 20:23 ` Stephen Berman
2017-07-31 3:26 ` Eli Zaretskii
2017-07-31 9:20 ` Stephen Berman
2017-08-01 3:12 ` Eli Zaretskii
2017-08-01 9:57 ` Stephen Berman
2017-08-01 13:49 ` Eli Zaretskii
2017-08-01 15:23 ` Stephen Berman
2017-08-02 15:27 ` Stephen Berman
2017-08-01 4:39 ` Tino Calancha
2017-08-01 9:57 ` Stephen Berman
2017-08-01 10:17 ` Tino Calancha [this message]
2017-08-01 10:47 ` Stephen Berman
2017-08-05 13:07 ` Tino Calancha
2017-08-05 21:34 ` Stephen Berman
2017-08-03 19:41 ` tagging ERT tests with bug numbers (was: Question about test failure on Hydra) Ted Zlatanov
2017-08-04 7:22 ` tagging ERT tests with bug numbers Michael Albinus
2017-08-04 13:28 ` Ted Zlatanov
2017-08-04 14:50 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708011912110.13752@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).