From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings Date: Mon, 20 Mar 2017 23:12:33 +0900 (JST) Message-ID: References: <20170320125824.26461.58778@vcs0.savannah.gnu.org> <20170320125825.4C92420E17@vcs0.savannah.gnu.org> <87pohc9iz3.fsf@lifelogs.com> <87fui89hf7.fsf@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1490019193 632 195.159.176.226 (20 Mar 2017 14:13:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Mar 2017 14:13:13 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Tino Calancha , Emacs developers To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 20 15:13:04 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpy3O-0007SU-Jk for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2017 15:12:58 +0100 Original-Received: from localhost ([::1]:33225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpy3U-0003v9-H4 for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2017 10:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpy3J-0003tE-6o for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:12:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpy3E-00023M-Ly for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:12:53 -0400 Original-Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:34501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpy3E-00022A-Fs for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:12:48 -0400 Original-Received: by mail-pg0-x244.google.com with SMTP id b5so20289393pgg.1 for ; Mon, 20 Mar 2017 07:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ccmotgs6BsQdS4pyRT4MRNIrzPbjl4/yLWjat7KUTEQ=; b=FvM5eiD8pmLGnR4DIxbr00T2BokstCBXuFfxK1qGoYHXVXIoMqQR5WRZvnEeybqjql rHA6u2xBcocCAMvfd9Vvr7XuMCM6QGYFCRzCS3OaHvvparW4oEPf1WDtuyenvlYmoFOM jBDsVy+S0G8Jd2aLLMc6tJ7Rk5I6y+T3ztFqz0wlTBtc7eNYoLy/EZdSYOsLs1jfDpU4 TnvkI7ZRLzw3kCyTgA9vNRsrWXsyFV+7PmPwz8LkSQBkMYS968/msfqGHkgncxOM7KNb 4Jfac5TPOCAMwehYhuPjrzvK0C83doQgQayKOc8Ow6roiCSexhEpopWUtvGX+C8e6AVS ht+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ccmotgs6BsQdS4pyRT4MRNIrzPbjl4/yLWjat7KUTEQ=; b=Pu8j32OLoAnJY9Fw3syl6cJUG9fiHHODBz0LH2VHKtcS4OfXhOEUepRuhptqPcrqQA 1m6p+sfOvqGjw4ssyoInpUXqc3smcQ7g4AXREq2kEXbbue8zQtB1FttrL8EMTevaLDV/ W5nbclccQwvr5vbre0oM0MRImEENoHJD8sIo729n4xWrO2WUQnbrq2r4yoaSv7vPzK/x oaBcwX12dJKSIyz2e3uFBkojBl9bdIklncYjDqxrRCPXiL+SDuTLTeHWBzdtsAL2+OVL eIMMHg93c2TogPnpvRolA4J3aIBnwEIxYkB5UvxWgwE6kc7cidDAzUNbvZ40FKuyn2Fg nPdg== X-Gm-Message-State: AFeK/H0q37rCyt5wVixQkdJ0GV3te/lt3fIgRwd+Ru+T331gP6nJXc10ATFuur3niJrBYw== X-Received: by 10.99.44.209 with SMTP id s200mr4963054pgs.103.1490019167145; Mon, 20 Mar 2017 07:12:47 -0700 (PDT) Original-Received: from calancha-pc (161.224.128.101.dy.bbexcite.jp. [101.128.224.161]) by smtp.gmail.com with ESMTPSA id t6sm33969249pgo.42.2017.03.20.07.12.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 07:12:46 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87fui89hf7.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213183 Archived-At: On Mon, 20 Mar 2017, Ted Zlatanov wrote: > On Mon, 20 Mar 2017 09:51:07 -0400 Stefan Monnier wrote: > > SM> Either use `some` instead of `cl-some`, or use `cl-lib` (and add > SM> a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's > SM> header). > > BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":" > afterwards. > > SM> Stefan "who favors the `cl-lib` solution" > > Like this? I'll commit if you agree. > > Thanks for the help > Ted > > diff --git a/packages/load-dir/load-dir.el b/packages/load-dir/load-dir.el > index ab88ea7..b2231a5 100644 > --- a/packages/load-dir/load-dir.el > +++ b/packages/load-dir/load-dir.el > @@ -9,6 +9,7 @@ > ;; Maintainer: Teodor Zlatanov > ;; Version: 0.0.5 > ;; Keywords: lisp, files, convenience > +;; Package-Requires: ((cl-lib "0.5")) > > ;; This file is part of GNU Emacs. > > @@ -43,7 +44,7 @@ > > ;;; Code: > > -(eval-when-compile (require 'cl-extra)) > +(eval-when-compile (require 'cl-lib)) ^^^^^^^^^^^^^^^^^^ Just plain `require' because `cl-some' is a defun not a macro: (require 'cl-lib)