From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [patch] Run occur command restricted to a region Date: Mon, 30 Jan 2017 13:27:41 +0900 (JST) Message-ID: References: <87vau3jl6f.fsf@gmail.com> <87shp6uwvj.fsf@mail.linkov.net> <83h95lua2f.fsf@gnu.org> <878tqxm1wh.fsf@mail.linkov.net> <87r34ozq20.fsf@gmail.com> <87inq0xhiw.fsf@mail.linkov.net> <87d1g55h8d.fsf@mail.linkov.net> <87r33ywquz.fsf@mail.linkov.net> <87ziilc05e.fsf@gmail.com> <8760l9wcci.fsf@mail.linkov.net> <87fukb2xmk.fsf@gmail.com> <87h94qu01u.fsf@mail.linkov.net> <87inp6nsdf.fsf@gmail.com> <87lgtu4w5c.fsf@mail.linkov.net> <878tpt1m4b.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1068127251-1485750464=:1861" X-Trace: blaine.gmane.org 1485750510 2240 195.159.176.226 (30 Jan 2017 04:28:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Jan 2017 04:28:30 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 30 05:28:26 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cY3Zp-0000RZ-Jr for ged-emacs-devel@m.gmane.org; Mon, 30 Jan 2017 05:28:25 +0100 Original-Received: from localhost ([::1]:57851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cY3Zu-0007g2-U1 for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 23:28:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cY3ZG-0007fk-0h for emacs-devel@gnu.org; Sun, 29 Jan 2017 23:27:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cY3ZC-0002ft-SG for emacs-devel@gnu.org; Sun, 29 Jan 2017 23:27:49 -0500 Original-Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:33937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cY3ZC-0002fO-M7 for emacs-devel@gnu.org; Sun, 29 Jan 2017 23:27:46 -0500 Original-Received: by mail-pf0-x229.google.com with SMTP id e4so86953829pfg.1 for ; Sun, 29 Jan 2017 20:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=nX3Lpp56j4IoX/ZC0IkQGAmMmpl1HBPrM0Vgl7lJZco=; b=rSlOZth7CRWrN41R/IPMQqbN4WaiiU5Mzwx2mpYq2FBsnxvyo288k0LTxBJVMxrnQm 8srlO0K3cGSfxJEV6BmogO2VyWDV8tNAftfMOflciXmRAJaP4nfcLEtkPHJJ05Ab7vBN ATUES/efEilr2qHU1bS7ALHZ3TlBjE4z78WYMJ+DV87EGX6l+rjO/lAmYqifw8LD3dO1 8tscGq7LfC1mzB+9ihrUBvErUooW1w8ljLnNGULn8y2d6AibvlQ7ac+kcKAVvsn5dSdz TErYF8KsO5Tb1HGyrJZwQIKSEXDJPk0YsEAQpCmbpT2Ia0xQ2Mko4I6/jhxn0m7mGeQQ U2Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=nX3Lpp56j4IoX/ZC0IkQGAmMmpl1HBPrM0Vgl7lJZco=; b=mux3K6juJeEFySKN00mR+tD8KV6fwCwWmPk1G1zRa1t5w115c3kNgGOeJE8miIF1Dl +OzTHpdljDdUmz9j7BTmVWMz6CCJ2f9Pxm/hZ3jxsgjzJqpu3P+nw3hgDgHqc2en6djX TEzCtG2N3xw2S/aMPoAzyqvDrZXZcCkjmLStZ1pzjXohM3/JIijqeiGiNyutvrB8fPFL R7+vNbge4qAsAO+/O398J1zoGQplgynkaFzpVcx1qO57v4i+Uzm5aGSziANnWgU5ueRR VFK62Ikx6xXTId0ddhF8Yv/zAffwYTIHgZMqzUFtl8xD0ZniyL8drfYVA4plmJBACHFD CNfQ== X-Gm-Message-State: AIkVDXIOsz0G8Go5GMu0sfbPH35BVOkU0H21z5nN4ZZ8Vpk3MGT1FL/FoB8P5Ks30xw+Aw== X-Received: by 10.99.55.91 with SMTP id g27mr22188897pgn.65.1485750465629; Sun, 29 Jan 2017 20:27:45 -0800 (PST) Original-Received: from calancha-pc (33.94.100.220.dy.bbexcite.jp. [220.100.94.33]) by smtp.gmail.com with ESMTPSA id 66sm27806797pfx.29.2017.01.29.20.27.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jan 2017 20:27:44 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <878tpt1m4b.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211751 Archived-At: --8323329-1068127251-1485750464=:1861 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 30 Jan 2017, Juri Linkov wrote: >>>> +Optional arg REGION, if non-nil, mean restrict search to the >>>> +specified region. Otherwise search the entire buffer. >>>> +When REGION is non-nil, it must be a cons (START . END). >>> >>> When someone decides to add support for rectangular regions in occur later, >>> your current implementation will make this problematic since it changes >>> the format ((START . END)) to (START . END), that makes difficult to support >>> ((START1 . END1) (START2 . END2) ...) later. >>> >>> Let's stick to the same format in all uses of the new ‘REGION’ arg, and >>> currently in occur support only the degenerate case of ((START . END)) >>> for non-rectangular regions. >> >> Thanks. I was also a bit worry with that detail. >> OK, i keep the general format ((START . END)). >> Let me know if the following patch is OK to be pushed: > > Looks good to me, but you have to ask Eli for the permission to push. OK, I will ask. Thank you very much for your help implementing this. --8323329-1068127251-1485750464=:1861--