From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: RE: [patch] Run occur command restricted to a region Date: Fri, 30 Dec 2016 11:57:06 +0900 (JST) Message-ID: References: <87vau3jl6f.fsf@gmail.com> <8337h6vhr7.fsf@gnu.org> <87shp665hf.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1483066648 17247 195.159.176.226 (30 Dec 2016 02:57:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2016 02:57:28 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: kaushal.modi@gmail.com, juri@linkov.net, Eli Zaretskii , Emacs developers , Tino Calancha To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 30 03:57:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMnNg-0003PV-4I for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2016 03:57:20 +0100 Original-Received: from localhost ([::1]:38152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMnNl-00085v-1x for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 21:57:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMnNc-00085p-5x for emacs-devel@gnu.org; Thu, 29 Dec 2016 21:57:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMnNb-0004Cr-HI for emacs-devel@gnu.org; Thu, 29 Dec 2016 21:57:16 -0500 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:33541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMnNW-00045U-Tg; Thu, 29 Dec 2016 21:57:11 -0500 Original-Received: by mail-pg0-x243.google.com with SMTP id g1so20642659pgn.0; Thu, 29 Dec 2016 18:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=LyGRrCmJ3tXCZVpUR6AulQdIJznc4b+APp2Iqy/Q7Ic=; b=iN/RcU+r+TWLLo1qaFTZuGvU8cAUc9hMaRnNDXEkW15DZUvBatUf0TyryIFi0dU0Cx xCoCjNym2oybJX9Lr4HCRnNs56fKEIeLlK4obeBoLx4JjNHywLVRF5zsR4U9odV85lpW mANC8gEvd+0N0HPTCAm1ic8bRv6IjBJKh0hr0h/Gfara6KDawdEzqBWbGTiZEvU9OS7M oOST3rMEfpgrWvfXV39KK1PWcRqUEZxb62AevHHJVteJ18qh8cvVHaVc7lEip6blTJQ5 /VoiYXz+HGkYubih82tELrEI44hqZRqigM/wjGFZ1b6ZkAirfQ2XlJeYov0Ljybyv9qc D3sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=LyGRrCmJ3tXCZVpUR6AulQdIJznc4b+APp2Iqy/Q7Ic=; b=ikfDLyJL/o+tJnVjI8Crd/bqccDzIcgZKanP2CVgWGlIlpfMJO4wcj5ksEhabsKlVU GDyRrumVc7O2+aU7Mj6aD3+BlozgCAmjWq8H74ZwtHOJmh3Hu9LAZmRIR2jcUK8qsrd4 /hIjlOMCcEErDRGkbVnuRUWwr1GZQsxjvcZeRA7rmGqlpTuwLscORxPkHEwSyp9Q7rGG ddJeoUJFgnDzaibYUu6pcTS6yRRGH5B7RapQr58qFX7LqG6QCSv3s2IQe+PExVZxz1xS mw/CtoTA5qKeiGXngvEdYHmqCHJZX3l+mEhWXkk9JWKT4GXXU0EreBp+B+mBYn5Rd8Xr s2zA== X-Gm-Message-State: AIkVDXImDyg3C5M5elYkFGwXFFRER0MGrOhT2p1g55GRJlvOwVrhVsEK8EsjMNUFjpT8tQ== X-Received: by 10.98.92.133 with SMTP id q127mr41343720pfb.152.1483066629873; Thu, 29 Dec 2016 18:57:09 -0800 (PST) Original-Received: from calancha-pc (217.225.128.101.dy.bbexcite.jp. [101.128.225.217]) by smtp.gmail.com with ESMTPSA id u3sm107893503pfk.3.2016.12.29.18.57.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2016 18:57:09 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210984 Archived-At: On Thu, 29 Dec 2016, Drew Adams wrote: >> (define-key search-map "o" 'occur) >> +(define-key search-map "b" 'occur-backward) >> +(define-key search-map "f" 'occur-forward) > > FWIW, I don't think those keys (`M-s b' and `M-s f') should be > bound to those commands. If we want to bind the new commands > during Isearch then I suggest that the occur commands be grouped > on prefix key `M-s o': > > M-s oo occur > M-s ob occur-backward > M-s of occur-backward > > `M-s' is a _general_ search prefix key. There is nothing > particularly mnemonic about `b' or `f' being `occur-backward' > or `occur-forward'. And we should not sacrifice 3 `M-s' keys > to these commands. > > I, and perhaps other users, and perhaps in the future vanilla > Emacs, have other bindings on `M-s'. And `M-s' bindings can > be anything at all related to the encompassing context of > searching. I agree with you that my suggested keybindings are not a good choice. To me, grouping related commands under a common prefix sounds like a good idea. I am also OK with not providing keybindings to these new commands at all.