[Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Tino Calancha]

[Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

FWIW, i oppose to such kind of changes.  I was aware of that comment:
it's of historical interest and it's fun!
Indeed, it was because that comment that i wanted to study that function.

@@ -1440,9 +1417,6 @@ dired-x--string-to-number
            (setq val (* 1024.0 val)))))
      val))

-;; Does anyone use this? - lrd 6/29/93.
-;; Apparently people do use it. - lrd 12/22/97.
-
  (defun dired-mark-sexp (predicate &optional unflag-p)
    "Mark files for which PREDICATE returns non-nil.
  With a prefix arg, unmark or unflag those files instead.

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[John Wiegley]

>>>>> "TC" == Tino Calancha <calancha@gmail.com> writes:

TC> [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code
TC> from dired-x.el

TC> FWIW, i oppose to such kind of changes. I was aware of that comment: it's
TC> of historical interest and it's fun! Indeed, it was because that comment
TC> that i wanted to study that function.

It's arguably a part of our history by now, but has no real value either.  If
you want to push a revert, that's fine.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Tino Calancha]

On Fri, 2 Dec 2016, John Wiegley wrote:

>>>>>> "TC" == Tino Calancha <calancha@gmail.com> writes:
>
> TC> [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code
> TC> from dired-x.el
>
> TC> FWIW, i oppose to such kind of changes. I was aware of that comment: it's
> TC> of historical interest and it's fun! Indeed, it was because that comment
> TC> that i wanted to study that function.
>
> It's arguably a part of our history by now, but has no real value either.  If
> you want to push a revert, that's fine.
Thank you very much.
For me it's enough to state my disagrement.
I would prefer to not revert other people commit, if that doesn't fix a bug.

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 3 Dec 2016 10:12:09 +0900 (JST)
> Cc: Tino Calancha <tino.calancha@gmail.com>
> 
> [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el
> 
> FWIW, i oppose to such kind of changes.  I was aware of that comment:
> it's of historical interest and it's fun!
> Indeed, it was because that comment that i wanted to study that function.

I questioned the need for these changes when Reuben first presented
them.  No one supported me, so I decided I was the odd one out.
Please in the future raise your voices in such situations.

TIA

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Tino Calancha]

On Sat, 3 Dec 2016, Eli Zaretskii wrote:

>> From: Tino Calancha <tino.calancha@gmail.com>
>> Date: Sat, 3 Dec 2016 10:12:09 +0900 (JST)
>> Cc: Tino Calancha <tino.calancha@gmail.com>
>>
>> [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el
>>
>> FWIW, i oppose to such kind of changes.  I was aware of that comment:
>> it's of historical interest and it's fun!
>> Indeed, it was because that comment that i wanted to study that function.
>
> I questioned the need for these changes when Reuben first presented
> them.  No one supported me, so I decided I was the odd one out.
> Please in the future raise your voices in such situations.
Glad to be in agreement with you Eli.
I don't see in 9effa4b reference to any bug number.  I don't know where 
this patch was discused.  Tipically i like to read everything about
Dired.  Maybe it was sent to this list with one subject that didn't catch
my eye (just guessing).

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Eli Zaretskii]

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Mon, 5 Dec 2016 21:33:49 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, emacs-devel@gnu.org
> 
> > I questioned the need for these changes when Reuben first presented
> > them.  No one supported me, so I decided I was the odd one out.
> > Please in the future raise your voices in such situations.
> Glad to be in agreement with you Eli.
> I don't see in 9effa4b reference to any bug number.  I don't know where 
> this patch was discused.  Tipically i like to read everything about
> Dired.  Maybe it was sent to this list with one subject that didn't catch
> my eye (just guessing).

This was discussed as part of bug#18716.  My comment on this
particular aspect was here:

  http://lists.gnu.org/archive/html/bug-gnu-emacs/2016-11/msg00328.html

Admittedly, the Subject of that message leaves a lot to be desired ;-)
So if you only read message that catch your attention due to their
Subject, I understand now how you could miss that one.  (I simply read
all of the messages posted to bug-gnu-emacs.)

Reuben, could you please in the future keep the original Subject line
assigned by the bug tracker?

Thanks.

Re: [Emacs-diffs] master 9effa4b: Remove obsolete comments and commented code from dired-x.el

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

On Dec 5, 2016 4:07 PM, "Eli Zaretskii" <eliz@gnu.org> wrote:
>
> > From: Tino Calancha <tino.calancha@gmail.com>
> > Date: Mon, 5 Dec 2016 21:33:49 +0900 (JST)
> > cc: Tino Calancha <tino.calancha@gmail.com>, emacs-devel@gnu.org
> >
> > > I questioned the need for these changes when Reuben first presented
> > > them.  No one supported me, so I decided I was the odd one out.
> > > Please in the future raise your voices in such situations.
> > Glad to be in agreement with you Eli.
> > I don't see in 9effa4b reference to any bug number.  I don't know where
> > this patch was discused.  Tipically i like to read everything about
> > Dired.  Maybe it was sent to this list with one subject that didn't
catch
> > my eye (just guessing).
>
> This was discussed as part of bug#18716.  My comment on this
> particular aspect was here:
>
>   http://lists.gnu.org/archive/html/bug-gnu-emacs/2016-11/msg00328.html
>
> Admittedly, the Subject of that message leaves a lot to be desired ;-)
> So if you only read message that catch your attention due to their
> Subject, I understand now how you could miss that one.  (I simply read
> all of the messages posted to bug-gnu-emacs.)
>
> Reuben, could you please in the future keep the original Subject line
> assigned by the bug tracker?
>
> Thanks.

Apologies, I will (try to) do in future.

[-- Attachment #2: Type: text/html, Size: 1940 bytes --]