From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Proposal: font lock for `describe-variable` Date: Mon, 3 Oct 2016 22:57:21 +0900 (JST) Message-ID: References: <1474949378.32234.5.camel@gmail.com> <83shslbax3.fsf@gnu.org> <83ponpb5rv.fsf@gnu.org> <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1475503079 32527 195.159.176.226 (3 Oct 2016 13:57:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 13:57:59 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Eli Zaretskii , Emacs developers , =?ISO-8859-15?Q?Cl=E9ment_Pit--Claudel?= , monnier@iro.umontreal.ca To: Tianxiang Xiong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 03 15:57:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1br3kY-0006xE-F1 for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 15:57:46 +0200 Original-Received: from localhost ([::1]:37283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br3kW-0001of-UF for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 09:57:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br3kM-0001ma-5r for emacs-devel@gnu.org; Mon, 03 Oct 2016 09:57:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1br3kK-00067r-Al for emacs-devel@gnu.org; Mon, 03 Oct 2016 09:57:33 -0400 Original-Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:35077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br3kE-00066e-BS; Mon, 03 Oct 2016 09:57:26 -0400 Original-Received: by mail-pa0-x242.google.com with SMTP id t6so4982486pae.2; Mon, 03 Oct 2016 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=kQQ4/BXO3/rHljP6oETDKmJHoOIgUddVHCw+1kMqaEg=; b=wCn0bKxB8P2M301BrnM98WN0Hc9v9cwnUVTlT/EPwpQgoZoeB4cHYZBVhwT7nvpiOz u0Hr7XUJiptjQVfj+GsG+EsA5eVx+diEkb1f1MT1xcJI0yZoXPl68COPCrYqYxQKid3S wyjq/y29tmO3jzj0Q8QdMIOlpHhetokp0tmT1jSQuziv98OJUV27gna4XU/66xAnHZ9o NVQmCT5gyh1kY3KkpVmcvDk5WL/vUoPjJrtlLFPzSli8o4VCUNgxEAAyW7DKdLm0fdBz CY62Lgs4bhLmo6eUTNbbZlFtvHeWPICTHBftq9qkiwsvCbZvbfNjgY6fWlv/eJfoOWMQ dVkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=kQQ4/BXO3/rHljP6oETDKmJHoOIgUddVHCw+1kMqaEg=; b=mdfrtxpaHwxrvVMm2hhacMBIghysZMtimOTeWv0et6OR+OjV+otwRckW7H66dK3B6T f5FFK4E2T7e7E83OysLpJ2LX1FXGURTeaF9KaQxtti5zR0V8ouY1H+bePuRrI799/IEH uSUQsDDbWskomhQZ2Q79t21DRgPEKAnFmq8caosKCmBGGSMYTII+poLOTB2QviIZ91W3 +gRd9lMniHzX4uJlscxKYsbeabzkDaRTH0sV8PzN8tQhfTCzNlXIadzqKRKsQlmY2iyn cbar4g/WYNNxWcXsghm3kpE6ZS/jW3TRhY2I1zGRAGpd4rtGhTo+9vh5wI+x15f4KYuQ 00FA== X-Gm-Message-State: AA6/9Rnkz/XohEufGn/0bQfZcGh77dkXzNOPUB+4U8GK2iqxU97OB+NMVNbmAquyK0fLBA== X-Received: by 10.67.3.102 with SMTP id bv6mr38564267pad.61.1475503045491; Mon, 03 Oct 2016 06:57:25 -0700 (PDT) Original-Received: from calancha-pc ([103.5.140.155]) by smtp.gmail.com with ESMTPSA id 137sm11623319pfv.26.2016.10.03.06.57.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 06:57:24 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207963 Archived-At: On Fri, 30 Sep 2016, Tianxiang Xiong wrote: > OK, I'll try to remove the whitespace changes. Hi Tianxiang, i have three suggestions: I) i see your patch modified two functions: `describe-variable-custom-version-info' `describe-variable' maybe, in addition to the patch, you can provide the log message of the commit in Emacs format, i mean: * lisp/help-fns.el (describe-variable-custom-version-info): blah, blah. (describe-variable): blah, blah. that could make much clear what is the rationale of your changes. II) I suggest to exclude from the patch the changes princ --> insert i guess the use of `princ' is intentional, in order to redirect the standard output using: (with-current-buffer standard-output If you like, you might provide a patch made of two commits: the first one without any princ --> insert changes, and then, add a commit on top of the previous one providing these (princ ---> insert) changes. III) Do not drop embedded new lines as in: (format "This variable was introduced, or its default value was changed, in\nversion %s of Emacs.\n" or in: (format (concat "This variable was introduced, or its default value was changed, in\nversion %s of the %s package" Those newlines prevent to having lines longer than 80 lines. They are important. Regards, Tino