From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Dired: Improve symmetry in mark/unmark commands bound to keys Date: Mon, 3 Oct 2016 20:15:00 +0900 (JST) Message-ID: References: <877fa12iyq.fsf@linux-m68k.org> <83h995ay04.fsf@gnu.org> <87y42h13pi.fsf@linux-m68k.org> <83fuopax4g.fsf@gnu.org> <87twd512pk.fsf@linux-m68k.org> <83bmzacwmk.fsf@gnu.org> <83fuodpxl1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-84393146-1475493305=:18141" X-Trace: blaine.gmane.org 1475493332 23949 195.159.176.226 (3 Oct 2016 11:15:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 11:15:32 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 03 13:15:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1br1DR-0005G5-7Z for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 13:15:25 +0200 Original-Received: from localhost ([::1]:36201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br1DP-0000dO-Mb for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 07:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br1DG-0000cF-FG for emacs-devel@gnu.org; Mon, 03 Oct 2016 07:15:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1br1DE-0003wr-0C for emacs-devel@gnu.org; Mon, 03 Oct 2016 07:15:13 -0400 Original-Received: from mail-pf0-x22f.google.com ([2607:f8b0:400e:c00::22f]:34832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br1D8-0003oA-ML; Mon, 03 Oct 2016 07:15:06 -0400 Original-Received: by mail-pf0-x22f.google.com with SMTP id s13so62974643pfd.2; Mon, 03 Oct 2016 04:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ytevnYzV67VRXS+65aEsIuxYLHcdTbBpyk8k29plMPc=; b=nM6PbobsPFLSNibc05VlyoV2dnncBSFioRGGGerDES62uy/+EKhBsUVF9YtH7+8kNu Vb7LFK91cvwZOY740xBsMI/arxqjgjIKbN+nN9RYEC3dlPdSARv+70qCOn5j7pOFT2s3 4BIhVYRE6850aZHiInIFenKZZvADxlvyyZy9G9lKyVyA849dgz/wGwWq01cY6yzKuTJi h3FztTmXW1TjCOWIR/tDwuxgOl5MZzo/SeX4dAjahuqqV65CCaw5lR4ptbGbAMng7EZZ 27x6Gw0qFEtqP2XcLQao2BQHhTecJQRgXbRW0fN79uwy7rBTgMaVEjKiMTsDsINpyVXc k+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ytevnYzV67VRXS+65aEsIuxYLHcdTbBpyk8k29plMPc=; b=R2139avZU6yzN+0dxsyOQDA6ibl1Kcs11/a2sBrUnI1M9/mge7OdZkIv5kRJFcNi8c jBNG0cBA0yyIskeEGrgzaJmoTkGQbUpWJ3dXI104+8EES0kj0a2R2mzln/t+WgnqVCy3 LSRaTSfMr2//aFI7zHjoq5mmzAEEDMzTgNsRctLaYRXPen6XIArF/gR8nZi28dMxbaYS opOm2s4L9f+MCT9aMpARPP8u0z3dwNjTBfFVcwf8ZXDtBxOoDmWt6xFFWisWHm1uIGHH 52V+4ORqy2VzGz/gfd0kxdSQI6vKFxOfUc6kYbr8FCwRFvkMGO2+8xLUJGxAtauk7TdW KSQg== X-Gm-Message-State: AA6/9RmaericZviWi8BLabL11NtFyz6O59QtAAlgHMylnbcA2/UDZwF3f1iNBNFwp+jzRQ== X-Received: by 10.98.65.204 with SMTP id g73mr36906730pfd.164.1475493305937; Mon, 03 Oct 2016 04:15:05 -0700 (PDT) Original-Received: from calancha-pc ([103.5.140.168]) by smtp.gmail.com with ESMTPSA id h123sm46549168pfe.87.2016.10.03.04.15.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 04:15:05 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83fuodpxl1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207957 Archived-At: --8323329-84393146-1475493305=:18141 Content-Type: text/plain; charset=iso-8859-7; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 3 Oct 2016, Eli Zaretskii wrote: > Thanks, I have a couple of minor comments below. > >> * doc/misc/dired-x.texi: Update documentation for 'dired-mark-extension'. > > This part of the log entry should state in parentheses the node in > which the change is being made, as if the node were a function. > >> is not automatically prepended to the string entered, you must type it >> -explicitly. If invoked with a prefix argument, this command asks for >> -a character to use as the marker. >> +explicitly. >> +If invoked with prefix argument @kbd{C-u}, this command unmark files instead. >> +Calling it with the @kbd{C-u C-u} prefix, asks for a character to use > ^^^^^^^^^^ > "If called" sounds better and more correct English-wise. > >> +as the marker, and mark files with it. > ^^^^ > "marks" > >> +Prefixed with two C-u¢s, prompt for MARKER-CHAR and mark files with it." > ^ > Please use the ASCII apostrophe character ' here, not ¢, so that the > user could control the result via text-quoting-style. > > With the above gotchas fixed, this is okay for the master branch. Thank you. Pushed a corrected patch with your comments to master branch as commit 3b6eb948 --8323329-84393146-1475493305=:18141--