From: Tino Calancha <tino.calancha@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: larsi@gnus.org, Emacs developers <emacs-devel@gnu.org>,
Tino Calancha <tino.calancha@gmail.com>
Subject: Re: debbugs-0.10: doc fixes
Date: Fri, 23 Sep 2016 16:42:26 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609231639120.6183@calancha-pc> (raw)
In-Reply-To: <8760q0dmxh.fsf@gmx.de>
On Tue, 13 Sep 2016, Michael Albinus wrote:
> I've pushed this to the elpa repository, you might play with it. Within
> a week or so, I will release debbugs 0.11.
Hi Michal,
it looks good. Thank you.
I have few suggestions to make the doc strings more clear. See below.
From 6d3d28162e0b3e956a531dd60380243cc5dfd481 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Fri, 23 Sep 2016 16:37:01 +0900
Subject: [PATCH] debbugs-gnu.el: Doc fixes
* packages/debbugs/debbugs-gnu.el (debbugs-gnu-expand-bug-number-list):
Fix typo in doc string.
(debbugs-gnu-default-bug-number-list): Explain the meaning of a
value like '-N'.
(debbugs-gnu-bugs): Clarify in doc string the input format
for interactive calls.
Show default value in the prompt, i.e.,
'debbugs-gnu-default-bug-number-list'.
---
packages/debbugs/debbugs-gnu.el | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/packages/debbugs/debbugs-gnu.el
b/packages/debbugs/debbugs-gnu.el
index 4a69f2b..f8b8726 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -1421,7 +1421,7 @@ MERGED is the list of bugs merged with this one."
"Dynamic completion table for reading bug numbers.")
(defun debbugs-gnu-expand-bug-number-list (bug-number-list)
- "Expand BUG-NUMBER-LIST to a list of singe bug numbers.
+ "Expand BUG-NUMBER-LIST to a list of single bug numbers.
BUG-NUMBER-LIST is a list of bug numbers or bug number ranges, as
returned by `debbugs-gnu-bugs'."
(let (result)
@@ -1659,20 +1659,25 @@ The following commands are available:
(defcustom debbugs-gnu-default-bug-number-list "-10"
"The default value used in interactive call of `debbugs-gnu-bugs'.
-It must be a string, containing a comma separated list of bugs or bug
ranges."
+It must be a string, containing a comma separated list of bugs or bug
ranges.
+A negative value, -N, means the newest N bugs."
:group 'debbugs-gnu
:type 'string
:version "25.2")
;;;###autoload
(defun debbugs-gnu-bugs (&rest bugs)
- "List all BUGS, a list of bug numbers."
+ "List all BUGS, a list of bug numbers.
+In interactive calls, prompt for a comma separated list of bugs
+or bug ranges, with default to `debbugs-gnu-default-bug-number-list'."
(interactive
(mapcar
'string-to-number
(debbugs-gnu-expand-bug-number-list
(or
- (completing-read-multiple "Bug numbers: "
debbugs-gnu-completion-table)
+ (completing-read-multiple
+ (format "Bug numbers (%s): " debbugs-gnu-default-bug-number-list)
+ debbugs-gnu-completion-table)
(split-string debbugs-gnu-default-bug-number-list "," t)))))
(dolist (elt bugs)
(unless (natnump elt) (signal 'wrong-type-argument (list 'natnump
elt))))
--
2.9.3
Repository revision: 1c1ee85d183daee1d409413226ec739f35499918
next prev parent reply other threads:[~2016-09-23 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 6:08 debbugs-0.10: two comments Tino Calancha
2016-09-12 7:05 ` Michael Albinus
2016-09-12 7:24 ` Tino Calancha
2016-09-12 7:32 ` Michael Albinus
2016-09-12 7:46 ` Tino Calancha
2016-09-13 12:06 ` Michael Albinus
2016-09-23 7:42 ` Tino Calancha [this message]
2016-09-23 12:40 ` debbugs-0.10: doc fixes Michael Albinus
2016-09-23 13:14 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609231639120.6183@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).