unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Standard check before creating large num of frames
@ 2016-09-15  6:26 Tino Calancha
  2016-09-15 12:00 ` Stefan Monnier
  2016-09-15 14:58 ` Eli Zaretskii
  0 siblings, 2 replies; 4+ messages in thread
From: Tino Calancha @ 2016-09-15  6:26 UTC (permalink / raw)
  To: Emacs developers; +Cc: tino.calancha


Dear all,

several functions might create new frames.  In particular when
`pop-up-frames' is non-nil, `display-buffer' creates a new frame.
Creating a lot of new frames might be expensive.

Some functions may ask for user confirmation before creating an
many frames.
For instance, see `ibuffer-do-view-1': this function ask for confirmation
before creating > 3 frames.
IMO, it's good if each function creating a large number of frames
do a similar check.
We might add a new option, for instance 'max-number-of-frames'
or 'frame-max-number':

(defcustom max-number-of-frames 3
   "Maximum number of frames to create before asking user confirmation."
     :version "25.2"
     :type 'integer
     :group 'convenience)

We might want to standarize the check as well:
(defun frame-create-many-frames-p (nframes &optional prompt)
   "Return non-nil if it's OK to create NFRAMES.
If NFRAMES + current number of frames is > `max-number-of-frames',
ask for user confirmation.
An optional arg is the prompt to ask the user."
   (let* ((tot (+ nframes (length (frame-list))))
          (str (or prompt (format "Really create %s frames? " nframes)))
          (res (or (<= tot max-number-of-frames)
                   (y-or-n-p str))))
     res))

Please, let me know your opinions/suggestions about this proposal.
In case we want to add these things: where should they live?

Regards,
Tino



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-15 15:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15  6:26 Standard check before creating large num of frames Tino Calancha
2016-09-15 12:00 ` Stefan Monnier
2016-09-15 15:33   ` Tino Calancha
2016-09-15 14:58 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).