From: Tino Calancha <tino.calancha@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>,
Tino Calancha <tino.calancha@gmail.com>
Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found
Date: Tue, 13 Sep 2016 04:44:17 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609130439380.28880@calancha-pc> (raw)
In-Reply-To: <ty7fahgdpg.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Mon, 12 Sep 2016, Glenn Morris wrote:
> Tino Calancha wrote:
>
>> "Executable used to create thumbnail.
>> +If nil, `image-dired-create-thumb' signals an error.
>
> I think you could just say:
>
> "Executable used to create thumbnail, or nil if not found."
That part was reverted after a suggestion from Clément in:
https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00144.html
I kept those definitions as the original, i.e., just strings, no call
to `executable-find' there. The check for existing executables is
performed in a new function image-dired--check-executable-exists
which is called on each function using an external program.
> Otherwise, LGTM, thanks.
Thank you very much.
Pushed to master as commit 5d7433ab
prev parent reply other threads:[~2016-09-12 19:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160904134431.30494.94659@vcs.savannah.gnu.org>
[not found] ` <20160904134431.7513F220140@vcs.savannah.gnu.org>
2016-09-04 16:41 ` master ca47390: image-dired: Report when a necessary executable is not found Glenn Morris
2016-09-05 3:42 ` Tino Calancha
2016-09-05 4:42 ` Clément Pit--Claudel
2016-09-05 5:30 ` Tino Calancha
2016-09-05 6:41 ` Andreas Schwab
2016-09-05 7:12 ` Tino Calancha
2016-09-05 15:48 ` Clément Pit--Claudel
2016-09-05 18:00 ` Tino Calancha
2016-09-12 18:44 ` Glenn Morris
2016-09-12 19:44 ` Tino Calancha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609130439380.28880@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).