From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: jpff Newsgroups: gmane.emacs.devel Subject: Re: libpng issues Date: Mon, 12 Feb 2018 11:37:53 +0000 (GMT) Message-ID: References: <20180210.204659.327614606750579213.wl@gnu.org> <43b7cd24-568b-a912-7e6b-be910b2bb99c@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="279718404-828654979-1518435503=:3546" X-Trace: blaine.gmane.org 1518435457 17136 195.159.176.226 (12 Feb 2018 11:37:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 11:37:37 +0000 (UTC) User-Agent: Alpine 2.11 (DEB 23 2013-08-11) Cc: Paul Eggert , emacs-devel To: =?ISO-8859-15?Q?Elias_M=E5rtenson?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 12 12:37:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elCQM-00043x-U4 for ged-emacs-devel@m.gmane.org; Mon, 12 Feb 2018 12:37:31 +0100 Original-Received: from localhost ([::1]:46742 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elCSO-0005PJ-LU for ged-emacs-devel@m.gmane.org; Mon, 12 Feb 2018 06:39:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elCRt-000565-07 for emacs-devel@gnu.org; Mon, 12 Feb 2018 06:39:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elCRq-0007Ql-BT for emacs-devel@gnu.org; Mon, 12 Feb 2018 06:39:04 -0500 Original-Received: from west.codemist.co.uk ([217.155.197.248]:55533 helo=codemist.co.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elCRq-0006XF-2W for emacs-devel@gnu.org; Mon, 12 Feb 2018 06:39:02 -0500 Original-Received: from [172.16.4.42] (helo=snout.codemist.co.uk) by codemist.co.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1elCRD-0000vZ-7p; Mon, 12 Feb 2018 11:38:23 +0000 In-Reply-To: X-ACL-Warn: No reverse lookup X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 217.155.197.248 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222685 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --279718404-828654979-1518435503=:3546 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT I have the same problem on OpenSuSRE 42.3 /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: image.o: undefined reference to symbol 'png_set_sig_bytes@@PNG16_0' /usr/lib64/libpng16.so.16: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status Makefile:606: recipe for target 'temacs' failed make[1]: *** [temacs] Error 1 On Mon, 12 Feb 2018, Elias Mårtenson wrote: > Hello Paul, > Your fix for this (e9ca57cfcbaf1a8dfc6bde5a2afd5f3c7b357cb1) causes the build > to fail on Arch Linux. > Rolling back that change makes the build work again. > > Here's the error: > > make[2]: Leaving directory '/home/emartenson/src/emacs/admin/charsets' > make -C ../admin/unidata charscript.el > make[2]: Entering directory '/home/emartenson/src/emacs/admin/unidata' > make[2]: Nothing to be done for 'charscript.el'. > make[2]: Leaving directory '/home/emartenson/src/emacs/admin/unidata' >   CCLD     temacs > /bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0' > /usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line > collect2: error: ld returned 1 exit status > make[1]: *** [Makefile:606: temacs] Error 1 > make[1]: Leaving directory '/home/emartenson/src/emacs/src' > make: *** [Makefile:418: src] Error 2 > > Regards, > Elias > > > On 12 February 2018 at 10:45, Paul Eggert wrote: > Werner LEMBERG wrote: > > I've just been bitten by > >    https://github.com/glennrp/libpng/issues/206 > > For this reason I suggest two improvements for the > configure script of > emacs. > > (1) Use `pkg-config' before `libpng-config' to detect > libpng. > > (2) If `libpng-config' is used, filter out > `-L/usr/lib' and >      `-L/usr/lib64' (as suggested in issue #206). > > > Thanks, I installed the attached into master. It does (1), and as > I understand it when (1) works then (2) is unnecessary. I'm hoping > we don't have to do (2) as I worry that it might break things on > some platforms. > > > > --279718404-828654979-1518435503=:3546--