From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Radetsky Newsgroups: gmane.emacs.devel Subject: Re: CVE-2024-53920 Emacs arbitrary code execution via unsafe macro-expansion Date: Wed, 27 Nov 2024 01:46:24 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Stefan Monnier , Stefan Kangas , Andrea Corallo , Eli Zaretskii To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 27 10:47:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGEdk-0005iE-0p for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Nov 2024 10:47:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGEd0-0000oG-CA; Wed, 27 Nov 2024 04:46:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGEcy-0000mi-Bn for emacs-devel@gnu.org; Wed, 27 Nov 2024 04:46:32 -0500 Original-Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGEcw-0007lh-RC; Wed, 27 Nov 2024 04:46:32 -0500 Original-Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2ea6f821decso5577376a91.1; Wed, 27 Nov 2024 01:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732700787; x=1733305587; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b7PhnkBPrcbX22X3RIbf1ERv1bYgQwsiGFmSDCnOf7U=; b=GCEnoZXLFSh/gdTlzjqElM3x6SEA7IfQkZEm9cwzoA4CuJzS6/SmV9MvAND7kk2t8h 1WO/EiSnO0425fpjR83lgvpu6WiPanRD6qjfuCmEDpnFcjO4ND5vlIz8acjctKZiBc6E JGOy68a4f1edVHJ4yKTKq6+CcoxWNnYVFjfH4CCGsd+qPhFENHli5DreSCBj7auUbfYh yjIMSgnZoUp2JZwSgvDa3XqnWYOdtanjRRHDMVAwl3Nvkqb+ivs/uPj4eI1uHndYSDZ/ ZlVkmEfeoaBLjzo/nNeDfpdYDFAoKKKwYzSUwUacQv5RZZ43AWFhtSSsKXq9D9wGUBsB abcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732700787; x=1733305587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b7PhnkBPrcbX22X3RIbf1ERv1bYgQwsiGFmSDCnOf7U=; b=DD5IPd06S7nCqMKXc5GYY/UYjmx48SisthOa1UK7hd72ZiW9EplkgL7BL90t5ic8zb WsFh2gltFaYGCKlgZxI/CW2UdomYGMgN/kBcnZsGqhLNUOsFYLrfEU4SyMQB0ravNIsO 3xifkHBzEDNia3bNL5NhQsI72VME4VpK1UFSxdPZ1lkowyS8t4oOgmW9ut+ZNiYF2y27 8rCFAhdkmsBbjM4Qb8fvdXbaLam3iiZkqmSL59O7/OmTglxzw3WIj8hHwINBB2vKHOdG SwmsqjmdhMoUISzCTwhKKRRx0/tv8YpaZOrhubPRQ27clPe4eQuMhkYsp0R4AOoL8koU tg6g== X-Forwarded-Encrypted: i=1; AJvYcCWvYoxtrl/ikALwVmT5xIoPLtTD/zvF9b5qM8AQNzz+mK9sc4jWf0KLtZbWf0zyZLR387yyXQ==@gnu.org, AJvYcCXxwKuBiwfFBXYTzj3J0Ig63pYAfjijH9X/aiHaIw1T6w3eZq48x/dKgZkjyMaanyDIbU7gw0ewog==@gnu.org X-Gm-Message-State: AOJu0Yz+p6RtrHjaoYCu84fm14Ym7flBfhRfhAUwneltjI+vCgh3pAy4 CLMSmOXF9SzBgj75QvGTHIb4QPCIJqKVIWrwdZEkoZdQQuc76InP X-Gm-Gg: ASbGnctNHxIQnC6igyT0NzR6KuRNUzaDd6ayR7zVTYddn5QLHZOJdfTuVNAYjsasbxl unVjMsf3JuEu823DZhPwHunKVurEZxfW32ShQPdwVqebGGOR0HlWkJe9A/KfOsf3f8OfEwfyEkB vMdweMBu3a85zdsH4xNpb+AJtZNoir6a6uppZKf1P55Y2DNg4uMUmzr40YPdwui8MO+34/NtlTK fDpd7JH5iwE9j00eqJKkyBYOnh9fSCUrXDt1J4ZMpA= X-Google-Smtp-Source: AGHT+IHTZKM3T9z/PVpmXKLwjT3Zvog8eXdi1BVnMYMlxr+TD1etCb6eJGw8g7ysAcx+mFuf3onorQ== X-Received: by 2002:a17:90b:38cd:b0:2ea:853a:99f7 with SMTP id 98e67ed59e1d1-2ee08e9d4f9mr3037947a91.2.1732700786760; Wed, 27 Nov 2024 01:46:26 -0800 (PST) Original-Received: from flap ([2601:645:8a81:69c0:11a4:3198:90ad:2957]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee0fa483ffsm1065535a91.19.2024.11.27.01.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 01:46:26 -0800 (PST) Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=dradetsky@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325748 Archived-At: On Wed, Nov 27, 2024 at 09:40:30AM +0100, Eshel Yaron wrote: > Thanks for the heads up. I have little experience with Doom, but here > with the default Doom configuration I see that Flycheck is enabled and > the POC works, so maybe it does have something to do with your config? Actually, it probably does. In order to solve an unrelated issue with (IIRC) LSP, I added (remove-hook 'doom-first-buffer-hook #'global-flycheck-mode) and then forgot about it completely (I'm very much a turn-on-checks-when-I-want-them-checked kind of developer). So I could test it, but I think you're probably just correct. --dmr