From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114390: * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros. Date: Thu, 19 Sep 2013 12:06:39 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1379606807 28843 80.91.229.3 (19 Sep 2013 16:06:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 16:06:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 19 18:06:51 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMgkk-0005FV-P2 for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 18:06:50 +0200 Original-Received: from localhost ([::1]:52045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMgkk-0005RA-9u for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 12:06:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMgkg-0005Qy-Ix for emacs-devel@gnu.org; Thu, 19 Sep 2013 12:06:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMgkc-0003go-40 for emacs-devel@gnu.org; Thu, 19 Sep 2013 12:06:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMgkc-0003gj-0R for emacs-devel@gnu.org; Thu, 19 Sep 2013 12:06:42 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VMgkZ-0007j9-TN; Thu, 19 Sep 2013 12:06:40 -0400 X-Spook: Vickie Weaver ASO Dick Cheney lynch UOP AIEWS Area 51 X-Ran: :v{%D]t"w;#OHv6Nb#".z5x!e_$s8+^}~!)Gysqe1@T_!:D":E1EH~/q+SGJ~({g,WwH7Z X-Hue: white X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Thu, 19 Sep 2013 10:06:41 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163472 Archived-At: Stefan Monnier wrote: >> + * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros. > > Why not? Because it didn't work. (defvar foo-var 0) (defmacro foo-mac () '(setq foo-var (1+ foo-var))) (define-obsolete-function-alias 'old-mac #'foo-mac "24.4") (defun foo-fails () (old-mac)) (defun foo-works () (foo-mac)) Compile: foo.el:13:4:Warning: the function `foo-mac' is not known to be defined. Load compiled version: (foo-fails) ; -> (invalid-function old-mac) Also, neither version warns that old-mac is obsolete. I see now that (eval-and-compile (define-obsolete-function-alias 'old-mac #'foo-mac "24.4")) works. So maybe that should happen automatically at top-level.