From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Date: Mon, 28 Jan 2019 08:05:13 -0800 Message-ID: References: <20190128152540.6870.46132@vcs0.savannah.gnu.org> <20190128152541.12A4D20B50@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="166008"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 17:18:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go9bl-000gzO-2o for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 17:18:02 +0100 Original-Received: from localhost ([127.0.0.1]:34416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go9bj-0002VX-Te for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 11:18:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go9Pz-0001nB-Vy for emacs-devel@gnu.org; Mon, 28 Jan 2019 11:05:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go9Px-00042T-W4 for emacs-devel@gnu.org; Mon, 28 Jan 2019 11:05:50 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:54916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1go9PU-0003Tv-V2; Mon, 28 Jan 2019 11:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=UBaFPmNHQL9nHKEqkkUGZcbYoozXOUEZxHHOsP2k46s=; b=rSRnPmg3QQhOixmGJ3ptDKDWVGo80ks5sVpyvraPFMGE7JWGnkNTHfDRUUN9XnG0SvgYSy/68Wfna4UU8rRbVON4wDcdJnR2iwaSLEyEJG0cPt704AY7DE2NZR3VXPwwR/rGPU01nWHNSd1to8ztxG9pHzIGJC0sL97Njjx6SmXh46XlemUU8ZTS/EIOhnRNBtoWR9t5y1CkIZ/LGZwZ9Ob/DGhH/qjlElNGx1VRtJZII1qEPLX3l1oTynZwXvHTIvTy/seIeDIC7FHkjW0kcbx0igL6BIOLWwW/mXa3VDF7NXCUoYD+jK1D+ONgntB8IcH3Xqcl4Gnlx5zvrnLupA==; Original-Received: from [2604:4080:1321:9a00:f455:12b4:e650:5d75] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1go9PT-0006eT-Gp; Mon, 28 Jan 2019 08:05:19 -0800 In-Reply-To: <20190128152541.12A4D20B50@vcs0.savannah.gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232766 Archived-At: On 1/28/19 7:25 AM, Eli Zaretskii wrote: > branch: master > commit cd06d173a602bf0aa8a227ff1626dc70013fe480 > Author: Eli Zaretskii > Commit: Eli Zaretskii > > Fix bug with face-id after restoring from pdump I was going to fix this problem by just turning lface_id_to_name into a normal Lisp vector and using its size as the next face ID. Why use this more complicated approach?