From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Francesc Rocher" Newsgroups: gmane.emacs.devel Subject: Re: Terrible underline Date: Mon, 10 Mar 2008 22:15:41 +0100 Message-ID: References: <85myp9kjy6.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1205183810 11806 80.91.229.12 (10 Mar 2008 21:16:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Mar 2008 21:16:50 +0000 (UTC) Cc: lennart.borgman@gmail.com, emacs-devel@gnu.org To: "David Kastrup" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 10 22:17:18 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JYpMm-0001Li-3u for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2008 22:17:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYpMD-0005VE-CR for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2008 17:16:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JYpLY-00050X-3W for emacs-devel@gnu.org; Mon, 10 Mar 2008 17:15:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JYpLW-0004yz-8J for emacs-devel@gnu.org; Mon, 10 Mar 2008 17:15:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYpLW-0004yu-2m for emacs-devel@gnu.org; Mon, 10 Mar 2008 17:15:46 -0400 Original-Received: from rv-out-0910.google.com ([209.85.198.187]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JYpLU-0007ED-EL for emacs-devel@gnu.org; Mon, 10 Mar 2008 17:15:46 -0400 Original-Received: by rv-out-0910.google.com with SMTP id c27so2161475rvf.6 for ; Mon, 10 Mar 2008 14:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=pZP9WUE0+esxPyF4NykFbaY9hRn++q9E9WWcDO0cUBg=; b=NQdnY0CkCeMQEyDEw0YOiPywwmKjuzTYpilXurtzstvD06F6P8jZgDqefj6Yf4s+Pd8XhltyuMtZZaIr2z7O33Ot+mJtIuXMdYLUrJip+FSgRO0fjRCeO2njT8KVoKwUEEGQ68bkMBLSivbFdi75wUMngjcOdBYJsIeCdGlPZls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=UZNQjRBWIOL1dI5zZi3ykUDJ1PxMxW9uo76LD1prEga9GrUQIlxGVrWxrknt5s8GbIbpDozwdKLwPRjGOFGwSBzSz36jVXBSTlXkcxZQW2wlLEyC2sM8/w/gv/pSEF5bo1RNW9U5iEKxlymsS1ibGgBzyPjasciawSqWCNwYNc0= Original-Received: by 10.141.197.8 with SMTP id z8mr3579922rvp.285.1205183741569; Mon, 10 Mar 2008 14:15:41 -0700 (PDT) Original-Received: by 10.141.151.13 with HTTP; Mon, 10 Mar 2008 14:15:41 -0700 (PDT) In-Reply-To: <85myp9kjy6.fsf@lola.goethe.zz> Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92093 Archived-At: On Sat, Mar 8, 2008 at 10:02 PM, David Kastrup wrote: > "Francesc Rocher" writes: > > >> "Lennart Borgman (gmail)" writes: > >>> David Kastrup wrote: > >>>> "Lennart Borgman (gmail)" writes: > >>>> > >>>> I get terrible underlines with CVS Emacs 23, see the attached > >>>> picture. I guess this has something to do with the new font handling, > >>>> or? > >>> > >>> They look fine to me. Have you looked at the screenshot? Maybe it > >>> captures the way things should look rather than how they actually do? > >>> > >> Thanks, yes I looked at the screen shot. There is no space > >> between the characters and the underline. To me that is nearly > >> unreadable. > >> > >> It looked much better before the merge I think. > > > > Yes, you're right. It's time to get support for the variable > > 'x-underline-at-descent-line' under win32. Before the merge it > > was not necessary, but now this patch should be installed: > > [...] > > > > Then, > > > > (setq x-underline-at-descent-line t) > > > > should make the underlining readable (it should look as before). > > Why would one want to have an option then? Can you think of a use case > where people would want to have it set to nil? > > -- > David Kastrup, Kriemhildstr. 15, 44793 Bochum > This variable was introduced to force the drawing of the underline line at the descent line. Please note that the variable 'x-use-underline-position-properties' can make use of the font properties, but by default the underline line is drawn at the base line (don't try to use it under win32, it isn't supported yet). I think the better would be to use the font properties and, probably, to remove both variables. The question is whether all fonts have reliable values about the position and width of the underline line. -- Francesc Rocher