From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Francesc Rocher" Newsgroups: gmane.emacs.devel Subject: Re: Terrible underline Date: Sat, 8 Mar 2008 19:57:43 +0100 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1205008322 20485 80.91.229.12 (8 Mar 2008 20:32:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2008 20:32:02 +0000 (UTC) To: lennart.borgman@gmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 08 21:32:30 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JY5iU-0002tB-4J for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 21:32:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY5hw-0000sd-3l for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 15:31:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JY4Eu-0005qw-OX for emacs-devel@gnu.org; Sat, 08 Mar 2008 13:57:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JY4Es-0005oL-HO for emacs-devel@gnu.org; Sat, 08 Mar 2008 13:57:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY4Es-0005o1-Av for emacs-devel@gnu.org; Sat, 08 Mar 2008 13:57:46 -0500 Original-Received: from wf-out-1314.google.com ([209.85.200.171]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JY4Es-0003VV-4i for emacs-devel@gnu.org; Sat, 08 Mar 2008 13:57:46 -0500 Original-Received: by wf-out-1314.google.com with SMTP id 29so1059210wff.24 for ; Sat, 08 Mar 2008 10:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=MXqHF0rGpo2xtF7hgcsap7upqMnLTSJsT12zUUiA79A=; b=MQK/8b7bTLrQLjG1IF+L7wQ3+Z+G6VUqKW5WBjMlkMVXPoGco3e0hIQmtqRVFtC0zzKq7z3UcSMNmrpGIjQgL0b300lBs/e5AaLumWboLBCGhuXH+XXw+Zve1AomETZMJ04HDGce/GvTfs9SYv+wA5H+hp4OawVa6otOV9bM4Do= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=VLa1+uxHZQKMbWxdHlPpfJ0Og5pB7Z+FLlUg8jXgvai9m04eZktcOtr2zqn+zXjj9mgW/CwrEDNziAtL3S1GF2KJFq6nK7AkUkbzM6pTtZQT8wUcgkbxLdi3O/VknJdk16Ld28Xt6TEL2Wpwejg1nvcF5XnhAJVF2izZtsJxlJM= Original-Received: by 10.142.141.21 with SMTP id o21mr1272900wfd.199.1205002663974; Sat, 08 Mar 2008 10:57:43 -0800 (PST) Original-Received: by 10.142.163.10 with HTTP; Sat, 8 Mar 2008 10:57:43 -0800 (PST) Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Mailman-Approved-At: Sat, 08 Mar 2008 15:31:47 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91767 Archived-At: > "Lennart Borgman (gmail)" writes: >> David Kastrup wrote: >>> "Lennart Borgman (gmail)" writes: >>> >>> I get terrible underlines with CVS Emacs 23, see the attached >>> picture. I guess this has something to do with the new font handling, >>> or? >> >> They look fine to me. Have you looked at the screenshot? Maybe it >> captures the way things should look rather than how they actually do? >> > Thanks, yes I looked at the screen shot. There is no space > between the characters and the underline. To me that is nearly > unreadable. > > It looked much better before the merge I think. Yes, you're right. It's time to get support for the variable 'x-underline-at-descent-line' under win32. Before the merge it was not necessary, but now this patch should be installed: ---8<------8<------8<------8<------8<------8<------8<------8<--- --- w32term.c 3 Mar 2008 06:32:12 -0000 1.284 +++ w32term.c 8 Mar 2008 18:50:46 -0000 @@ -2950,11 +2950,13 @@ #ifdef USE_FONT_BACKEND if (enable_font_backend) { - if (s->face->font) - /* In the future, we must use information of font. */ - y = s->ybase + (s->face->font->max_bounds.descent + 1) / 2; - else - y = s->y + s->height - h; + y = s->y + s->height - h; + if (!x_underline_at_descent_line) + { + if (s->face->font) + /* In the future, we must use information of font. */ + y = s->ybase + (s->face->font->max_bounds.descent + 1) / 2; + } } else #endif ---8<------8<------8<------8<------8<------8<------8<------8<--- Then, (setq x-underline-at-descent-line t) should make the underlining readable (it should look as before). Please note that I have no write access to CVS so, if approved, the patch should be updated by some maintainer. -- Francesc Rocher