From: "Tom Breton (Tehom)" <tehom@panix.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: ewoc patch
Date: Wed, 9 Dec 2009 15:57:35 -0500 [thread overview]
Message-ID: <ada58b4773437ae5e8111ee5fcbbe6c9.squirrel@mail.panix.com> (raw)
In-Reply-To: <jwvocm8dazy.fsf-monnier+emacs@gnu.org>
> Not sure what you mean by "blank" entries. If you mean entries which
> don't get printed (i.e. "invisilbe" entries), then yes, it's
> a limitation that it would be good to lift. IIUC you lift it by:
Yes, I meant entries that print nothing and have no separator.
>> * Design: Nodes that have no text have no start marker.
>
> which I think is a good solution (when I tried to lift that limitation
> it didn't occur to me, so I tried to manually separate the markers that
> needed to move from those that needed to stay put and it was messy).
I bet it was messy. That was the first approach I tried.
>> * ewoc-map is slightly misnamed; it doesn't map, it's more like
>> for-each.
>
> It's the historical name. To fit with other macros (like dotimes,
> dolist), we could call it ewoc-do rather than ewoc-foreach.
Fair enough. But ISTM that while `ewoc-for-each' can have the same
signature as `ewoc-map' has now, `ewoc-do' would be expected to have a
signature like dolist and dotimes. Ie, to be used like:
(ewoc-do (element ewoc)
(do-stuff-to element))
So ewoc-for-each was just an alias but ewoc-do would require more.
>> * Added a version number. I didn't have much to go on, so I just
>> said it was "2.0". I will gladly change it to correspond to an
>> official version number.
>
> The Emacs package generally doesn't like version numbers, so I'd rather
> not introduce one here, unless there's really a good reason for it.
I added it so that other packages that wanted or needed a variable
separator could tell whether it was available. Otherwise they would make
errors if an old ewoc.el was loaded. If you have a better way in mind,
I'll use it.
>> * Added a new field to the ewoc, "separator". That's the string that
>> separates entries. It defaults to "\n".
>
> IIUC it can also be the empty string, right? IIUC, the current ewoc.el
> already makes it possible to get rid of the separator. Making it
> an argument might be a good idea as well.
Yes, I think so too.
>> Testing:
>
>> * Created a test suite. The suite relies on rtest, which
>> unfortunately is still between releasable versions.
>
> We still don't have a testsuite in Emacs, but we'll gladly add the
> testsuite to our repository (we have a `test' subdirectory for that).
Sure. But it uses my tester package rtest; there is an old version of
rtest out there but I'm using my new version that is still in flux.
(Which, circularly, is the reason I wanted to make ewoc more flexible)
>> diff -c -b /home/tehom/emacs-21.4/lisp/emacs-lisp/ewoc.el
>> /home/tehom/projects/emtest/lisp/viewe
Will emacs 22.2 be sufficient?
Tom Breton (Tehom)
next prev parent reply other threads:[~2009-12-09 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 4:03 ewoc patch Tom Breton (Tehom)
2009-12-09 4:19 ` ewoc patch (Was wrong patch, right one attached) Tom Breton (Tehom)
2009-12-09 4:40 ` ewoc patch Stefan Monnier
2009-12-09 20:57 ` Tom Breton (Tehom) [this message]
2009-12-09 21:25 ` Stefan Monnier
2009-12-10 4:52 ` Tom Breton (Tehom)
2009-12-10 7:28 ` Stefan Monnier
2009-12-11 1:23 ` Tom Breton (Tehom)
2009-12-11 5:09 ` Stefan Monnier
2010-08-21 10:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada58b4773437ae5e8111ee5fcbbe6c9.squirrel@mail.panix.com \
--to=tehom@panix.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).