From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 10:20:02 +0000 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9092"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 12:21:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTipS-0002FG-CI for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 12:21:02 +0200 Original-Received: from localhost ([::1]:46134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTipR-00039Z-At for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 06:21:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTioa-0002ep-Nc for emacs-devel@gnu.org; Tue, 06 Apr 2021 06:20:08 -0400 Original-Received: from heytings.org ([95.142.160.155]:58960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTioY-0001bj-5G; Tue, 06 Apr 2021 06:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617704403; bh=yDie+dXa+2cJwQaDWPOJOpf5bsIUIl4lJb1AC1mkoIQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=XTLAtaK5fkQc3TAg2tL59g26/cQKHYUdcV5ZCFaqVWAacNOfDkzRdeZBsxAysD5d/ 3z5ynUhaNM8OQZ5OTPB56xdiA6FglEz17YXqRQGdebwRz6k2sjcl9FiTtavkTPzmQa JlCdV/Q8T42KCieJIvfOpteEnCQEs6f+Lb50wk5fVOGr+ztLZO8K+yTGPqhPOkTEbg PsrkNzU4x8cencuX1SWM1ZMC2me7ql5S3YJXURfXl9T4X5muYL3uVd/PSWp6PlTXoO IbYtKuukdeb7u+gr5EKJkSyV6nj8QQUzUOH1lu6ngHgKFM2g5W/TQVbOb0ZAW8ZsQB FE2d17yTMPAVw== In-Reply-To: <87blar3glt.fsf@posteo.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267462 Archived-At: >> Do you really think it is better to ask users to set five options in >> their init file (icomplete-separator, icomplete-hide-common-prefix, >> icomplete-prospects-height, icomplete-minibuffer-setup-hook and >> icomplete-completions-filter-hook) instead of providing them right away >> with what they want with (icomplete-vertical-mode 1)? > > No, I think it would be better to have one user option like > icomplete-presentation set to 'vertical or something like that. > As I said, it's meant to be a derived minor mode, much like lisp-data-mode is derived from prog-mode. A similar example (in the same file) is fido-mode which is derived from icomplete-mode, and (in another file) whitespace-newline-mode which is derived from whitespace-mode. Moreover, I think that in general local changes to code are better than global ones whenever that is feasible. Using a user option would do the same thing as the minor mode, except that the changes would be scattered through the existing code.