From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Tue, 06 Apr 2021 14:17:28 +0000 Message-ID: References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="mbT03xtFWz" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5329"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Manuel Uberti , "emacs-devel@gnu.org" , Zhiwei Chen , =?UTF-8?Q?Daniel_Mart=C3=ADn?= To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 16:18:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTmXK-0001Gb-GA for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 16:18:34 +0200 Original-Received: from localhost ([::1]:48168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTmXJ-0003KP-Fc for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 10:18:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmWO-0002sL-8Z for emacs-devel@gnu.org; Tue, 06 Apr 2021 10:17:37 -0400 Original-Received: from heytings.org ([95.142.160.155]:59228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmWI-0004lE-7y for emacs-devel@gnu.org; Tue, 06 Apr 2021 10:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617718648; bh=fPfvBNHBBojNSraefyOulMBXqUekk7Hmu6BcPV29ylI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=YrU+w1Hf/J+4f0A1rgZet/rTnY7ZYX6hHpkyBejoQCvFbCneiFGpY5PzGbfdTuCKN Liux4oZ/2EVtpq6/1qNFD+H7gEZVoBrgknXRJQzf2DG4Lg+qavDvY2etCpL6GhZR0c YlMysroew8z2HCSn7NfPp2LFpv7fEHTMrhjbVA0oZ/sDDiRctsXFMQLxbOcInRuuxN v6ezs4DaHjtOBHz57QrnVSzRO0c5JFVb22n01yvvIl/aa1u89KDSSqGMg2S9N/1i3Y rcUPjTHOYe9phUCQaEAQdrbdfQTQoveirhoWXn6YVwXs10JFiXQJhCsOLPC5ZWkMgH 0ndDMEgHn056A== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267473 Archived-At: --mbT03xtFWz Content-Type: text/plain; charset=us-ascii; format=flowed >> I'm not completely sure I understand the behavior you describe, but >> since you consider it counter-intuitive, it sounds like you might want >> to `M-x report-emacs-bug`. > > IIUC, what Zhiwei Chen described is what happens with: > > (define-key isearch-mode-map (kbd "M-s o") #'(lambda () (interactive) > (call-interactively 'isearch-occur) (pop-to-buffer "*Occur*"))) > > Point moves to the occur buffer after you type M-s o, yet isearch has > not ended, so pressing "n", "p", "q", ... adds these characters to the > search string instead of acting in the occur buffer. > > I'm not sure this is a bug, but it should be possible to avoid that > behavior by checking e.g. in isearch-pre-command-hook that point is > still in the buffer in which isearch started. > And here is a micro-patch to fix that behavior. --mbT03xtFWz Content-Type: text/x-diff; name=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch Content-Transfer-Encoding: base64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch RnJvbSA4NmFmMGQ2NTZlNmVmMTNjOTJkN2ViNGVjNmJkZmM1ZjIwNGI0MTAx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDYgQXBy IDIwMjEgMTQ6MTQ6MDQgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gVGVybWlu YXRlIGlzZWFyY2ggd2hlbiBwb2ludCBoYXMgbW92ZWQgdG8gYW5vdGhlciBi dWZmZXINCg0KKiBsaXNwL2lzZWFyY2guZWwgKGlzZWFyY2gtcG9zdC1jb21t YW5kLWhvb2spOiBUZXJtaW5hdGUgaXNlYXJjaA0Kd2hlbiB0aGUgY29tbWFu ZCBqdXN0IGV4ZWN1dGVkIGhhcyBtb3ZlZCBwb2ludCB0byBhbm90aGVyIGJ1 ZmZlci4NCi0tLQ0KIGxpc3AvaXNlYXJjaC5lbCB8IDYgKysrKystDQogMSBm aWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0K DQpkaWZmIC0tZ2l0IGEvbGlzcC9pc2VhcmNoLmVsIGIvbGlzcC9pc2VhcmNo LmVsDQppbmRleCA5NDNlMjRhYTU2Li4wZjA5ODViYTgzIDEwMDY0NA0KLS0t IGEvbGlzcC9pc2VhcmNoLmVsDQorKysgYi9saXNwL2lzZWFyY2guZWwNCkBA IC0xMjA5LDcgKzEyMDksOCBAQCB1c2VkIHRvIHNldCB0aGUgdmFsdWUgb2Yg YGlzZWFyY2gtcmVnZXhwLWZ1bmN0aW9uJy4iDQogCTs7IFNhdmUgdGhlIG9y aWdpbmFsIHZhbHVlIG9mIGBtaW5pYnVmZmVyLW1lc3NhZ2UtdGltZW91dCcs IGFuZA0KIAk7OyBzZXQgaXQgdG8gbmlsIHNvIHRoYXQgaXNlYXJjaCdzIG1l c3NhZ2VzIGRvbid0IGdldCB0aW1lZCBvdXQuDQogCWlzZWFyY2gtb3JpZ2lu YWwtbWluaWJ1ZmZlci1tZXNzYWdlLXRpbWVvdXQgbWluaWJ1ZmZlci1tZXNz YWdlLXRpbWVvdXQNCi0JbWluaWJ1ZmZlci1tZXNzYWdlLXRpbWVvdXQgbmls KQ0KKwltaW5pYnVmZmVyLW1lc3NhZ2UtdGltZW91dCBuaWwNCisJaXNlYXJj aC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkNCiANCiAgIChpZiAobG9jYWwt dmFyaWFibGUtcCAndG9vbC1iYXItbWFwKQ0KICAgICAgIChzZXRxIGlzZWFy Y2gtdG9vbC1iYXItb2xkLW1hcCB0b29sLWJhci1tYXApKQ0KQEAgLTMwMTIs NiArMzAxMyw5IEBAIFNlZSBtb3JlIGZvciBvcHRpb25zIGluIGBzZWFyY2gt ZXhpdC1vcHRpb24nLiINCiAgICAgICAgICAgIChnb3RvLWNoYXIgaXNlYXJj aC1wcmUtbW92ZS1wb2ludCkpDQogICAgICAgICAgKGlzZWFyY2gtc2VhcmNo LWFuZC11cGRhdGUpKSkNCiAgICAgIChzZXRxIGlzZWFyY2gtcHJlLW1vdmUt cG9pbnQgbmlsKSkNCisgIDs7IFRlcm1pbmF0ZSB0aGUgc2VhcmNoIGlmIHBv aW50IGhhcyBtb3ZlZCB0byBhbm90aGVyIGJ1ZmZlci4NCisgICh1bmxlc3Mg KGVxIGlzZWFyY2gtYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpDQorICAgIChp c2VhcmNoLWNhbmNlbCkpDQogICAoZm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkp DQogDQogKGRlZnVuIGlzZWFyY2gtcXVvdGUtY2hhciAoJm9wdGlvbmFsIGNv dW50KQ0KLS0gDQoyLjMwLjINCg0K --mbT03xtFWz--