Re: Simple isearch concerns

[Gregory Heytings <gregory@heytings.org>]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]


>> I'm not completely sure I understand the behavior you describe, but 
>> since you consider it counter-intuitive, it sounds like you might want 
>> to `M-x report-emacs-bug`.
>
> IIUC, what Zhiwei Chen described is what happens with:
>
> (define-key isearch-mode-map (kbd "M-s o") #'(lambda () (interactive) 
> (call-interactively 'isearch-occur) (pop-to-buffer "*Occur*")))
>
> Point moves to the occur buffer after you type M-s o, yet isearch has 
> not ended, so pressing "n", "p", "q", ... adds these characters to the 
> search string instead of acting in the occur buffer.
>
> I'm not sure this is a bug, but it should be possible to avoid that 
> behavior by checking e.g. in isearch-pre-command-hook that point is 
> still in the buffer in which isearch started.
>

And here is a micro-patch to fix that behavior.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch, Size: 1506 bytes --]

From 86af0d656e6ef13c92d7eb4ec6bdfc5f204b4101 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Tue, 6 Apr 2021 14:14:04 +0000
Subject: [PATCH] Terminate isearch when point has moved to another buffer

* lisp/isearch.el (isearch-post-command-hook): Terminate isearch
when the command just executed has moved point to another buffer.
---
 lisp/isearch.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 943e24aa56..0f0985ba83 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -1209,7 +1209,8 @@ used to set the value of `isearch-regexp-function'."
 	;; Save the original value of `minibuffer-message-timeout', and
 	;; set it to nil so that isearch's messages don't get timed out.
 	isearch-original-minibuffer-message-timeout minibuffer-message-timeout
-	minibuffer-message-timeout nil)
+	minibuffer-message-timeout nil
+	isearch-buffer (current-buffer))
 
   (if (local-variable-p 'tool-bar-map)
       (setq isearch-tool-bar-old-map tool-bar-map))
@@ -3012,6 +3013,9 @@ See more for options in `search-exit-option'."
            (goto-char isearch-pre-move-point))
          (isearch-search-and-update)))
      (setq isearch-pre-move-point nil))
+  ;; Terminate the search if point has moved to another buffer.
+  (unless (eq isearch-buffer (current-buffer))
+    (isearch-cancel))
   (force-mode-line-update))
 
 (defun isearch-quote-char (&optional count)
-- 
2.30.2