From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 14:19:43 +0000 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15119"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 16:20:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTmZD-0003mZ-2y for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 16:20:31 +0200 Original-Received: from localhost ([::1]:52374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTmZC-00056O-2a for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 10:20:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmYW-0004Fo-07 for emacs-devel@gnu.org; Tue, 06 Apr 2021 10:19:48 -0400 Original-Received: from heytings.org ([95.142.160.155]:59242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmYU-00060x-FY; Tue, 06 Apr 2021 10:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617718784; bh=isyqdhz+/6VW97EBHBk1LQ+Z5tIyOk78bC7iUkLu2zI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=NrHjUohuD3V4/gGtGv59S6X697dQ/bpkaPRe6qgYuUY2Mjryz/BM5PL+bioLIQ3cr 77FzcloP08TYoJCgGpt1y2eB4sjVF56u6tnLitM9Xqrb/+yifM2JBtoHxKtWctntd9 nRqr6E/5e5QSPm9g0fXeQI5KAXnEIkmv4llA7QtyEccn6hutPiFVTQQ/4/ftUz0BTI hxzL8l7yQYMPyxX6GUnIdVEXeYpxDf2uFy9khCdN4ezJMrXRf9mhGDHS/QRm62Mc1n J9bXXw0nH2V+yvwb4DP01GMXck2zJT1x6+0KDFtsrka1/SMBFiRORCVUog6TJibjk0 nGON/YPeuUelw== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267474 Archived-At: >> Thanks a lot also for your other comments, which I included in the >> attached revised patch. The only thing I wasn't sure is whether it was >> intentional that you removed the :group 'icomplete from the minor mode >> tags, > > It was, since I presume this is placed inside the icomplete.el file > where this arg is redundant. > Okay, I did not know (and did not check) this. Note that the tag is present for both fido-mode and icomplete-mode.