From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 20:09:56 +0000 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> <87im4z1gbc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 22:11:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTs38-0000dA-7v for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 22:11:46 +0200 Original-Received: from localhost ([::1]:51482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTs37-00036F-8L for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 16:11:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTs1R-0001pn-Cw for emacs-devel@gnu.org; Tue, 06 Apr 2021 16:10:01 -0400 Original-Received: from heytings.org ([95.142.160.155]:59620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTs1P-0002HY-FM; Tue, 06 Apr 2021 16:10:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617739796; bh=xpK3kwjJryJ/TgefuHJKZc9PmtjlgB1OYHrksAwFiLI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=QJYr+F2YBg566SHRioDnTdVGEHOUAzqGmZ1adfFwBB//CK6spai+tiYNuRCCOOsEM mg4sTIAfIHxitQoyNMQTByzOnoPWAMJ/nPAEKT0ZxBejh+Xh0XLUSauKrOeP+e0gaj O3YXptLUypsVYYIbORExZtddOW3woyW24jesOUQk5r86k1s6hLmoBq9gW4bsYdjzKf 59yrNbj7950upWItKPWkLiNkLa/h1LJCsjDKeisoCnI/ugruKckxRHWOAp7ABChK0A MX1pwC6loqWVticUquVAtdphUowUf9eqoBCPGN4Y8EtBzSTnnysX+vo2K4byI+adsA JLc46YRWni55w== In-Reply-To: <87im4z1gbc.fsf@mail.linkov.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267493 Archived-At: >> Okay. Here is the final (?) version of the patch; I forgot to update >> the docs in the previous one. > > I tried it out, and everything works nicely. > Thanks for reviewing! > > The only problem I see this code is too hackish: > >> +(defun icomplete--vertical-reformat-completions () >> + "Reformat the completion candidates returned by `icomplete-completions'." >> + (save-match-data >> + (setq icomplete-current-completions >> + (if (string-match "^\\((.*)\\|\\[.*\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" >> + icomplete-current-completions) >> + (format "%s \n%s" >> + (or (match-string 1 icomplete-current-completions) "") >> + (match-string 2 icomplete-current-completions)) >> + icomplete-current-completions)))) > > I guess like there are variables that affect formatting of the output > e.g. 'icomplete-hide-common-prefix', there could be a new similar > variable 'icomplete-add-initial-newline' to add a newline in the > 'icomplete-completions' formatting function. > It is (a bit) hackish because the output of icomplete-completions is (a bit) hackish. Adding an initial newline to the output of icomplete-completions wouldn't be enough, icomplete-completions uses () [] {} and | as delimiters. Of course one could change all these delimiters into user options, but IMO it would add more complexity than necessary, and with the new icomplete-completions-filter-hook anyone can reformat the output the way they want it.