From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 11:52:24 +0000 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34819"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Eli Zaretskii , Ergus , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 13:53:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTkGd-0008wt-0v for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 13:53:11 +0200 Original-Received: from localhost ([::1]:34604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTkGc-0001vK-1j for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 07:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTkFx-0001UL-HV for emacs-devel@gnu.org; Tue, 06 Apr 2021 07:52:29 -0400 Original-Received: from heytings.org ([95.142.160.155]:59036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTkFv-0002f3-Jc; Tue, 06 Apr 2021 07:52:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617709944; bh=YhbO2XNH8cJmHC/oSHSXjwvDpataV+nwVKrqVZoeDio=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=GOd7DuzZTEXgC+r4xeb1YJ+ZbFZMaXbOh+mQepWYEekL+WcMrcx85keeBjQeHPN6c fIaktcopf2hwcz5xa8D/OI6mLfa71hmQH0kM4egMAomAnay5oM19la8xsGq+Mxpclb UqZ3zjFI2RTuz0OdQrfJqQXySR8BF2wKgOYZJSm4SfOUHyFh1n44eYtVcldovCJP+l FIehXqgLNIcoNZCFOaDJm3df8jhX15YHakMs8EXf0lxL6NywWLCMljAkOiJoRtpp0l QKgnc/Kb/CE3Z7pJbDjXVtWLdvFOLfX3agUqvOUk0VDKmwJ3c4ic1ud1KsEgOv4E4F ePAs8EPsfpeJA== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267464 Archived-At: >> Sorry for bringing this up again, but I still don't get why this is a >> minor mode from a user perspective. Vertical or horizontal doesn't >> sound like something that should be a (global) mode, but a regular >> option. Wasn't there a patch or a branch that tried to implement it >> that way? > > That would be the feature/icomplete-vertical branch. > > Which we'll certainly need to consider and compare when reviewing this > patch. > It was a consequence of the development of that feature branch that the redisplay-adhoc-scroll-in-resize-mini-windows variable was added to Emacs. This variable, which is used by this patch, is the only way to implement the feature correctly, that is, while obeying Emacs' constraints on the miniwindow size (max-mini-window-height, resize-mini-windows, size of the other windows in the frame, and so forth).