From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Sun, 29 Jan 2017 16:09:50 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1485724726 5391 195.159.176.226 (29 Jan 2017 21:18:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 21:18:46 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 29 22:18:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwru-000173-5r for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 22:18:38 +0100 Original-Received: from localhost ([::1]:56780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXwrz-00089k-3I for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 16:18:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXwjW-0008WT-T8 for emacs-devel@gnu.org; Sun, 29 Jan 2017 16:10:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXwjS-0002ND-5d for emacs-devel@gnu.org; Sun, 29 Jan 2017 16:09:57 -0500 Original-Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:36256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXwjS-0002Mr-1E for emacs-devel@gnu.org; Sun, 29 Jan 2017 16:09:54 -0500 Original-Received: by mail-qk0-x243.google.com with SMTP id i34so13653253qkh.3 for ; Sun, 29 Jan 2017 13:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=MeAmgJOGkIGgxulD9HuFhAoq7qhPSeonJ6LFQhy9aV4=; b=VjY4iEPjPf2MOWsyRLMwwZzg+pFiY78QVP72NeAeVaRWiHgewfRQwFbCL/DXe0FghS 83mpfgAM5/xMkJiDqeKzI6ESH/P29+ZoqNQBI5ykgyJzQ2CeCo6unFc5+MOAVqt5/kYG fept6t+zBl7kXERHUt0HIQRJFTLDMR9S7GBWm5/liub8BOq9854HMmkYo3jrXXdOWzWV oFevbW9sw3eokb9byHY+LYaBDLBct0vHypHefhUIBiDVaA3rFWQ6Bb1MC25lpv2WG1ZK eGZ7onXz6fyrcRgAmLUgTKsRNmj0AWxLOtEATmG2SSnFFho8Au4g7AqqAmEtG3Armool aqRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=MeAmgJOGkIGgxulD9HuFhAoq7qhPSeonJ6LFQhy9aV4=; b=NnqvynIgnmKHDU3z87GUCyv/cRF8JNyCNNjk6erDKgI1+VSIaYhdNfvXeP9tnAGFjg cgBmkt/RdNtTYXv2W7yo5ztYriJl8DsrhksOGyBdvuORhiA+E7bRKx8DID2h0DM4dXp9 zbPFABUF2bJxSlw9nBDXXJLZ0SQYoefSEeFTeXewnAKh8sQBXPWdig5uyO2SIku2PZ9f FuS6t4erL8nuZ1UYom2sHgs5WzIEd6x+xnmB2G0AL03pwiKdPe9b1JsmJAnq2KtfqrAN DboUylD6q4AL9LSf1wpZWQANG6sgMBa15/dpMdw3+12MEa1u3T0dpE8o2f5paVXsJ3a5 dF1g== X-Gm-Message-State: AIkVDXJO+YXnOcn9j0DMVZOkYknKmCM+c1TIQYzCVR5knl+DyXoiW4dQRPmPDyZt/hBHHA== X-Received: by 10.55.42.208 with SMTP id q77mr18236646qkq.129.1485724192115; Sun, 29 Jan 2017 13:09:52 -0800 (PST) Original-Received: from [192.168.1.104] (c-67-186-135-89.hsd1.ma.comcast.net. [67.186.135.89]) by smtp.gmail.com with ESMTPSA id w41sm10210305qtw.34.2017.01.29.13.09.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jan 2017 13:09:51 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211735 Archived-At: On 2017-01-29 10:37, Noam Postavsky wrote: > On Fri, Jan 27, 2017 at 10:46 PM, Noam Postavsky > wrote: >> On Fri, Jan 27, 2017 at 10:30 PM, Clément Pit--Claudel >> wrote: >>> On 2017-01-27 20:59, Noam Postavsky wrote: >>>> I guess let-binding `debugger' to a function which performs the >>>> logging should do the trick? >>> >>> I already do that, in fact, and I do re-throw the exception from there. Looks like things didn't work because of the way `debugger' is called in `cl--assertion-failed'. Is that call correct? The argument in (funcall debugger `(cl-assertion-failed ,form ,string ,@sargs)) doesn't seem to match the docs: >>> >>> If due to error, args are ‘error’ and a list of the args to ‘signal’. >>> >>> Is the call just missing an 'error argument? >>> >> >> Oh yeah, I guess it is. > > Um, should this be > > (funcall debugger 'error `(cl-assertion-failed ,form ,string ,@sargs)) > > or > > (funcall debugger 'error `(cl-assertion-failed (,form ,string ,@sargs))) > > I'm getting confused with all the levels of nesting and funcall/apply. I think the second one. `debugger' gets two arguments, 'error and a list of arguments to `signal'. That list should have two entries: `cl-assertion-failed' and `(,form ,string ,@sargs). Thanks!