From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master 68ae6fa: Improved light/dark colour predicate (bug#41544) Date: Thu, 18 Jun 2020 12:35:52 -0700 (PDT) Message-ID: References: <20200610181238.9796.44750@vcs0.savannah.gnu.org> <20200610181239.947C4204DF@vcs0.savannah.gnu.org> <93F81C41-E774-4C02-9E9D-5B2CD1F66445@acm.org> <86v9jwksod.fsf@stephe-leake.org> <5A6B8DE2-EADF-4D74-A0EA-DE5303F828D4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="67994"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: =?iso-8859-1?B?TWF0dGlhcyBFbmdkZWflcmQ=?= , Stephen Leake , Yuri Khan , tomas@tuxteam.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 18 21:39:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm0Nc-000Hb0-N2 for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 21:39:20 +0200 Original-Received: from localhost ([::1]:58908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jm0Nb-0007Qz-OR for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 15:39:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm0MN-0005bd-5e for emacs-devel@gnu.org; Thu, 18 Jun 2020 15:38:03 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:55184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm0ML-0004I6-5f for emacs-devel@gnu.org; Thu, 18 Jun 2020 15:38:02 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05IJbukX139137; Thu, 18 Jun 2020 19:37:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ad7ygZvetPHmVyTqe4+tYOx9yxPie91BKKUEX+k464Q=; b=Pif4TCo7JUtAhs9byrYXGvvXud4LQ0SXwChIPR3Xk5E4VWBYSehOBQEtAzdceb7SJOIv sQSVQ2YcZEjU+dHLnXSmIk4CToELM4IwPrfEvmvk4M6OCnc/uxRhiKU1myzOxyMSZFLo us/EhH22BWIF2xnsuaTIH94HzZquoU1zvzBe5+tcYdB5bBKHFQfalauUFUijn8RpbVhp U+2kdWQ3GCS6JHSmYeyQbU7W6mAeMWn7GVlaVKqM6etcZANv6lqAPU7YceubwZyu0vLN ebG/gRkMI9nAExsoqtX3FTm/4DdR5+RmL8inlylCC1u8J/SE2ZQw0uafYPF3UmA1Vw2p 1g== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 31q66034aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 18 Jun 2020 19:37:56 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05IJXIXo082143; Thu, 18 Jun 2020 19:35:55 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 31q66t43jq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jun 2020 19:35:55 +0000 Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 05IJZsTf014634; Thu, 18 Jun 2020 19:35:54 GMT In-Reply-To: <5A6B8DE2-EADF-4D74-A0EA-DE5303F828D4@acm.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5005.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9656 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006180148 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9656 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 impostorscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006180148 Received-SPF: pass client-ip=156.151.31.86; envelope-from=drew.adams@oracle.com; helo=userp2130.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/18 15:37:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -63 X-Spam_score: -6.4 X-Spam_bar: ------ X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252320 Archived-At: > Thanks to those who replied -- the originally proposed 0.325 luminance li= mit > seems to be fairly uncontroversial and can be changed if evidence indicat= es > that it was badly chosen. Most of all, the value seems to work well acros= s > all platforms and a sufficient variety of equipment, which is the importa= nt > part. >=20 > Special thanks to Yuri for helping me confirm that the theoretical 50% > lightness of luminance 0.18 wasn't necessarily an optimal value in this c= ase. > Trust my own eyes, but verify! >=20 > The constant has now been given a (provisional) name, for extra clarity a= nd > ease of adjustment. Not to belabor this, and I don't recall all that's involved. But if there are different eyes, screens, whatever, would it make sense to use a defvar, or even a defcustom, instead of a defconst? Why decide this definitively at design time? Does it make sense to hard-code it? If the question isn't useful, please ignore.