From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: project--completing-read-strict breaks ada-mode project completion table Date: Tue, 14 May 2019 05:13:52 +0300 Message-ID: References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> <4e729d1e-bb31-455f-fd44-e99ae5a6b9fa@yandex.ru> <86zhs5r9lr.fsf_-_@stephe-leake.org> <08de4d90-d678-0524-9356-f9a3515bf0c4@yandex.ru> <86a7k2rabi.fsf@stephe-leake.org> <86sgxso27d.fsf@stephe-leake.org> <69076784-83cb-5cc7-be39-fea990b8535e@yandex.ru> <861s55n6wk.fsf@stephe-leake.org> <86lg2swg14.fsf@stephe-leake.org> <86wom5vlki.fsf@stephe-leake.org> <86sgwpuk2q.fsf@stephe-leake.org> <86imv99982.fsf@stephe-leake.org> <865zqq7bbn.fsf@stephe-leake.org> <861s1a6t3t.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="55814"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 To: Stephen Leake , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 14 04:14:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQMxo-000ESI-JV for ged-emacs-devel@m.gmane.org; Tue, 14 May 2019 04:14:44 +0200 Original-Received: from localhost ([127.0.0.1]:37795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQMxn-0000yx-Jr for ged-emacs-devel@m.gmane.org; Mon, 13 May 2019 22:14:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQMxC-0000yl-BM for emacs-devel@gnu.org; Mon, 13 May 2019 22:14:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQMx8-0006r1-2l for emacs-devel@gnu.org; Mon, 13 May 2019 22:14:04 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:37092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQMx5-0006jk-PV for emacs-devel@gnu.org; Mon, 13 May 2019 22:14:00 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id e15so4910585wrs.4 for ; Mon, 13 May 2019 19:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c4ZvGuTdxVrsAB1kx6VLgLPEwrDXNRBNEe74vulZedU=; b=XwArHxQwm2NQwgt750drPMxmChEzZvh0DykWBofjW+Pwhf5AWrxfbk5b4M6enc60oX NuXEZqJr48IjKDsP/P7a7Go9pcMvlbijeIb//s1DRbxeBsJFdxHPXEl4IexhOKzTeAde 8Th6hePqeJjY+mL5rjhsZ3SCE83HNLK4a7bKgufKfq6H5woiLyPFqDmM1wkyY8871sHL eYKcbwfQjrNODZ/Sn33au2TSWnuhRXUeW7dXaQ8v44yQdGEpokVwghbSTg6d3q7zMF/h O1jyW1Jm6LoIT47ML324qcxzDBcwYG03/YnP2BdJ03eThm4lt/UP0+62T0Do85V0QvlI vIHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c4ZvGuTdxVrsAB1kx6VLgLPEwrDXNRBNEe74vulZedU=; b=jqW25er3GFYh2Kea+2Qert6VpP10CgxoWqcxgUKRU4WigMSs6Am2M0bSIzAN6+OvQg 0eHz4RNDmJzfqkyjEjAbaYpHdd1so2VJksq8IxMkEfiPk6gZzcWsUtBeQjeIgSYLmVTm ZVbnkRgdmO7NF3p4RxbZmVrPmJTQtlFIhr9WPDJqjzVmjmBhz9/rBacoOVhvKO+WLqUR YzOnbThEQQOjpYiiqbFJW/s19rbKSbt4ijmXrbI3qIsR16kruASBCA72m9qmWW29ynld Y4Kh8kLNBvbHNGlt+vk2ph8xyx5W1cbT9fSSOCb7wArSIveiQPDgG5XC8MbM5/3FDfr1 Kw6w== X-Gm-Message-State: APjAAAVeArXdlAb/ZW3DDRW5iPfYlbsh2+m+hmZVZ9zbd9jQbJ2PvzxZ KtKwA7Hva/q6kSCdGEZKBEpb4WVK X-Google-Smtp-Source: APXvYqxOVQhaqyepM6hX5mmCRyuF2IlRBxQnDmmNYJTggq0h8k1ZK2NA5jzTW76Pz/9TVmL2kH3KPA== X-Received: by 2002:adf:fb47:: with SMTP id c7mr5119857wrs.116.1557800035945; Mon, 13 May 2019 19:13:55 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p67sm1038383wmp.22.2019.05.13.19.13.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 19:13:54 -0700 (PDT) In-Reply-To: <861s1a6t3t.fsf@stephe-leake.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236488 Archived-At: On 07.05.2019 21:02, Stephen Leake wrote: > It would be slightly more efficient if `project-find-file-read-fn' took > an 'all-files' arg instead of 'collection' (which is a completion-table > function); I have to do '(all-completions "" collection predicate)' to > get the files list to pass to uniq-file-uniquify. OK, I pushed a slightly different patch, the variable is named project-read-file-name-function. > The downside of that is other read-file-from-list functions might have > to duplicate 'project-file--completion-table' as well. Until we have > another example of this, we can't tell which design is better. And the functions do need to take care of constructing the completion table themselves. I think the result looks simpler, though.