Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Po Lu]

Dmitry Gutov <dgutov@yandex.ru> writes:

> branch: master
> commit eb90fb52b08a16ae2bdc8bad6929492b9e693f72
> Author: Dmitry Gutov <dmitry@gutov.dev>
> Commit: Dmitry Gutov <dmitry@gutov.dev>
>
>     elixir-ts-mode: Bring the faces' use closer to other ts modes
>     
>     * lisp/progmodes/elixir-ts-mode.el (elixir-ts--font-lock-settings):
>     Rename feature 'elixir-function-name' to 'elixir-definition' and
>     update all deferences.  Add parameters' highlighting with
>     font-lock-variable-name-face.  Change variable references'
>     highlighting to use font-lock-variable-use-face.
>     Move the feature 'elixir-variable' from feature level 3 to level 4, to
>     match other ts modes (bug#67246).

This commit message is too wide.  Please fill commit messages so that
they remain within 64 columns, in turn preventing generated ChangeLog
entries from exceeding 72 columns.

Failure to observe these procedures is no harmless oversight, it
complicates the release process not-insignificantly by creating log
entries that must be reformatted by hand.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Dmitry Gutov]

On 07/02/2024 04:41, Po Lu wrote:
> This commit message is too wide.  Please fill commit messages so that
> they remain within 64 columns, in turn preventing generated ChangeLog
> entries from exceeding 72 columns.

This is the width to which the message was reformatted by fill-paragraph 
(M-q) in vc-git-log-edit-mode.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Po Lu]

Dmitry Gutov <dmitry@gutov.dev> writes:

> On 07/02/2024 04:41, Po Lu wrote:
>> This commit message is too wide.  Please fill commit messages so that
>> they remain within 64 columns, in turn preventing generated ChangeLog
>> entries from exceeding 72 columns.
>
> This is the width to which the message was reformatted by
> fill-paragraph (M-q) in vc-git-log-edit-mode.

Set the fill column to 64 first with `C-x f'.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Dmitry Gutov]

On 07/02/2024 04:47, Po Lu wrote:
> Dmitry Gutov<dmitry@gutov.dev>  writes:
> 
>> On 07/02/2024 04:41, Po Lu wrote:
>>> This commit message is too wide.  Please fill commit messages so that
>>> they remain within 64 columns, in turn preventing generated ChangeLog
>>> entries from exceeding 72 columns.
>> This is the width to which the message was reformatted by
>> fill-paragraph (M-q) in vc-git-log-edit-mode.
> Set the fill column to 64 first with `C-x f'.

Sorry, I can't promise to do that every time I write a commit.

Some automated solution would work better.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Po Lu]

Dmitry Gutov <dmitry@gutov.dev> writes:

> Sorry, I can't promise to do that every time I write a commit.

It's exceedingly simple to type `C-x f 64 M-q' before every commit.

There's nothing wrong with failing to observe these conventions on
occasion, but you mustn't refuse them in explicit terms; if you cannot
promise to try your best to meet our standards for commit messages,
what's to say our other standards won't also be flouted with the same
justification?

> Some automated solution would work better.

See what I just installed.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 07 Feb 2024 11:14:00 +0800
> 
> Dmitry Gutov <dmitry@gutov.dev> writes:
> 
> > Sorry, I can't promise to do that every time I write a commit.
> 
> It's exceedingly simple to type `C-x f 64 M-q' before every commit.
> 
> There's nothing wrong with failing to observe these conventions on
> occasion, but you mustn't refuse them in explicit terms; if you cannot
> promise to try your best to meet our standards for commit messages,
> what's to say our other standards won't also be flouted with the same
> justification?
> 
> > Some automated solution would work better.
> 
> See what I just installed.

Isn't 64 too small a value?  The default for ChangeLog is 74, and you
need to subtract 9 for the TAB.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Isn't 64 too small a value?  The default for ChangeLog is 74, and you
> need to subtract 9 for the TAB.

For historical reasons, log-edit--insert-filled-defuns treats the
fill-column as being one character wider than its value, so a
fill-column of 64 produces entries that span up to 65 columns.  I'm not
aware of the reason for this strange behavior, only that it existed and
was faithfully reproduced in the rewrite.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Isn't 64 too small a value?  The default for ChangeLog is 74, and you
>> need to subtract 9 for the TAB.

You need to subtract 8 for the TAB, right?

BTW, why not bump our ChangeLog default to 80?  This gives us a text
area that spans 72 characters excluding indentation, and will make our
ChangeLogs take up less vertical space without hurting readability.

> For historical reasons, log-edit--insert-filled-defuns treats the
> fill-column as being one character wider than its value, so a
> fill-column of 64 produces entries that span up to 65 columns.  I'm not
> aware of the reason for this strange behavior, only that it existed and
> was faithfully reproduced in the rewrite.

That sounds like a bug, on first approximation.  Especially if we don't
even know why it does that.

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Po Lu]

Stefan Kangas <stefankangas@gmail.com> writes:

> You need to subtract 8 for the TAB, right?
>
> BTW, why not bump our ChangeLog default to 80?  This gives us a text
> area that spans 72 characters excluding indentation, and will make our
> ChangeLogs take up less vertical space without hurting readability.

I find 72 slightly too wide for my tastes.  The important consideration
is consistency, however, so any change should wait until the Emacs 30
release (and not apply to the release branch).

> That sounds like a bug, on first approximation.  Especially if we don't
> even know why it does that.

People do rely on its being thus, so the bug has become a feature...

Re: master eb90fb52b08 2/3: elixir-ts-mode: Bring the faces' use closer to other ts modes

[Dmitry Gutov]

On 07/02/2024 05:14, Po Lu wrote:
> Dmitry Gutov <dmitry@gutov.dev> writes:
> 
>> Sorry, I can't promise to do that every time I write a commit.
> 
> It's exceedingly simple to type `C-x f 64 M-q' before every commit.
> 
> There's nothing wrong with failing to observe these conventions on
> occasion, but you mustn't refuse them in explicit terms; if you cannot
> promise to try your best to meet our standards for commit messages,
> what's to say our other standards won't also be flouted with the same
> justification?

Occasionally I forget to observe other conventions that require manual 
control. Your suggestion above was another addition to that which 
requires an extra key sequence and a magic number. I don't mean to be 
confrontational, that's just honest answer.

>> Some automated solution would work better.
> 
> See what I just installed.

Thanks.

Re: master 8a39216ce92 3/3: elixir-ts-mode: Highlight more method definitions

[Po Lu]

Dmitry Gutov <dgutov@yandex.ru> writes:

> branch: master
> commit 8a39216ce920d82b86a40471429e30d75c6ee42d
> Author: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Commit: Dmitry Gutov <dmitry@gutov.dev>
>
>     elixir-ts-mode: Highlight more method definitions
>     
>     * lisp/progmodes/elixir-ts-mode.el (elixir-ts--font-lock-settings):
>     Also highlight method definitions where the arguments are literal
>     values, not identifiers (bug#67246).

Wilhelm, this commit message is too wide.  In your future contributions,
please fill commit messages so that they remain within 64 columns, in
turn preventing generated ChangeLog entries from exceeding 72 columns.
Typing `M-q' within a *vc-log* buffer will suffice most of the time.

Re: master 8a39216ce92 3/3: elixir-ts-mode: Highlight more method definitions

[Dmitry Gutov]

On 07/02/2024 04:45, Po Lu wrote:
> Wilhelm, this commit message is too wide.  In your future contributions,
> please fill commit messages so that they remain within 64 columns, in
> turn preventing generated ChangeLog entries from exceeding 72 columns.
> Typing `M-q' within a*vc-log*  buffer will suffice most of the time.

I wrote this message as well.

Re: master 8a39216ce92 3/3: elixir-ts-mode: Highlight more method definitions

[Po Lu]

Dmitry Gutov <dmitry@gutov.dev> writes:

> On 07/02/2024 04:45, Po Lu wrote:
>> Wilhelm, this commit message is too wide.  In your future contributions,
>> please fill commit messages so that they remain within 64 columns, in
>> turn preventing generated ChangeLog entries from exceeding 72 columns.
>> Typing `M-q' within a*vc-log*  buffer will suffice most of the time.
>
> I wrote this message as well.

Sorry for the noise.