From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Chris Moore" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: vc-svn crash - calling dolist on a string Date: Fri, 31 Aug 2007 15:40:26 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1462416848==" X-Trace: sea.gmane.org 1188567647 30498 80.91.229.12 (31 Aug 2007 13:40:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 31 Aug 2007 13:40:47 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 31 15:40:46 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IR6jo-0007GF-U4 for ged-emacs-devel@m.gmane.org; Fri, 31 Aug 2007 15:40:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IR6jo-0000P7-3a for ged-emacs-devel@m.gmane.org; Fri, 31 Aug 2007 09:40:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IR6ji-0000OR-L0 for emacs-devel@gnu.org; Fri, 31 Aug 2007 09:40:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IR6jh-0000OD-2R for emacs-devel@gnu.org; Fri, 31 Aug 2007 09:40:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IR6jg-0000OA-VA for emacs-devel@gnu.org; Fri, 31 Aug 2007 09:40:32 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IR6jg-0006cv-Jg for emacs-devel@gnu.org; Fri, 31 Aug 2007 09:40:32 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IR6jW-0002AJ-AR for emacs-pretest-bug@gnu.org; Fri, 31 Aug 2007 09:40:22 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IR6je-0006cH-9s for emacs-pretest-bug@gnu.org; Fri, 31 Aug 2007 09:40:32 -0400 Original-Received: from ug-out-1314.google.com ([66.249.92.172]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IR6jd-0006bx-Pu for emacs-pretest-bug@gnu.org; Fri, 31 Aug 2007 09:40:30 -0400 Original-Received: by ug-out-1314.google.com with SMTP id m4so314590uge for ; Fri, 31 Aug 2007 06:40:28 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; b=C7LCjX48ohJRK1dtQSr5fkQSdyndBvY4REQX0H6X550fqcIVAagIs50hvPDb7KzzYX6mCmJOAa65IEP6yM/ENy2gMm1Y460AJ1ruBN2WNjAyK6ag0AHQfivtINvYPfZG3xbKgmKERrYeU8YH1fzZ/Fx+LI3Z1y6QP+aNYwAyqTg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; b=H0B9f9D8xG0C4Tfo7byYXmJD/OEh6+Ob+828E3HFlNG3jpsQftl5OMKt8mkwRNczWolzI/rKRN07cUdXhQLvYVNLuH1RusmkTY3a2iMhwQSKsv45mLRRHZhA8P7jFcJvekmOcsxpo/eN5ztRU2GvWPqCO/O1yWeRanEcygow8gw= Original-Received: by 10.142.231.7 with SMTP id d7mr74956wfh.1188567626542; Fri, 31 Aug 2007 06:40:26 -0700 (PDT) Original-Received: by 10.143.4.2 with HTTP; Fri, 31 Aug 2007 06:40:26 -0700 (PDT) X-Google-Sender-Auth: bd5bb48d8c1da051 X-Detected-Kernel: Linux 2.6 (newer, 2) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77485 gmane.emacs.pretest.bugs:19674 Archived-At: --===============1462416848== Content-Type: multipart/alternative; boundary="----=_Part_9873_3317500.1188567626511" ------=_Part_9873_3317500.1188567626511 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline In GNU Emacs 22.1.50.3 (i686-pc-linux-gnu, GTK+ Version 2.10.11) of 2007-08-28 on trpaslik Windowing system distributor `The X.Org Foundation', version 11.0.70200000 configured using `configure '--with-gtk' '--prefix' '/usr/local' '--with-xpm' '--with-jpeg' '--with-png' '--with-gif'' The recent change to vc-svn.el seems to be a little wrong. vc-svn-diff does (dolist (f files) ... where files is its first argument. However, that first argument isn't always a list. See how it's called here: (defun vc-svn-diff-tree (dir &optional rev1 rev2) "Diff all files at and below DIR." (vc-svn-diff (file-name-as-directory dir) rev1 rev2)) I was visiting a svn-controlled source file and typed C-u C-x v = RET 567 RET, hoping to compare version 567 of the current source file with the version I was looking at, but instead got the above error. Checking with "C-x ESC ESC", I see that vc-version-diff wasn't called how I was expecting it to be. I see that what was called to get the error was: (vc-version-diff "/home/chris/programs/" "567" "") whereas what I would expect to see is: (vc-version-diff "/home/chris/programs/file.c" "567" "") Somehow the first RET I typed, to the "File or dir to diff (default visited file)" prompt didn't default to the visited file, but instead literally used the directory itself. ------=_Part_9873_3317500.1188567626511 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline In GNU Emacs 22.1.50.3 (i686-pc-linux-gnu, GTK+ Version 2.10.11)
 of 2007-08-28 on trpaslik
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
configured using `configure  '--with-gtk' '--prefix' '/usr/local' '--with-xpm' '--with-jpeg' '--with-png' '--with-gif''

The recent change to vc-svn.el seems to be a little wrong.  vc-svn-diff does (dolist (f files) ... where files is its first argument.  However, that first argument isn't always a list.  See how it's called here:

(defun vc-svn-diff-tree (dir &optional rev1 rev2)
  "Diff all files at and below DIR."
  (vc-svn-diff (file-name-as-directory dir) rev1 rev2))


I was visiting a svn-controlled source file and typed C-u C-x v = RET 567 RET, hoping to compare version 567 of the current source file with the version I was looking at, but instead got the above error.

Checking with "C-x ESC ESC", I see that vc-version-diff wasn't called how I was expecting it to be.  I see that what was called to get the error was:

(vc-version-diff "/home/chris/programs/" "567" "")

whereas what I would expect to see is:

(vc-version-diff "/home/chris/programs/file.c" "567" "")

Somehow the first RET I typed, to the "File or dir to diff (default visited file)" prompt didn't default to the visited file, but instead literally used the directory itself.
------=_Part_9873_3317500.1188567626511-- --===============1462416848== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1462416848==--