From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Wed, 27 Nov 2024 15:02:38 -0500 Message-ID: References: <9c2c262e-320d-139b-cf6a-5b93cd98eb8b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19111"; mail-complaints-to="usenet@ciao.gmane.io" To: "Jim Porter" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 27 21:03:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGOFv-0004kk-Ss for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Nov 2024 21:03:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGOFg-0000if-Q4; Wed, 27 Nov 2024 15:03:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGOFe-0000iW-85 for emacs-devel@gnu.org; Wed, 27 Nov 2024 15:03:06 -0500 Original-Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGOFZ-00074V-UE for emacs-devel@gnu.org; Wed, 27 Nov 2024 15:03:03 -0500 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.stl.internal (Postfix) with ESMTP id C4BAE1140122; Wed, 27 Nov 2024 15:02:58 -0500 (EST) Original-Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-12.internal (MEProxy); Wed, 27 Nov 2024 15:02:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1732737778; x=1732824178; bh=K9Mhp7Ji3vFO0FpnqTszY2btr7jRJcqTLaQ+2+cT8Q8=; b= Qm610d0XXI8w7fK/f3DZhzWex7uDk3+xq1gPfzKkRxeMyfPTDbJ4SoXtHG1FQJcq jec77hPUR2FVuMVaZtughubfoYHxhb4SuChysBIlVUifNLPVQohIh8zRqRLkwA1m KiGoKQYoSnarMeTngsjNIb/SsgPRS7kkHKU0Dgu8C7qhBCwgjUJC8VqKuIsBXMVw nSxwwUqWhL3Ff5NdFCOgCWNCNv2JQvKDzq1jJl25usPBeRb/mqo2zfWP6NZl1F/a kjb7TeyxrNjEIMzbqX6XOQ1okIGSxMaEuYKAXeFjQczl8NAgAbcj5kHUhWX22APv h0xPhUb+T3b+fxB/h/+MVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1732737778; x=1732824178; bh=K 9Mhp7Ji3vFO0FpnqTszY2btr7jRJcqTLaQ+2+cT8Q8=; b=N/2s31MaKlxC4ZrgJ g6VPFT4V6g6dXdKhlnBo/kYS8E0nirYYszbYpxdMHylsiqaEYkEwnJNHpl+0zCW2 uXuWF4SkpTwo8RY92HsovGpXinKeL/QOCs+/AkGlpNqigExalr/HhZTELFV0nAlV t4m+Jk710PUEIehIP8SBfLbH8akn3j7U1jSnSwW/oJXtikQhxIN5h8uhLaNFjGn6 H3/HQA/0rtdj9QCrNqyQwoLXX7pJx/l00k370QN5TFreK3EVaf16MlY7SofFB0gb VJHcwIfAjV4cKAbDrvwh/4gB0iZT0xjS3Rt+M9aM98FsV5pNJ8XSk6Bp9MhQXgv4 lRbSg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeelgdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefoggffhf fvkfgjfhfutgfgsehtjeertdertdejnecuhfhrohhmpefuvggsrghsthhijohnucfoohhn vogruceoshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmqeenucggtffrrg htthgvrhhnpedtgffhvddvveetgeffteetffehueejtedugedvheejudfgudegudeigfet jeehueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvggsrghsthhirghnsehsvggsrghsmhhonhhirgdrtghomhdpnhgspghrtghpthhtohep vddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhpohhrthgvrhgsuhhgshesgh hmrghilhdrtghomhdprhgtphhtthhopegvmhgrtghsqdguvghvvghlsehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: iab2c46da:Fastmail Original-Received: by mailuser.phl.internal (Postfix, from userid 501) id 636321C20067; Wed, 27 Nov 2024 15:02:58 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <9c2c262e-320d-139b-cf6a-5b93cd98eb8b@gmail.com> Received-SPF: pass client-ip=202.12.124.150; envelope-from=sebastian@sebasmonia.com; helo=fout-b7-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325787 Archived-At: On Sat, Nov 23, 2024, at 2:12 PM, Jim Porter wrote: > I think this looks good overall. Just one thought: instead of requiring > users to manually undo sorting when killing/yanking, what if we had > 'eww-bookmark-kill' and 'eww-yank-bookmark' prompt the user to ask if > they want to undo the sorting first? The problem is, when yanking, do you yank the bookmark to the current position on the table? or the one where you will end up after undoing the sort? That (and a few other cases like it) made me opt for having the user disable sorting explicitly. Or even considering just not sorting at all, although it seems like a useful feature for all cases but the kill/yank scenario.