From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Wed, 10 Apr 2019 10:36:27 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1B54B620E9755ABE6C337F76" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109874"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 19:37:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEH9q-000SO1-Mp for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 19:37:10 +0200 Original-Received: from localhost ([127.0.0.1]:35122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEH9p-0001ML-Mu for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 13:37:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEH9E-0001MF-M3 for emacs-devel@gnu.org; Wed, 10 Apr 2019 13:36:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEH9D-0001Mx-Fv for emacs-devel@gnu.org; Wed, 10 Apr 2019 13:36:32 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43634) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEH9C-0001ML-Ul for emacs-devel@gnu.org; Wed, 10 Apr 2019 13:36:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4FD841616A3; Wed, 10 Apr 2019 10:36:29 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ahbkVhyyLm3e; Wed, 10 Apr 2019 10:36:28 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 240731616A4; Wed, 10 Apr 2019 10:36:28 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SglowvqCKBmw; Wed, 10 Apr 2019 10:36:28 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 02676161648; Wed, 10 Apr 2019 10:36:27 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235232 Archived-At: This is a multi-part message in MIME format. --------------1B54B620E9755ABE6C337F76 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 4/10/19 6:12 AM, Andy Moreton wrote: > this breaks out-of-tree builds, as make tries to use > /path/to/emacs/admin/charsets/Makefile rather than the correct path > /admin/charsets/Makefile: Sorry, my tests didn't include a complete out-of-tree bootstrap. I installed the attached patch to fix that problem, along with the problem's other instance. The other -C changes should be OK. You're correct that some of the -C changes were unrelated to the original patch. Still, they make the Makefile more consistent and I'd like to keep the ones that work. PS. I'd like Emacs to switch to a nonrecursive 'make' process, as this subsidiary $(MAKE) -C business is for the birds. We've made the switch for other GNU projects and it's been a win. This is not a new idea; see: Miller P. Recursive Make considered harmful. AAUGN J of AUUG. 1998;19(1):14-25. https://grosskurth.ca/bib/1997/miller.pdf --------------1B54B620E9755ABE6C337F76 Content-Type: text/x-patch; name="0001-Fix-MAKE-C-for-out-of-tree-bootstraps.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-MAKE-C-for-out-of-tree-bootstraps.patch" >From d2255c6065b0bc3949d494edf8864a2bd13918f3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 10 Apr 2019 10:06:21 -0700 Subject: [PATCH] Fix $(MAKE) -C for out-of-tree bootstraps Problem reported by Andy Moreton in: https://lists.gnu.org/r/emacs-devel/2019-04/msg00359.html * src/Makefile.in (${charsets}, $(lispsource)/loaddefs.el): Revert incorrect changes to $(MAKE) -C invocations when the target is in the source tree not the build tree. --- src/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.in b/src/Makefile.in index f8a2ffadc2..6d6308fde6 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -533,7 +533,7 @@ ${lispintdir}/cp51932.el ${lispintdir}/eucjp-ms.el: charsets = ${top_srcdir}/admin/charsets/charsets.stamp ${charsets}: FORCE - $(MAKE) -C $(dir $@) all + $(MAKE) -C ../admin/charsets all charscript = ${lispintdir}/charscript.el ${charscript}: FORCE @@ -765,7 +765,7 @@ VCSWITNESS = $(lispsource)/loaddefs.el: $(VCSWITNESS) | \ bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp) - $(MAKE) -C $(dir $@) autoloads EMACS="$(bootstrap_exe)" + $(MAKE) -C ../lisp autoloads EMACS="$(bootstrap_exe)" ## Dump an Emacs executable named bootstrap-emacs containing the ## files from loadup.el in source form. -- 2.20.1 --------------1B54B620E9755ABE6C337F76--