From: Paul Eggert <eggert@cs.ucla.edu>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Wed, 10 Apr 2019 10:36:27 -0700 [thread overview]
Message-ID: <a7fb5e33-7fe9-d32a-a8df-7d1f50a683b1@cs.ucla.edu> (raw)
In-Reply-To: <vz1ef6a3sy3.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 4/10/19 6:12 AM, Andy Moreton wrote:
> this breaks out-of-tree builds, as make tries to use
> /path/to/emacs/admin/charsets/Makefile rather than the correct path
> <builddir>/admin/charsets/Makefile:
Sorry, my tests didn't include a complete out-of-tree bootstrap. I
installed the attached patch to fix that problem, along with the
problem's other instance. The other -C changes should be OK. You're
correct that some of the -C changes were unrelated to the original
patch. Still, they make the Makefile more consistent and I'd like to
keep the ones that work.
PS. I'd like Emacs to switch to a nonrecursive 'make' process, as this
subsidiary $(MAKE) -C business is for the birds. We've made the switch
for other GNU projects and it's been a win. This is not a new idea; see:
Miller P. Recursive Make considered harmful. AAUGN J of AUUG.
1998;19(1):14-25. https://grosskurth.ca/bib/1997/miller.pdf
[-- Attachment #2: 0001-Fix-MAKE-C-for-out-of-tree-bootstraps.patch --]
[-- Type: text/x-patch, Size: 1319 bytes --]
From d2255c6065b0bc3949d494edf8864a2bd13918f3 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 10 Apr 2019 10:06:21 -0700
Subject: [PATCH] Fix $(MAKE) -C for out-of-tree bootstraps
Problem reported by Andy Moreton in:
https://lists.gnu.org/r/emacs-devel/2019-04/msg00359.html
* src/Makefile.in (${charsets}, $(lispsource)/loaddefs.el):
Revert incorrect changes to $(MAKE) -C invocations when the
target is in the source tree not the build tree.
---
src/Makefile.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.in b/src/Makefile.in
index f8a2ffadc2..6d6308fde6 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -533,7 +533,7 @@ ${lispintdir}/cp51932.el ${lispintdir}/eucjp-ms.el:
charsets = ${top_srcdir}/admin/charsets/charsets.stamp
${charsets}: FORCE
- $(MAKE) -C $(dir $@) all
+ $(MAKE) -C ../admin/charsets all
charscript = ${lispintdir}/charscript.el
${charscript}: FORCE
@@ -765,7 +765,7 @@ VCSWITNESS =
$(lispsource)/loaddefs.el: $(VCSWITNESS) | \
bootstrap-emacs$(EXEEXT) $(bootstrap_pdmp)
- $(MAKE) -C $(dir $@) autoloads EMACS="$(bootstrap_exe)"
+ $(MAKE) -C ../lisp autoloads EMACS="$(bootstrap_exe)"
## Dump an Emacs executable named bootstrap-emacs containing the
## files from loadup.el in source form.
--
2.20.1
next prev parent reply other threads:[~2019-04-10 17:36 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:21 CHECK_STRUCTS/dmpstruct.h mechanism is broken Alan Mackenzie
2019-02-28 20:55 ` Eli Zaretskii
2019-02-28 20:59 ` Alan Mackenzie
2019-03-01 7:31 ` Eli Zaretskii
2019-03-01 13:09 ` Alan Mackenzie
2019-03-05 2:17 ` Paul Eggert
2019-04-09 22:47 ` Paul Eggert
2019-04-10 13:12 ` Andy Moreton
2019-04-10 14:59 ` Andy Moreton
2019-04-10 17:36 ` Paul Eggert [this message]
2019-04-10 19:26 ` Andy Moreton
2019-04-10 19:43 ` Daniel Colascione
2019-04-10 16:22 ` Alan Mackenzie
2019-04-10 18:05 ` Paul Eggert
2019-04-10 19:45 ` Alan Mackenzie
2019-04-10 20:11 ` Daniel Colascione
2019-04-11 4:11 ` Paul Eggert
2019-04-15 12:36 ` Andy Moreton
2019-04-15 15:32 ` Andy Moreton
2019-04-15 15:53 ` Paul Eggert
2019-04-11 13:13 ` Stefan Monnier
2019-04-11 4:17 ` Paul Eggert
2019-04-10 18:47 ` Daniel Colascione
2019-04-10 18:58 ` Paul Eggert
2019-04-10 19:02 ` Daniel Colascione
2019-04-10 19:22 ` Eli Zaretskii
2019-04-11 9:35 ` Robert Pluim
2019-04-11 18:31 ` Paul Eggert
2019-04-11 19:15 ` Eli Zaretskii
2019-04-11 22:13 ` Daniel Colascione
2019-04-12 6:44 ` Eli Zaretskii
2019-04-11 22:23 ` Paul Eggert
2019-04-11 22:26 ` Daniel Colascione
2019-04-11 22:38 ` Paul Eggert
2019-04-12 6:39 ` Eli Zaretskii
2019-04-12 19:40 ` Paul Eggert
2019-04-13 9:36 ` Eli Zaretskii
2019-04-14 2:52 ` Paul Eggert
2019-04-12 12:21 ` Andy Moreton
2019-04-12 13:37 ` Alan Mackenzie
2019-04-12 13:55 ` Eli Zaretskii
2019-04-12 13:58 ` Noam Postavsky
2019-04-13 14:06 ` Alan Mackenzie
2019-04-13 14:46 ` About ./configure --cache-file (WAS: CHECK_STRUCTS/dmpstruct.h mechanism is broken.) Noam Postavsky
2019-04-14 2:44 ` Paul Eggert
2019-04-14 3:26 ` Daniel Colascione
2019-04-14 3:49 ` Noam Postavsky
2019-04-14 9:45 ` Alan Mackenzie
2019-04-14 14:08 ` Eli Zaretskii
2019-04-14 14:44 ` Noam Postavsky
2019-04-14 14:53 ` Eli Zaretskii
2019-04-13 8:11 ` CHECK_STRUCTS/dmpstruct.h mechanism is broken Achim Gratz
2019-04-14 2:52 ` Paul Eggert
2019-04-14 3:28 ` Daniel Colascione
2019-04-14 7:22 ` Achim Gratz
2019-04-14 23:29 ` Paul Eggert
2019-04-15 11:31 ` Alan Mackenzie
2019-04-15 14:14 ` Paul Eggert
2019-04-15 18:11 ` Richard Stallman
2019-04-16 18:10 ` Paul Eggert
2019-04-22 2:18 ` Richard Stallman
2019-04-22 4:07 ` Paul Eggert
2019-04-23 1:41 ` Richard Stallman
2019-04-23 3:48 ` Paul Eggert
2019-04-23 6:25 ` Eli Zaretskii
2019-04-23 16:28 ` Paul Eggert
2019-04-23 17:08 ` Eli Zaretskii
2019-04-23 17:19 ` Stefan Monnier
2019-04-24 2:26 ` Richard Stallman
2019-04-15 3:36 ` Richard Stallman
2019-04-15 5:30 ` Paul Eggert
2019-04-11 19:55 ` Achim Gratz
2019-04-11 22:10 ` Daniel Colascione
2019-04-11 22:47 ` Paul Eggert
2019-04-11 22:44 ` Paul Eggert
2019-04-12 17:02 ` Daniele Nicolodi
2019-04-13 8:26 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7fb5e33-7fe9-d32a-a8df-7d1f50a683b1@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).