From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [patch: first impression] Date: Tue, 11 Oct 2022 15:17:55 +0300 Message-ID: References: <87fsgyuyh7.fsf@mat.ucm.es> <87fsg9crz3.fsf@mat.ucm.es> <87ill4c18c.fsf@mat.ucm.es> <078c04cf-00ad-4104-5762-6b3b7832485c@yandex.ru> <87czbcaxve.fsf@mat.ucm.es> <87tu4naere.fsf@mat.ucm.es> <9bea31a0-c16e-aeed-cf22-a27760c229e2@yandex.ru> <871qrq9240.fsf@mat.ucm.es> <396309ef-2040-ec3c-af19-3fc6a0d587a0@yandex.ru> <87k05cw3ps.fsf@mat.ucm.es> <32439d3e-e40b-c2c2-5f5a-34785a1a5790@yandex.ru> <87v8os9o8q.fsf@mat.ucm.es> <877d177mri.fsf_-_@mat.ucm.es> <520c15a0-a82b-657f-c47f-8f030521980a@yandex.ru> <87fsfv1yau.fsf@mat.ucm.es> <43e67d5a-e3f4-3e7d-cd0e-819a08279d7e@yandex.ru> <877d16khai.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3651"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: emacs-devel@gnu.org, Arne Babenhauserheide To: Uwe Brauer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 15:43:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiFXh-0000m4-9S for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:43:33 +0200 Original-Received: from localhost ([::1]:48066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiFXg-00034z-4R for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:43:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiED3-0000OO-LC for emacs-devel@gnu.org; Tue, 11 Oct 2022 08:18:09 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:33457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiED1-0006Aw-Li for emacs-devel@gnu.org; Tue, 11 Oct 2022 08:18:09 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id a3so21376302wrt.0 for ; Tue, 11 Oct 2022 05:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=KlT33TX1Zp911RJKCJV3f6JjoEXonS/vVJTy/Q5Kz78=; b=lYc1+dcUFNxk8x2nvSSGsOWIEdeMTjOmu9GTCNXBEDgVrJLex3FcaPJDRHxDqNYAmS GYSFB9S1fOHBJgmW0UE9uxGaW5TGDnktGJq7XaxJQlZr2w9bgnNBFUm5nXbdqtsN38qA quLASJ6X9eDdJJJMopwe8+9PR10wlzOuZJNG8AY6FCAteSRuO/QK+PPYz1ghtcPTVGz0 xc9167SdtmMZSUTHAHpRZtaHrj6y/oBsZ9Z2etlPjJwL//I59YevvvoA/BsUB33QpJAF 0+aogxu2AvIKrAxHAyRkeFyRK8Ye6aSslZOJnHvzLcY+nyB+K1AUIbQfHWavyVRvWDq9 r9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KlT33TX1Zp911RJKCJV3f6JjoEXonS/vVJTy/Q5Kz78=; b=BgbZkc9xVT7NJu8TlaN7SQ/kXm4RigpzMlIy0g4CooKq6mxzLfgCFZ9t/DmWnZ0FH1 4oCDRXmiXkJj9Z5XQK4U2XX2Mgl7Ice9Iug5+xLXKBYRAhb92xjVlra02rXcWprzVOmo 0YkAHTm7F/UdcFxnTdDjwZ8beDt2p9UdJ8ODQcuVlbvam7ghMUguY55shq+Uac7sEu+i Eh1qJzy8iblDWdaVzY4l7WHXXMWwyZd8XBQ6hy9twVaEeAMVLaqEoPof9IlE9N0clgE2 CiRF9gJZ2eznZMK0+5RH1vGhUJG4CarAJ+e0dbp8GNPJnEPJmW0yJ8/dHwlQv4fGdlJa /enQ== X-Gm-Message-State: ACrzQf0QuZazdTcFu3+9uuUTK1OlN6yf62PsS/5HMT/0i/Bid9Urcpcp v4/fNBbUYLhR3nutJwEOY5w= X-Google-Smtp-Source: AMsMyM6q1W1DTYwtwIG9l+JJhrQ+Kp2tY05OppfWPDAdMRS0J/CgXta1BJX9j+CpPScYWF/BevDiwA== X-Received: by 2002:a05:6000:144d:b0:231:5786:f763 with SMTP id v13-20020a056000144d00b002315786f763mr2344351wrx.313.1665490677398; Tue, 11 Oct 2022 05:17:57 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id da5-20020a056000408500b00225239d9265sm11881083wrb.74.2022.10.11.05.17.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:17:57 -0700 (PDT) Content-Language: en-US In-Reply-To: <877d16khai.fsf@mat.ucm.es> Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.934, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297482 Archived-At: On 11.10.2022 09:25, Uwe Brauer wrote: > Do you mean: the not committed hunks are shelved? Shelved before the commit is made and restored at the end, see the patch. > But now that you mention it, mercurial also supports interactive > shelving (so to speak the inverse operation to interactive commit. I am > not sure that git has that feature). > > So couldn't that also be included? That would be really great, since commit-patch does not support it. > > The binding could be either C-u vc-next-action or > something like this (just to explain the idea) > > (defun toggle-commit-or-shelve-interactively () > (interactive) > (with-output-to-temp-buffer "vc-list-buffer" > (princ "List of functions\n") > (princ "1: commit interactively\n") > (princ "2: shelv interactively \n")) > (let ((ch (string-to-char (read-string "Which choice: 1: 2: ")))) > (call-interactively (cond ((eql ch ?1) #'vc-commit-interactively) > ((eql ch ?2) #'vc-shelve-interactively) > (t (error 'args-out-of-range '(1 2 ch)))))) > (kill-buffer "vc-list-buffer")) I'm not sure where to plug functionality like that. > I will try to test this later (I presume I don't need to recompile the > whole emacs 😉; just kidding) FWIW, you don't really have to recompile Emacs. You could `C-M-x` on the new definitions instead after applying either of the patches.