From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Sat, 19 Oct 2024 16:51:51 -0400 Message-ID: References: <86y12tycdy.fsf@gnu.org> <87v7xvh4rd.fsf@sebasmonia.com> <87froygjfc.fsf@sebasmonia.com> <2205bb4b-2a4a-4480-acd9-2a18e71ac5e5@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22298"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Eli Zaretskii" , jporterbugs@gmail.com, emacs-devel@gnu.org To: "Adam Porter" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 19 22:53:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2GRj-0005eK-Rt for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Oct 2024 22:53:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2GQr-0001Ur-9n; Sat, 19 Oct 2024 16:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2GQp-0001Uf-W8 for emacs-devel@gnu.org; Sat, 19 Oct 2024 16:52:16 -0400 Original-Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2GQo-00064E-1h; Sat, 19 Oct 2024 16:52:15 -0400 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id 66A71138021D; Sat, 19 Oct 2024 16:52:12 -0400 (EDT) Original-Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-12.internal (MEProxy); Sat, 19 Oct 2024 16:52:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1729371132; x=1729457532; bh=jJIPwr3RH4a6ux0Quf/Ys4/4NxzCNQb+ oJvFClD+DaI=; b=KxEToa9t7G84wjLYFOLzU0uFIcaTm4aK/ldXGtinB1QFPH0n 4m0s605CaT+j54anjzWd6B7KhcclwDMCorMg7YeqRk4MAL7r+KEGFTJGpxJ7h7t8 YweVyym2dkKT9wQ74BVWUDytwH3YmChDDytiZT0HkPHEwfLKPVFc6edWu8Ss3n2k RlJ0+g89+FnxYbqApgnV+gd1asgkFFE4mG2sO0jHFOUstMm+qrg4QPX5IbWO8I+I JEJ/3+QuCWB84w2RU8Vk/hz/Lfrnc379GaNhq2DkBAjUQ2Fp8Kng/+Xh04ZlRY9M eJBgEJXPxsXf26K2Q02AhoKVDxtySdcelKFWKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729371132; x= 1729457532; bh=jJIPwr3RH4a6ux0Quf/Ys4/4NxzCNQb+oJvFClD+DaI=; b=l WJVqnrVX4WX4gLOX7VFWeSE/5QSMbz3EP2ZfWR/n2DT8XLEEOhvOHyVMbmrkcDpU 8mbOX9piQ19j6LbYRLeUmCxPvD+ZXoz6Pu1fL8ECwMTfuc4KE81vrkGxDDFMglHY xHImrCwLN41/qqbcuBZCuCY4z5ymSCJgsfhiZYBjka2/UMlm7OEqTOCFqHEWc+P7 zCyLvLMkDnurVmEainzv10vnoK0ldjpwsdCZ3i0s2l0ABy7PZdSJspXwLxmK3Onb qL9RjuHLQLK9f3JoX2GIQrlyUhwodOOiiXD0+Y+pIktPirw26CpeFwtFLyYcYkCW JX5BCIYWzP9TfvLSK4gCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehhedgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepufgvsggrshhtihojnhcuofhonhovrgcuoehsvggsrghsthhirghnse hsvggsrghsmhhonhhirgdrtghomheqnecuggftrfgrthhtvghrnhepieetledtgedtleff gfdtveeugeetvdejleejudfhhedvgfdtheeftefguedtgedtnecuffhomhgrihhnpehsvg gsrghsmhhonhhirgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehsvggsrghsthhirghnsehsvggsrghsmhhonhhirgdrtghomhdpnh gspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprggurghm segrlhhphhgrphgrphgrrdhnvghtpdhrtghpthhtohepjhhpohhrthgvrhgsuhhgshesgh hmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthho pegvmhgrtghsqdguvg X-ME-Proxy: Feedback-ID: iab2c46da:Fastmail Original-Received: by mailuser.phl.internal (Postfix, from userid 501) id 033BB1C20066; Sat, 19 Oct 2024 16:52:12 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: pass client-ip=103.168.172.145; envelope-from=sebastian@sebasmonia.com; helo=fout-a2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324680 Archived-At: I just realized that I sent this only to Adam instead of the mailing list.=20 My assignment did come through, and I still think there's value in merging the current patch (without auto-reverting). On Thu, Oct 17, 2024, at 10:37 AM, Sebasti=C3=A1n Mon=C3=ADa wrote: > Adam Porter writes: >=20 > > On 10/14/24 21:59, Sebasti=C3=A1n Mon=C3=ADa wrote: > >> I was looking into it, we "just" need a good 'buffer-stale-function= '. > >> All I could think of was to store the list used to populate the vta= ble > >> in a buffer-local variable, and check if the list has changed? > > > > AFAIK it's generally good to avoid adding more buffer-local variable= s, > > as their presence has a performance penalty in general. >=20 > Noted! >=20 > > Updating a buffer list buffer automatically could be done by hooking > > into the machinery that renders a single EWW buffer and having it > > update a buffer list buffer if one exists. But I guess that wouldn't > > work exactly like `auto-revert-mode` and `buffer-stale-function`. >=20 > That same machinery could trigger auto-revert by marking the "buffer l= ist" > buffer stale. >=20 > > I don't mean to say what you should do; just throwing out some ideas= . :) >=20 > And it is much appreciated! :) >=20 > I don't think we should hold on merging this for auto-reverting though. > The patch is big enough as it is. > IMHO. >=20 >=20 > PS: still can't merge as my assignment didn't come through. >=20 > --=20 > Sebasti=C3=A1n Mon=C3=ADa > https://site.sebasmonia.com/