From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Add systemd socket launching support Date: Tue, 26 Apr 2016 09:15:10 -0700 Organization: UCLA Computer Science Department Message-ID: References: <871t6do8w1.fsf@mattleach.net> <87inzkrs8c.fsf@mattleach.net> <5713224F.9040602@cs.ucla.edu> <87h9f0ealq.fsf@mattleach.net> <57147449.4060307@cs.ucla.edu> <874maun0el.fsf@mattleach.net> <87zisg91an.fsf@mattleach.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------0B4D691C9895E78A9D709172" X-Trace: ger.gmane.org 1461687361 16270 80.91.229.3 (26 Apr 2016 16:16:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 16:16:01 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Matthew Leach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 18:15:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1av5eS-0007fU-1W for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 18:15:52 +0200 Original-Received: from localhost ([::1]:38671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5eR-000390-8p for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 12:15:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5dt-00034o-Av for emacs-devel@gnu.org; Tue, 26 Apr 2016 12:15:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av5dp-0004G2-7f for emacs-devel@gnu.org; Tue, 26 Apr 2016 12:15:17 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5do-0004Fs-Vd for emacs-devel@gnu.org; Tue, 26 Apr 2016 12:15:13 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BAA6916120A; Tue, 26 Apr 2016 09:15:11 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sbuzHGbTe7qk; Tue, 26 Apr 2016 09:15:10 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CF5AD16125C; Tue, 26 Apr 2016 09:15:10 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XTj5fiTEz-JT; Tue, 26 Apr 2016 09:15:10 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B1D7416120A; Tue, 26 Apr 2016 09:15:10 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87zisg91an.fsf@mattleach.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203343 Archived-At: This is a multi-part message in MIME format. --------------0B4D691C9895E78A9D709172 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/26/2016 02:17 AM, Matthew Leach wrote: > Should I send in a patch to fix this or are you OK doing it? I should do it since I introduced the bug :-(. Thanks for reporting it. I installed the attached; does it work for you? (Can you write a test case for this sort of bug, something 'make check' could check?) --------------0B4D691C9895E78A9D709172 Content-Type: application/x-patch; name="0001-Fix-socketd-fd-startup-bug-that-I-introduced.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-socketd-fd-startup-bug-that-I-introduced.patch" RnJvbSAwOWUxMjkzOWRhN2I0MDhmNGUxMjRjMDUwNDhjMzYxYWVkOTA4YjJkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDI2IEFwciAyMDE2IDA5OjEyOjE0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRml4IHNvY2tldGQgZmQgc3RhcnR1cCBidWcgdGhhdCBJIGludHJvZHVjZWQKClByb2Js ZW0gcmVwb3J0ZWQgYnkgTWF0dGhldyBMZWFjaCBpbjoKaHR0cDovL2xpc3RzLmdudS5vcmcv YXJjaGl2ZS9odG1sL2VtYWNzLWRldmVsLzIwMTYtMDQvbXNnMDA3NzguaHRtbAoqIHNyYy9l bWFjcy5jIChtYWluKTogSW5kaWNhdGUgbW9yZSBjbGVhcmx5IHRoZSBjb3VwbGluZyBiZXR3 ZWVuCnRoZSAtLWRhZW1vbiBvcHRpb24gYW5kIGluaXRfcHJvY2Vzc19lbWFjcy4KKiBzcmMv bGlzcC5oOiBBZGp1c3QgdG8gQVBJIGNoYW5nZXMuCiogc3JjL3Byb2Nlc3MuYyAoc2V0X2V4 dGVybmFsX3NvY2tldF9kZXNjcmlwdG9yKToKUmVtb3ZlLCByZXBsYWNpbmcgYnkgLi4uCihp bml0X3Byb2Nlc3NfZW1hY3MpOiAuLi4gcGFzc2luZyB0aGUgc29ja2V0IEZEIGhlcmUgaW5z dGVhZC4KQWxsIHVzZXMgY2hhbmdlZC4KLS0tCiBzcmMvZW1hY3MuYyAgIHwgIDcgKysrKyst LQogc3JjL2xpc3AuaCAgICB8ICAzICstLQogc3JjL3Byb2Nlc3MuYyB8IDIyICsrKysrKysr LS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTgg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2VtYWNzLmMgYi9zcmMvZW1hY3MuYwpp bmRleCBhNzM4YmFjLi5hN2NiYjMyIDEwMDY0NAotLS0gYS9zcmMvZW1hY3MuYworKysgYi9z cmMvZW1hY3MuYwpAQCAtOTcxLDYgKzk3MSw5IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoq YXJndikKICAgdzMyX2RhZW1vbl9ldmVudCA9IE5VTEw7CiAjZW5kaWYKIAorCisgIGludCBz b2NrZmQgPSAtMTsKKwogICBpZiAoYXJnbWF0Y2ggKGFyZ3YsIGFyZ2MsICItZGFlbW9uIiwg Ii0tZGFlbW9uIiwgNSwgTlVMTCwgJnNraXBfYXJncykKICAgICAgIHx8IGFyZ21hdGNoIChh cmd2LCBhcmdjLCAiLWRhZW1vbiIsICItLWRhZW1vbiIsIDUsICZkbmFtZV9hcmcsICZza2lw X2FyZ3MpKQogICAgIHsKQEAgLTEwMTYsNyArMTAxOSw3IEBAIG1haW4gKGludCBhcmdjLCBj aGFyICoqYXJndikKICAgICAgIGVsc2UgaWYgKHN5c3RlbWRfc29ja2V0ID09IDEKIAkgICAg ICAgJiYgKDAgPCBzZF9pc19zb2NrZXQgKFNEX0xJU1RFTl9GRFNfU1RBUlQsCiAJCQkJICAg ICBBRl9VTlNQRUMsIFNPQ0tfU1RSRUFNLCAxKSkpCi0gICAgICAgIHNldF9leHRlcm5hbF9z b2NrZXRfZGVzY3JpcHRvciAoU0RfTElTVEVOX0ZEU19TVEFSVCk7CisJc29ja2ZkID0gU0Rf TElTVEVOX0ZEU19TVEFSVDsKICNlbmRpZiAvKiBIQVZFX0xJQlNZU1RFTUQgKi8KIAogI2lm bmRlZiBEQUVNT05fTVVTVF9FWEVDCkBAIC0xNTc1LDcgKzE1NzgsNyBAQCBVc2luZyBhbiBF bWFjcyBjb25maWd1cmVkIHdpdGggLS13aXRoLXgtdG9vbGtpdD1sdWNpZCBkb2VzIG5vdCBo YXZlIHRoaXMgcHJvYmxlbQogICAvKiBUaGlzIGNhbiBjcmVhdGUgYSB0aHJlYWQgdGhhdCBt YXkgY2FsbCBnZXRlbnYsIHNvIGl0IG11c3QgZm9sbG93CiAgICAgIGFsbCBjYWxscyB0byBw dXRlbnYgYW5kIHNldGVudi4gIEFsc28sIHRoaXMgc2V0cyB1cAogICAgICBhZGRfa2V5Ym9h cmRfd2FpdF9kZXNjcmlwdG9yLCB3aGljaCBpbml0X2Rpc3BsYXkgdXNlcy4gICovCi0gIGlu aXRfcHJvY2Vzc19lbWFjcyAoKTsKKyAgaW5pdF9wcm9jZXNzX2VtYWNzIChzb2NrZmQpOwog CiAgIGluaXRfa2V5Ym9hcmQgKCk7CS8qIFRoaXMgdG9vIG11c3QgcHJlY2VkZSBpbml0X3N5 c19tb2Rlcy4gICovCiAgIGlmICghbm9uaW50ZXJhY3RpdmUpCmRpZmYgLS1naXQgYS9zcmMv bGlzcC5oIGIvc3JjL2xpc3AuaAppbmRleCBjNmY4YmI4Li4xZmM2MTMwIDEwMDY0NAotLS0g YS9zcmMvbGlzcC5oCisrKyBiL3NyYy9saXNwLmgKQEAgLTQxODEsMTAgKzQxODEsOSBAQCBl eHRlcm4gdm9pZCBkZWxldGVfa2V5Ym9hcmRfd2FpdF9kZXNjcmlwdG9yIChpbnQpOwogZXh0 ZXJuIHZvaWQgYWRkX2dwbV93YWl0X2Rlc2NyaXB0b3IgKGludCk7CiBleHRlcm4gdm9pZCBk ZWxldGVfZ3BtX3dhaXRfZGVzY3JpcHRvciAoaW50KTsKICNlbmRpZgotZXh0ZXJuIHZvaWQg aW5pdF9wcm9jZXNzX2VtYWNzICh2b2lkKTsKK2V4dGVybiB2b2lkIGluaXRfcHJvY2Vzc19l bWFjcyAoaW50KTsKIGV4dGVybiB2b2lkIHN5bXNfb2ZfcHJvY2VzcyAodm9pZCk7CiBleHRl cm4gdm9pZCBzZXR1cF9wcm9jZXNzX2NvZGluZ19zeXN0ZW1zIChMaXNwX09iamVjdCk7Ci1l eHRlcm4gdm9pZCBzZXRfZXh0ZXJuYWxfc29ja2V0X2Rlc2NyaXB0b3IgKGludCk7CiAKIC8q IERlZmluZWQgaW4gY2FsbHByb2MuYy4gICovCiAjaWZuZGVmIERPU19OVApkaWZmIC0tZ2l0 IGEvc3JjL3Byb2Nlc3MuYyBiL3NyYy9wcm9jZXNzLmMKaW5kZXggYTIyMmE1Yi4uMGRmZTE2 MiAxMDA2NDQKLS0tIGEvc3JjL3Byb2Nlc3MuYworKysgYi9zcmMvcHJvY2Vzcy5jCkBAIC0y NjcsNyArMjY3LDEwIEBAIHN0YXRpYyBpbnQgbWF4X3Byb2Nlc3NfZGVzYzsKIC8qIFRoZSBs YXJnZXN0IGRlc2NyaXB0b3IgY3VycmVudGx5IGluIHVzZSBmb3IgaW5wdXQ7IC0xIGlmIG5v bmUuICAqLwogc3RhdGljIGludCBtYXhfaW5wdXRfZGVzYzsKIAotLyogVGhlIGRlc2NyaXB0 b3Igb2YgYW55IHNvY2tldCBwYXNzZWQgdG8gRW1hY3M7IC0xIGlmIG5vbmUuICovCisvKiBT ZXQgdGhlIGV4dGVybmFsIHNvY2tldCBkZXNjcmlwdG9yIGZvciBFbWFjcyB0byB1c2Ugd2hl bgorICAgYG1ha2UtbmV0d29yay1wcm9jZXNzJyBpcyBjYWxsZWQgd2l0aCBhIG5vbi1uaWwK KyAgIGA6dXNlLWV4dGVybmFsLXNvY2tldCcgb3B0aW9uLiAgVGhlIHZhbHVlIHNob3VsZCBi ZSBlaXRoZXIgLTEsIG9yCisgICB0aGUgZmlsZSBkZXNjcmlwdG9yIG9mIGEgc29ja2V0IHRo YXQgaXMgYWxyZWFkeSBib3VuZC4gICovCiBzdGF0aWMgaW50IGV4dGVybmFsX3NvY2tfZmQ7 CiAKIC8qIEluZGV4ZWQgYnkgZGVzY3JpcHRvciwgZ2l2ZXMgdGhlIHByb2Nlc3MgKGlmIGFu eSkgZm9yIHRoYXQgZGVzY3JpcHRvci4gICovCkBAIC03NzMzLDI0ICs3NzM2LDE0IEBAIGNh dGNoX2NoaWxkX3NpZ25hbCAodm9pZCkKIH0KICNlbmRpZgkvKiBzdWJwcm9jZXNzZXMgKi8K IAotLyogU2V0IHRoZSBleHRlcm5hbCBzb2NrZXQgZGVzY3JpcHRvciBmb3IgRW1hY3MgdG8g dXNlIHdoZW4KLSAgIGBtYWtlLW5ldHdvcmstcHJvY2VzcycgaXMgY2FsbGVkIHdpdGggYSBu b24tbmlsCi0gICBgOnVzZS1leHRlcm5hbC1zb2NrZXQnIG9wdGlvbi4gIFRoZSBmZCBzaG91 bGQgaGF2ZSBiZWVuIGNoZWNrZWQgdG8KLSAgIGVuc3VyZSBpdCBpcyBhIHZhbGlkIHNvY2tl dCBhbmQgaXMgYWxyZWFkeSBib3VuZC4gICovCi12b2lkCi1zZXRfZXh0ZXJuYWxfc29ja2V0 X2Rlc2NyaXB0b3IgKGludCBmZCkKLXsKLSAgZXh0ZXJuYWxfc29ja19mZCA9IGZkOwotfQot CiAMCiAvKiBUaGlzIGlzIG5vdCBjYWxsZWQgImluaXRfcHJvY2VzcyIgYmVjYXVzZSB0aGF0 IGlzIHRoZSBuYW1lIG9mIGEKICAgIE1hY2ggc3lzdGVtIGNhbGwsIHNvIGl0IHdvdWxkIGNh dXNlIHByb2JsZW1zIG9uIERhcndpbiBzeXN0ZW1zLiAgKi8KIHZvaWQKLWluaXRfcHJvY2Vz c19lbWFjcyAodm9pZCkKK2luaXRfcHJvY2Vzc19lbWFjcyAoaW50IHNvY2tmZCkKIHsKICNp ZmRlZiBzdWJwcm9jZXNzZXMKLSAgcmVnaXN0ZXIgaW50IGk7CisgIGludCBpOwogCiAgIGlu aGliaXRfc2VudGluZWxzID0gMDsKIApAQCAtNzc3Miw3ICs3NzY1LDggQEAgaW5pdF9wcm9j ZXNzX2VtYWNzICh2b2lkKQogICBGRF9aRVJPICgmbm9uX2tleWJvYXJkX3dhaXRfbWFzayk7 CiAgIEZEX1pFUk8gKCZub25fcHJvY2Vzc193YWl0X21hc2spOwogICBGRF9aRVJPICgmd3Jp dGVfbWFzayk7Ci0gIG1heF9wcm9jZXNzX2Rlc2MgPSBtYXhfaW5wdXRfZGVzYyA9IGV4dGVy bmFsX3NvY2tfZmQgPSAtMTsKKyAgbWF4X3Byb2Nlc3NfZGVzYyA9IG1heF9pbnB1dF9kZXNj ID0gLTE7CisgIGV4dGVybmFsX3NvY2tfZmQgPSBzb2NrZmQ7CiAgIG1lbXNldCAoZmRfY2Fs bGJhY2tfaW5mbywgMCwgc2l6ZW9mIChmZF9jYWxsYmFja19pbmZvKSk7CiAKICAgRkRfWkVS TyAoJmNvbm5lY3Rfd2FpdF9tYXNrKTsKLS0gCjIuNS41Cgo= --------------0B4D691C9895E78A9D709172--