From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Silence two Clang warnings Date: Thu, 15 Jun 2017 11:56:56 -0700 Organization: UCLA Computer Science Department Message-ID: References: <1e61fe6d-4646-b2ea-9dc1-7b782fc91e05@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497553063 16191 195.159.176.226 (15 Jun 2017 18:57:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Jun 2017 18:57:43 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 Cc: Emacs development discussions To: Philipp Stephani , Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 15 20:57:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLZxa-0003yq-6r for ged-emacs-devel@m.gmane.org; Thu, 15 Jun 2017 20:57:38 +0200 Original-Received: from localhost ([::1]:55465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLZxf-000736-Gx for ged-emacs-devel@m.gmane.org; Thu, 15 Jun 2017 14:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLZx0-00072o-Dv for emacs-devel@gnu.org; Thu, 15 Jun 2017 14:57:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLZwx-0000Zl-Ax for emacs-devel@gnu.org; Thu, 15 Jun 2017 14:57:02 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52926) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dLZwx-0000Yz-5M for emacs-devel@gnu.org; Thu, 15 Jun 2017 14:56:59 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 83B131600A6; Thu, 15 Jun 2017 11:56:57 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id l3DwEu6ucPYB; Thu, 15 Jun 2017 11:56:56 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C84911600A7; Thu, 15 Jun 2017 11:56:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id g6Spe-ez5i3l; Thu, 15 Jun 2017 11:56:56 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6AA6F1600A6; Thu, 15 Jun 2017 11:56:56 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215650 Archived-At: On 06/15/2017 06:11 AM, Philipp Stephani wrote: > Would you accept introducing pragmas to temporarily disable the > warnings in Clang (#pragma clang diagnostic push/ignore/pop), with an > explanation why they are false positives in these cases? That depends on what the warnings are and how useful they are elsewhere. These particular warnings do not seem to be useful for Emacs. For example, it is common practice in Emacs's C macros to parenthesize expressions to avoid operator-precedence confusion, and if Clang is complaining about the "extra" parentheses in the preprocessor output then that's clearly a warning that we should just shut off. Our goal is clarity and reliability, not Clang pacification.